Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FieldSet component #1082

Merged
merged 17 commits into from
Dec 14, 2023
Merged

Add FieldSet component #1082

merged 17 commits into from
Dec 14, 2023

Conversation

NataliaVizintini
Copy link
Contributor

@NataliaVizintini NataliaVizintini commented Apr 27, 2023 •
edited
Loading

Screenshot 2023-10-30 at 08 41 00

@NataliaVizintini NataliaVizintini self-assigned this Apr 27, 2023
@jamesricky
Copy link
Contributor

The styling and default props from components in the @comet/admin library should always be overridable using the theme, so the components can be customized for projects that require a different design.

Please implement this for the Accordion as well. Here is an example: https://comet-admin.netlify.app/?path=/story/docs-development-create-a-component-with-theme-support--page

jamesricky
jamesricky requested changes Apr 28, 2023
View reviewed changes
packages/admin/admin/src/common/Accordion.tsx Outdated Show resolved Hide resolved
packages/admin/admin/src/common/Accordion.tsx Outdated Show resolved Hide resolved
packages/admin/admin/src/index.ts Outdated Show resolved Hide resolved
packages/admin/admin/src/common/Accordion.tsx Outdated Show resolved Hide resolved
packages/admin/admin/src/common/Accordion.tsx Outdated Show resolved Hide resolved
@jamesricky
Copy link
Contributor

The closing animation doesn't seem to work in the story. Can you fix this?

@jamesricky jamesricky mentioned this pull request May 17, 2023
Closed
@NataliaVizintini NataliaVizintini changed the title Add Accordion component and Doku Add FieldSet component and Doku Sep 14, 2023
@johnnyomair
Copy link
Collaborator

Could you please try to port your stories to the Docusaurus docs?

johnnyomair
johnnyomair reviewed Oct 10, 2023
View reviewed changes
docs/docs/FieldSet.mdx Outdated Show resolved Hide resolved
docs/docs/FieldSet.mdx Outdated Show resolved Hide resolved
.changeset/light-pillows-flow.md Outdated Show resolved Hide resolved
.changeset/curvy-trains-deny.md Outdated Show resolved Hide resolved
docs/docs/FieldSet.mdx Outdated Show resolved Hide resolved
docs/docs/FieldSet.mdx Outdated Show resolved Hide resolved
packages/admin/admin/src/common/FieldSet.tsx Outdated Show resolved Hide resolved
packages/admin/admin/src/common/FieldSet.tsx Outdated Show resolved Hide resolved
packages/admin/admin/src/common/FieldSet.tsx Show resolved Hide resolved
jamesricky
jamesricky reviewed Oct 18, 2023
View reviewed changes
packages/admin/admin/src/common/FieldSet.tsx Outdated Show resolved Hide resolved
packages/admin/admin/src/common/FieldSet.tsx Outdated Show resolved Hide resolved
packages/admin/admin/src/common/FieldSet.tsx Outdated Show resolved Hide resolved
thomasdax98
thomasdax98 requested changes Oct 27, 2023
View reviewed changes
Copy link
Member

@thomasdax98 thomasdax98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NataliaVizintini The FieldSet doesn't look quite like the screen design. It should have no border and should have a border-radius: 4px.

Bildschirmfoto 2023-10-27 um 15 34 33

Can you please adjust that so that the default styling corresponds to the screen design?

thomasdax98
thomasdax98 previously approved these changes Nov 6, 2023
View reviewed changes
@johnnyomair johnnyomair mentioned this pull request Nov 15, 2023
Draft
@johnnyomair
Copy link
Collaborator

@thomasdax98 @jamesricky please review

@johnnyomair johnnyomair changed the title Add FieldSet component and Doku Add FieldSet component Dec 7, 2023
@vivid-planet vivid-planet deleted a comment from netlify bot Dec 13, 2023
@vivid-planet vivid-planet deleted a comment from netlify bot Dec 13, 2023
thomasdax98
thomasdax98 reviewed Dec 14, 2023
View reviewed changes
docs/docs/FieldSet.mdx Outdated Show resolved Hide resolved
docs/src/stories/FieldSet.tsx Outdated Show resolved Hide resolved
NataliaVizintini and others added 2 commits December 14, 2023 09:38
@NataliaVizintini @thomasdax98
Apply suggestions from code review
e96b5ff 
Story improvements

Co-authored-by: Thomas Dax <thomas.dax@vivid-planet.com>
@NataliaVizintini
Remove unused clsx and add summary and root classes
1175555
@johnnyomair johnnyomair merged commit 60cc1b2 into main Dec 14, 2023
11 checks passed
@johnnyomair johnnyomair deleted the accordion branch December 14, 2023 15:58
VP-DS pushed a commit to VP-DS/comet that referenced this pull request Jan 12, 2024
@NataliaVizintini @thomasdax98 @VP-DS
Add FieldSet component (vivid-planet#1082)
9b96351 
The `FieldSet` component is intended for better structuring of big forms. It allows the user to show and hide sections of related content on a page.

---------

Co-authored-by: Thomas Dax <thomas.dax@vivid-planet.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesricky jamesricky jamesricky approved these changes

@thomasdax98 thomasdax98 thomasdax98 approved these changes

@johnnyomair johnnyomair johnnyomair approved these changes

Assignees

@NataliaVizintini NataliaVizintini

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NataliaVizintini @jamesricky @johnnyomair @thomasdax98