-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Accordion styleOverride and Story #1107
Conversation
NataliaVizintini
commented
May 10, 2023
•
edited
Loading
edited
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accordion
is just a component we can use from MUI.
I don't think this requires documentation or stories in comet.
d007683
to
fc9bdd8
Compare
There should be a code example that shows how to achieve our "default" Accordion use case (title, support text, end adornment). Would you prefer only having a story for it, and no docs? |
[`& .${accordionSummaryClasses.expandIconWrapper}.${accordionSummaryClasses.expanded}`]: { | ||
transform: "rotate(90deg)", | ||
}, | ||
[`& .${accordionSummaryClasses.root}`]: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jamesricky Shouldn't summary and details styles be styled in their respective components themes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, good point 👍🏼
Yes, if there is a specific way we are supposed to use MUI's accordion in comet-projects, it might make sense to document this under Best Practices or in the Comet Docs. I don't think it should be included in the component-docs, as the component is already documented by MUI and when you work with comet you generally know to use MUI and it's docs. On the other hand, if we create a new component for the |
Closed in favor of #1082 |