Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Accordion styleOverride and Story #1107

Closed
wants to merge 2 commits into from
Closed

Conversation

NataliaVizintini
Copy link
Contributor

@NataliaVizintini NataliaVizintini commented May 10, 2023

Screenshot 2023-05-10 at 11 36 53

Copy link
Contributor

@jamesricky jamesricky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accordion is just a component we can use from MUI.
I don't think this requires documentation or stories in comet.

@johnnyomair
Copy link
Collaborator

Accordion is just a component we can use from MUI. I don't think this requires documentation or stories in comet.

There should be a code example that shows how to achieve our "default" Accordion use case (title, support text, end adornment). Would you prefer only having a story for it, and no docs?

[`& .${accordionSummaryClasses.expandIconWrapper}.${accordionSummaryClasses.expanded}`]: {
transform: "rotate(90deg)",
},
[`& .${accordionSummaryClasses.root}`]: {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesricky Shouldn't summary and details styles be styled in their respective components themes?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good point 👍🏼

@jamesricky
Copy link
Contributor

Accordion is just a component we can use from MUI. I don't think this requires documentation or stories in comet.

There should be a code example that shows how to achieve our "default" Accordion use case (title, support text, end adornment). Would you prefer only having a story for it, and no docs?

Yes, if there is a specific way we are supposed to use MUI's accordion in comet-projects, it might make sense to document this under Best Practices or in the Comet Docs.

I don't think it should be included in the component-docs, as the component is already documented by MUI and when you work with comet you generally know to use MUI and it's docs.

On the other hand, if we create a new component for the Accordion, like in #1082 it makes sense to have our own component docs.

@johnnyomair
Copy link
Collaborator

Closed in favor of #1082

@johnnyomair johnnyomair deleted the accordion-styling branch September 21, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants