Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Content translation #1725

Merged
merged 7 commits into from
Feb 20, 2024
Merged

[Feature] Content translation #1725

merged 7 commits into from
Feb 20, 2024

Conversation

johnnyomair
Copy link
Collaborator

@johnnyomair johnnyomair commented Feb 20, 2024

No description provided.

johnnyomair and others added 5 commits January 4, 2024 11:49
Merge `main` into `feature/translation-module`
Wrap a component with a `ContentTranslationServiceProvider` to add
support for content translation to all underlying `FinalFormInput`
inputs.
Wrap a component with a `ContentTranslationServiceProvider` to add
support for content translation to all underlying `FinalFormInput`
inputs.
…n-feature-branch

Merge main (v6) into translation feature branch
COM-202 , COM-203


https://github.com/vivid-planet/comet/assets/118435139/c230b360-c8ea-42d0-af0e-901e53ec172e

## Test custom inline styles: 

<details>
    <summary>Used customInlineStyles for RichTextBlock</summary>

```tsc
export const RichTextBlock = createRichTextBlock({
    link: LinkBlock,
    rte: {
        customInlineStyles: {
            HIGHLIGHT: {
                label: "Highlight!",
                icon: Highlight,
                style: {
                    backgroundColor: "yellow",
                },
            },
        },
    },
});
```

</details>


https://github.com/vivid-planet/comet/assets/118435139/bea488ec-99f7-448b-a9e0-c2d1e67580c3

## ⚠️ Note: The translation tool has to be smart enough to ignore the
html tags!

![Screenshot 2024-02-01 at 09 08
30](https://github.com/vivid-planet/comet/assets/118435139/26660266-990b-434e-9c50-b7eb387a54b4)

<details>
    <summary>External+News Link FinalFormInput disable Button</summary>

# dbe8ae3


https://github.com/vivid-planet/comet/assets/118435139/b85f5753-1619-4ccb-9634-4dc201221799
    
</details>
@johnnyomair johnnyomair changed the title Feature/translation module [Feature] Content translation Feb 20, 2024
@johnnyomair johnnyomair removed their assignment Feb 20, 2024
@johnnyomair
Copy link
Collaborator Author

@thomasdax98 I messed up by opening the PR, now I can't merge... Could you please approve and merge?

@thomasdax98 thomasdax98 merged commit 45295a5 into main Feb 20, 2024
10 checks passed
@johnnyomair johnnyomair deleted the feature/translation-module branch June 11, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants