Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting readOnly on FileSelect #2335

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Allow setting readOnly on FileSelect #2335

merged 2 commits into from
Jul 25, 2024

Conversation

jamesricky
Copy link
Contributor

@jamesricky jamesricky commented Jul 24, 2024 •
edited by johnnyomair
Loading

PR Checklist

Screenshot 2024-07-24 at 12 02 47

@jamesricky jamesricky self-assigned this Jul 24, 2024
@jamesricky jamesricky changed the base branch from next to dev-story-for-single-file-select July 24, 2024 10:04
@jamesricky jamesricky changed the title Allow setting readOnly on FileSelect Allow setting readOnly on FileSelect Jul 24, 2024
Base automatically changed from dev-story-for-single-file-select to next July 25, 2024 10:54
johnnyomair
johnnyomair reviewed Jul 25, 2024
View reviewed changes
Copy link
Collaborator

@johnnyomair johnnyomair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase, thanks!

packages/admin/admin/src/form/file/FileSelect.tsx Show resolved Hide resolved
packages/admin/admin/src/form/file/fileSelectItemTypes.ts Show resolved Hide resolved
@jamesricky jamesricky marked this pull request as ready for review July 25, 2024 11:15
@auto-assign auto-assign bot requested a review from johnnyomair July 25, 2024 11:15
@johnnyomair johnnyomair merged commit 1e14f2a into next Jul 25, 2024
11 checks passed
@johnnyomair johnnyomair deleted the file-select-readonly branch July 25, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnyomair johnnyomair johnnyomair approved these changes

Assignees

@jamesricky jamesricky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesricky @johnnyomair