Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for CLI interaction with registry having self-signed CA #252

Merged
merged 1 commit into from
May 3, 2023

Conversation

prkalle
Copy link
Contributor

@prkalle prkalle commented May 3, 2023

What this PR does / why we need it

This PR adds documentation for CLI interaction with registry which has self-signed CA certificate or expired certificate

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

Release note

N/A

Additional information

Special notes for your reviewer

Copy link
Contributor

@marckhouzam marckhouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just grammatical comments.

Do we want to mention how to deal with a proxy, or do we wait until the PR that improves that solution?

docs/full/README.md Outdated Show resolved Hide resolved
docs/full/README.md Outdated Show resolved Hide resolved
docs/full/README.md Outdated Show resolved Hide resolved
docs/full/README.md Outdated Show resolved Hide resolved
docs/full/README.md Outdated Show resolved Hide resolved
docs/full/README.md Outdated Show resolved Hide resolved
docs/full/README.md Outdated Show resolved Hide resolved
@prkalle
Copy link
Contributor Author

prkalle commented May 3, 2023

Do we want to mention how to deal with a proxy, or do we wait until the PR that improves that solution?

Yes, we will update the documention for proxy certificate configuration when we have the PR to improve that solution

…d CA

Signed-off-by: Prem Kumar Kalle <pkalle@vmware.com>
Copy link
Contributor

@marckhouzam marckhouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marckhouzam marckhouzam merged commit 2c2d9aa into vmware-tanzu:main May 3, 2023
vuil pushed a commit to vuil/tanzu-cli that referenced this pull request May 16, 2023
…d CA (vmware-tanzu#252)

Signed-off-by: Prem Kumar Kalle <pkalle@vmware.com>
@marckhouzam marckhouzam added this to the v0.90.0 milestone Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants