-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for installing plugins in air-gapped environments #254
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! The comments are mostly grammatical.
For each section, could we add a first line saying "The below steps should be performed by the operator of the private registry" or "The below steps should be performed by users of the Tanzu CLI"?
Could we also put a note to "Refer to ..." @prkalle section on how to setup certificates for air-gapped from #252.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also have a section to quickly mention how to install the CLI itself in an air-gapped env?
2ce583c
to
e4c61ed
Compare
Added a small section at the top. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
What this PR does / why we need it
Which issue(s) this PR fixes
Related to #223
Describe testing done for PR
Release note
Additional information
Special notes for your reviewer