Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for installing plugins in air-gapped environments #254

Merged
merged 2 commits into from
May 3, 2023

Conversation

anujc25
Copy link
Contributor

@anujc25 anujc25 commented May 3, 2023

What this PR does / why we need it

  • Add documentation for installing plugins in air-gapped environments

Which issue(s) this PR fixes

Related to #223

Describe testing done for PR

Release note

NONE

Additional information

Special notes for your reviewer

@anujc25 anujc25 requested a review from a team as a code owner May 3, 2023 06:43
Copy link
Contributor

@marckhouzam marckhouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! The comments are mostly grammatical.

For each section, could we add a first line saying "The below steps should be performed by the operator of the private registry" or "The below steps should be performed by users of the Tanzu CLI"?

Could we also put a note to "Refer to ..." @prkalle section on how to setup certificates for air-gapped from #252.

docs/full/README.md Outdated Show resolved Hide resolved
docs/full/README.md Outdated Show resolved Hide resolved
docs/full/README.md Outdated Show resolved Hide resolved
docs/full/README.md Outdated Show resolved Hide resolved
docs/full/README.md Outdated Show resolved Hide resolved
docs/full/README.md Outdated Show resolved Hide resolved
docs/full/README.md Outdated Show resolved Hide resolved
docs/full/README.md Outdated Show resolved Hide resolved
docs/full/README.md Outdated Show resolved Hide resolved
docs/full/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@marckhouzam marckhouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also have a section to quickly mention how to install the CLI itself in an air-gapped env?

@anujc25 anujc25 force-pushed the airgapped-docs branch 3 times, most recently from 2ce583c to e4c61ed Compare May 3, 2023 20:39
@anujc25
Copy link
Contributor Author

anujc25 commented May 3, 2023

Should we also have a section to quickly mention how to install the CLI itself in an air-gapped env?

Added a small section at the top.

Copy link
Contributor

@marckhouzam marckhouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@marckhouzam marckhouzam merged commit f4963ff into vmware-tanzu:main May 3, 2023
@marckhouzam marckhouzam added this to the v0.90.0 milestone Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants