Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional "operationID" to vmomi calls #749

Closed
hickeng opened this issue Jun 19, 2017 · 2 comments
Closed

Add optional "operationID" to vmomi calls #749

hickeng opened this issue Jun 19, 2017 · 2 comments

Comments

@hickeng
Copy link
Member

hickeng commented Jun 19, 2017

Follow on from vmware/vic#2739

We've been needing to add a cross boundary correlation ID for some time - turns out that @derekbeard had noted the solution in the above issue but I'd not come back it since.
Please can this be added via optional context.WithValue - preferably with a runtime bound key so that we can easily couple the vic trace package and govmomi without having to hardcode the same key.

Original from derek:

I tracked this down a bit more. I spoke with Kira on our team about how VCQE is able to log the opid. It turns out, that VC supports client-generated OpIDs, so VCQE generates it and passes it as an “operationID” SOAP element in the SOAP header. My guess is that we could update the govmomi SOAP client (https://github.com/vmware/govmomi/tree/master/vim25/soap) to pass an OPID generated upstream.

@dougm
Copy link
Member

dougm commented Jun 20, 2017

We can certainly do that. Any pointers to the header name, value format we'd need to use?

@hickeng
Copy link
Member Author

hickeng commented Jun 23, 2017

"operationID" was quoted in the email, so maybe it's as simple as that - if not I'd have to dig it up out of code which automatically makes it deferred until we actually start addressing the operation logging in the VIC side of things.

dougm added a commit to dougm/govmomi that referenced this issue Sep 26, 2017
anfernee pushed a commit to anfernee/govmomi that referenced this issue Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants