Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add opid to log messages from our calls to vsphere #2739

Closed
mhagen-vmware opened this issue Oct 14, 2016 · 4 comments
Closed

Add opid to log messages from our calls to vsphere #2739

mhagen-vmware opened this issue Oct 14, 2016 · 4 comments
Assignees
@cgtexmex
Labels
area/diagnostics Utilities, procedures, and output to help to identify errors kind/debt Problems that increase the cost of other work priority/p0 product/govmomi Related to the Go library for interacting with VMware vSphere APIs team/foundation
Milestone
Sprint 20 Foundation

Comments

@mhagen-vmware
Copy link
Contributor

mhagen-vmware commented Oct 14, 2016 •
edited
Loading

Don't know if govmomi returns the OP ID but the api calls that it is using does according to @derekbeard

It would help future debugging efforts if we added this.

As an engineer on VIC, it would be useful for debugging purposes to include the OP ID on vsphere operations so that we can track operations through vsphere related logs while debugging.
@mhagen-vmware mhagen-vmware added the product/govmomi Related to the Go library for interacting with VMware vSphere APIs label Oct 14, 2016
@mhagen-vmware mhagen-vmware added this to the VIC GA Release milestone Oct 14, 2016
@hickeng
Copy link
Member

hickeng commented Oct 17, 2016

@carlsone Has mentioned the utility of this opid for full stack performance analysis in the past.
The pkg/vsphere/task package was supposed to provide logging for the bridging between VHC operation and vSphere operations.
This should be glued together with the recent pkg/trace operation code.

@mdubya66 mdubya66 removed this from the VIC GA Release milestone Nov 1, 2016
@matthewavery
Copy link
Contributor

matthewavery commented Nov 2, 2016 •
edited
Loading

I could not find the exact opID listed in the hostd operation calls. I have not yet found a way to obtain that opID from the TaskInfo object that is returned to us. @derekbeard @hickeng Any advice on where to find it?

@derekbeard
Copy link

I tracked this down a bit more. I spoke with Kira on our team about how VCQE is able to log the opid. It turns out, that VC supports client-generated OpIDs, so VCQE generates it and passes it as an “operationID” SOAP element in the SOAP header. My guess is that we could update the govmomi SOAP client (https://github.com/vmware/govmomi/tree/master/vim25/soap) to pass an OPID generated upstream.

@hickeng hickeng added the kind/debt Problems that increase the cost of other work label Apr 13, 2017
@hickeng hickeng mentioned this issue Jun 19, 2017
Closed
@hickeng
Copy link
Member

hickeng commented Jun 19, 2017

Blocked by vmware/govmomi#749 - zenhub doesn't seem to support cross repo linking for blockers.

@hickeng hickeng added the area/diagnostics Utilities, procedures, and output to help to identify errors label Jun 21, 2017
@cgtexmex cgtexmex self-assigned this Oct 17, 2017
@cgtexmex cgtexmex added this to the Sprint 19 Foundation milestone Oct 17, 2017
@cgtexmex cgtexmex mentioned this issue Oct 18, 2017
Closed
@cgtexmex cgtexmex mentioned this issue Oct 27, 2017
Merged
cgtexmex pushed a commit to cgtexmex/vic that referenced this issue Nov 2, 2017
WIP - Add operation id to vSphere calls
6c26587 
Fixes vmware#2739
cgtexmex pushed a commit to cgtexmex/vic that referenced this issue Nov 3, 2017
WIP - Add operation id to vSphere calls
48dea6d 
Fixes vmware#2739
@cgtexmex cgtexmex mentioned this issue Nov 3, 2017
Merged
cgtexmex pushed a commit to cgtexmex/vic that referenced this issue Nov 3, 2017
Add operation id to vSphere calls
b6351db 
Increase use of trace.Operation as well as pass the
operation.ID to vSphere for observability within the
vSphere logs.

Fixes vmware#2739
cgtexmex pushed a commit to cgtexmex/vic that referenced this issue Nov 3, 2017
Add operation id to vSphere calls
254520e 
Increase use of trace.Operation as well as pass the
operation.ID to vSphere for observability within the
vSphere logs.

Fixes vmware#2739
cgtexmex pushed a commit to cgtexmex/vic that referenced this issue Nov 3, 2017
Add operation id to vSphere calls
e96db28 
Increase use of trace.Operation as well as pass the
operation.ID to vSphere for observability within the
vSphere logs.

Fixes vmware#2739
cgtexmex pushed a commit to cgtexmex/vic that referenced this issue Nov 3, 2017
Add operation id to vSphere calls
f0d892f 
Increase use of trace.Operation as well as pass the
operation.ID to vSphere for observability within the
vSphere logs.

Fixes vmware#2739
cgtexmex pushed a commit to cgtexmex/vic that referenced this issue Nov 6, 2017
Add operation id to vSphere calls
c17b685 
Increase use of trace.Operation as well as pass the
operation.ID to vSphere for observability within the
vSphere logs.

Fixes vmware#2739
cgtexmex pushed a commit to cgtexmex/vic that referenced this issue Nov 7, 2017
Add operation id to vSphere calls
bbe4251 
Increase use of trace.Operation as well as pass the
operation.ID to vSphere for observability within the
vSphere logs.

Fixes vmware#2739
cgtexmex pushed a commit to cgtexmex/vic that referenced this issue Nov 7, 2017
Add operation id to vSphere calls
cda79c5 
Increase use of trace.Operation as well as pass the
operation.ID to vSphere for observability within the
vSphere logs.

Fixes vmware#2739
cgtexmex pushed a commit to cgtexmex/vic that referenced this issue Nov 8, 2017
Add operation id to vSphere calls
1eea945 
Increase use of trace.Operation as well as pass the
operation.ID to vSphere for observability within the
vSphere logs.

Fixes vmware#2739
cgtexmex pushed a commit to cgtexmex/vic that referenced this issue Nov 8, 2017
Add operation id to vSphere calls
7b1e2df 
Increase use of trace.Operation as well as pass the
operation.ID to vSphere for observability within the
vSphere logs.

Fixes vmware#2739
cgtexmex pushed a commit to cgtexmex/vic that referenced this issue Nov 8, 2017
Add operation id to vSphere calls
d626ac6 
Increase use of trace.Operation as well as pass the
operation.ID to vSphere for observability within the
vSphere logs.

Fixes vmware#2739
cgtexmex pushed a commit that referenced this issue Nov 8, 2017
Add operation id to vSphere calls (#6692)
d0795f5 
Increase use of trace.Operation as well as pass the
operation.ID to vSphere for observability within the
vSphere logs.

Fixes #2739
AngieCris pushed a commit to AngieCris/vic that referenced this issue Nov 20, 2017
@AngieCris
Add operation id to vSphere calls (vmware#6692)
fd41439 
Increase use of trace.Operation as well as pass the
operation.ID to vSphere for observability within the
vSphere logs.

Fixes vmware#2739
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cgtexmex cgtexmex

Labels
area/diagnostics Utilities, procedures, and output to help to identify errors kind/debt Problems that increase the cost of other work priority/p0 product/govmomi Related to the Go library for interacting with VMware vSphere APIs team/foundation
Projects
None yet
Milestone
Sprint 20 Foundation
Development

No branches or pull requests
6 participants
@cgtexmex @hickeng @matthewavery @derekbeard @mdubya66 @mhagen-vmware