Merge/v0.25.0 to develop #4706
Merge/v0.25.0 to develop #4706
Conversation
* fix script tag * clearbit
panel tweaks
Release/v0.25.0
Release notes v0.25.0
WalkthroughThe recent updates encompass a variety of improvements across documentation and codebase components, enhancing clarity, organization, and functionality. Key changes include standardizing naming conventions, refining instructional text, enriching documentation with new features, and improving user management capabilities. These modifications aim to optimize the user experience, ensure compliance with standards, and foster better engagement with the FiftyOne framework. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Dashboard as Custom Dashboard
participant Plugin as Plugin System
User->>Plugin: Request to create custom dashboard
Plugin->>Dashboard: Initialize dashboard creation
Dashboard-->>User: Display dashboard interface
User->>Dashboard: Add components to dashboard
Dashboard-->>User: Show updated dashboard
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Outside diff range, codebase verification and nitpick comments (3)
docs/source/release-notes.rst (3)
14-15: Clarify the "Can tag" permission description.The description of the "Can tag" permission could be more explicit about what "tagging" entails and how it differs from other editing capabilities.
Consider rephrasing to clarify the specific actions allowed by this permission.
- Added a :ref:`Can tag <teams-can-tag>` permission to allow users to tag - samples/labels but not otherwise perform edits + Added a :ref:`Can tag <teams-can-tag>` permission to allow users to add tags + to samples/labels without granting broader editing capabilities
18-19: Clarify plugin execution description.The description of plugin execution being "user-aware" could be expanded to specify what "user-aware" means in this context.
Consider providing more detail about the implications of this change.
- All :ref:`plugin execution <teams-plugins>` is now user-aware and will - respect the executing user’s role and dataset permissions + All :ref:`plugin execution <teams-plugins>` is now user-aware, meaning that + it will respect the executing user’s role and dataset permissions, ensuring + that plugins operate within the user's access rights
63-66: Clarify Python panels description.The description of Python panels could be expanded to specify the benefits or use cases for this feature.
Consider providing more context about how Python panels enhance user experience.
- Introducing :ref:`Python panels <developing-panels>`, a powerful framework for - building custom App panels via a simple Python interface that includes a - wealth of builtin components to convey information, create tutorials, show - interactive graphs, trigger operations, and more + Introducing :ref:`Python panels <developing-panels>`, a powerful framework for + building custom App panels via a simple Python interface. This feature + includes a wealth of builtin components to convey information, create + tutorials, show interactive graphs, trigger operations, and more, enhancing + the flexibility and interactivity of the App
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (1)
docs/source/images/plugins/panels/dashboard-panel.gifis excluded by!**/*.gif,!**/*.gif
Files selected for processing (9)
- app/packages/core/src/plugins/SchemaIO/components/DashboardView.tsx (2 hunks)
- docs/source/_templates/layout.html (2 hunks)
- docs/source/deprecation.rst (1 hunks)
- docs/source/plugins/developing_plugins.rst (13 hunks)
- docs/source/plugins/index.rst (2 hunks)
- docs/source/release-notes.rst (1 hunks)
- docs/source/teams/management_sdk.rst (3 hunks)
- fiftyone/operators/init.py (1 hunks)
- package/db/setup.py (3 hunks)
Files skipped from review due to trivial changes (4)
- app/packages/core/src/plugins/SchemaIO/components/DashboardView.tsx
- docs/source/_templates/layout.html
- docs/source/deprecation.rst
- docs/source/teams/management_sdk.rst
Additional context used
Ruff
fiftyone/operators/__init__.py
17-17:
.executor.ExecutionContextimported but unused; consider removing, adding to__all__, or using a redundant alias(F401)
Additional comments not posted (8)
docs/source/plugins/index.rst (1)
44-45: New plugin entry for@voxel51/dashboardlooks good.The addition of the
@voxel51/dashboardplugin entry is well-formatted and consistent with existing documentation entries. It enhances the documentation by providing users with more options for customization.Also applies to: 85-90
package/db/setup.py (3)
68-89: New MongoDB download URLs for Ubuntu versions under "pop" look good.The addition of download URLs for various architectures and Ubuntu versions enhances the functionality to support additional environments.
145-145: Case-insensitive key lookup in_get_linux_download()is a good improvement.Changing the dictionary key to
d["ID"].lower()ensures robustness by preventing potential mismatches due to case sensitivity.
168-168: Version increment to 1.1.5 is appropriate.The version update reflects the inclusion of new download URLs and improvements in the logic.
docs/source/plugins/developing_plugins.rst (4)
2474-2479: Renaming toDropdownMenuExampleand method improvements look good.The renaming of
DropdownMenuPaneltoDropdownMenuExampleand the addition of thevariantparameter insay_hiimprove clarity and consistency.Also applies to: 2495-2509
2597-2602: Interactive plot example improvements are well-implemented.The renaming to
InteractivePlotExampleand the changes in method implementations enhance usability and readability. The_make_matching_viewfunction provides a clear purpose.Also applies to: 2608-2621, 2633-2637, 2663-2666, 2682-2682
2709-2714: Walkthrough example updates improve clarity and engagement.The renaming to
WalkthroughExampleand the adjustments in layout and navigation enhance the user experience and clarity of the walkthrough.Also applies to: 2748-2750
2853-2858: Image and media player examples are well-structured.The renaming to
ImageExampleandMediaPlayerExamplealigns with the new naming conventions, improving consistency and clarity.Also applies to: 2915-2920
| @@ -14,6 +14,7 @@ | |||
| ) | |||
| from .executor import ( | |||
| execute_operator, | |||
| ExecutionContext, | |||
There was a problem hiding this comment.
Address the unused import of ExecutionContext.
The ExecutionContext is imported but not used in this file. Consider removing it, adding it to __all__, or using it in the code to avoid unnecessary imports.
- ExecutionContext,Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ExecutionContext, |
Tools
Ruff
17-17:
.executor.ExecutionContextimported but unused; consider removing, adding to__all__, or using a redundant alias(F401)
What changes are proposed in this pull request?
Merge final 0.25.0 changes into develop
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Chores