make ensure for package and service configurable #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igalic
suggested changes
Feb 11, 2017
There was a problem hiding this comment.
first off, thank you very much for this pull request, in particular for filling the gaps in the documentation.
before accepting this pr, i would like you to make the change i requested above: we shouldn't change existing behaviour, especially when that change could lead to very unintended consequences.
manifests/params.pp
Outdated
| @@ -5,7 +5,10 @@ | |||
| # | |||
| class proxysql::params { | |||
| $package_name = 'proxysql' | |||
| $package_ensure = 'latest' | |||
There was a problem hiding this comment.
please leave this, by default, as installed
|
You have a valid point! I've updated the PR. |
igalic
reviewed
Feb 11, 2017
spec/classes/proxysql_spec.rb
Outdated
| it { is_expected.to contain_class('mysql::client').with(bindings_enable: false) } | ||
|
|
||
| it { is_expected.to contain_package('proxysql').with_ensure('present') } | ||
| it { is_expected.to contain_package('proxysql').with_ensure('latest') } |
There was a problem hiding this comment.
this is going to be wrong now ;)
cegeka-jenkins
pushed a commit
to cegeka/puppet-proxysql
that referenced
this pull request
Aug 22, 2023
make ensure for package and service configurable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.