make ensure for package and service configurable

README.markdown

@@ -108,9 +108,15 @@ You can override any configuration setting by using the `override_config_setting
 ##### `package_name`
 The name of the ProxySQL package in your package manager. Defaults to 'proxysql'
 
+##### `package_ensure`
+The ensure of the ProxySQL package resource. Defaults to 'latest'
+
 ##### `service_name`
 The name of the ProxySQL service resource. Defaults to 'proxysql'
 
+##### `service_ensure`
+The ensure of the ProxySQL service resource. Defaults to 'running'
+
 ##### `datadir`
 The directory where ProxySQL will store it's data. defaults to '/var/lib/proxysql'
 

manifests/init.pp

@@ -9,9 +9,15 @@
 # * `package_name`
 #   The name of the ProxySQL package in your package manager. Defaults to 'proxysql'
 #
+# * `package_ensure`
+#   The ensure of the ProxySQL package resource. Defaults to 'latest'
+#
 # * `service_name`
 #   The name of the ProxySQL service resource. Defaults to 'proxysql'
 #
+# * `service_ensure`
+#   The ensure of the ProxySQL service resource. Defaults to 'running'
+#
 # * `datadir`
 #   The directory where ProxySQL will store it's data. defaults to '/var/lib/proxysql'
 #
@@ -68,12 +74,22 @@
 # * `save_to_disk`
 #   Specifies wheter te managed ProxySQL resources should be immediately save to disk. Boolean, defaults to 'true'.
 #
+# * `manage_repo`
+#   Determines wheter this module will manage the repositories where ProxySQL might be. Defaults to 'true'
+#
+# * `repo
+#   These are the repo's we will configure. Currently only Debian is supported. This hash will be passed on
+#   to `apt::source`. Defaults to {}.
+#
 # * `override_config_settings`
 #   Which configuration variables should be overriden. Hash, defaults to {} (empty hash).
 #
 class proxysql (
   String $package_name = $::proxysql::params::package_name,
+  String $package_ensure = $::proxysql::params::package_ensure,
+
   String $service_name = $::proxysql::params::service_name,
+  String $service_ensure = $::proxysql::params::service_ensure,
 
   String $datadir = $::proxysql::params::datadir,
 

manifests/install.pp

@@ -5,7 +5,7 @@
 class proxysql::install {
 
   package { $::proxysql::package_name:
-    ensure => present,
+    ensure => $::proxysql::package_ensure,
   }
 
   file { 'proxysql-datadir':

manifests/params.pp

@@ -5,7 +5,10 @@
 #
 class proxysql::params {
   $package_name = 'proxysql'
+  $package_ensure = 'installed'
+
   $service_name = 'proxysql'
+  $service_ensure = 'running'
 
   $listen_ip     = '0.0.0.0'
   $listen_port   = 6033

manifests/service.pp

@@ -7,7 +7,7 @@
 
   if $::proxysql::restart {
     service { $::proxysql::service_name:
-      ensure     => running,
+      ensure     => $::proxysql::service_ensure,
       enable     => true,
       hasstatus  => true,
       hasrestart => false,
@@ -18,7 +18,7 @@
     }
   } else {
     service { $::proxysql::service_name:
-      ensure     => running,
+      ensure     => $::proxysql::service_ensure,
       enable     => true,
       hasstatus  => true,
       hasrestart => true,

spec/classes/proxysql_spec.rb

@@ -13,13 +13,20 @@
           it { is_expected.to compile.with_all_deps }
 
           it { is_expected.to contain_class('proxysql::params') }
+          it { is_expected.to contain_class('proxysql::repo').that_comes_before('Class[proxysql::install]') }
           it { is_expected.to contain_class('proxysql::install').that_comes_before('Class[proxysql::config]') }
           it { is_expected.to contain_class('proxysql::config').that_comes_before('Class[proxysql::service]') }
           it { is_expected.to contain_class('proxysql::service').that_subscribes_to('Class[proxysql::install]') }
 
+          it { is_expected.to contain_anchor('::proxysql::begin').that_comes_before('Class[proxysql::repo]') }
+          it { is_expected.to contain_anchor('::proxysql::end') }
+          it { is_expected.to contain_class('proxysql::service').that_comes_before('Anchor[::proxysql::end]') }
+
+          it { is_expected.to contain_class('proxysql::install').that_notifies('Class[proxysql::service]') }
+
           it { is_expected.to contain_class('mysql::client').with(bindings_enable: false) }
 
-          it { is_expected.to contain_package('proxysql').with_ensure('present') }
+          it { is_expected.to contain_package('proxysql').with_ensure('installed') }
 
           it do
             is_expected.to contain_file('proxysql-config-file').with(ensure: 'file',
@@ -51,6 +58,17 @@
                                                             hasstatus: true,
                                                             hasrestart: true)
           end
+
+          it do
+            is_expected.to contain_exec('wait_for_admin_socket_to_open').with(
+              command:   'test -S /tmp/proxysql_admin.sock',
+              unless:    'test -S /tmp/proxysql_admin.sock',
+              tries:     3,
+              try_sleep: 10,
+              require:   'Service[proxysql]',
+              path:      '/bin:/usr/bin'
+            )
+          end
         end
       end
     end