Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename address space override ports from private to local #46942

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Rename private address space overrides ports in tests
The tests still use "private" as the internal naming because the specific spec they are testing, is awaiting a decision on whether to call it "private" or "local".
  • Loading branch information
atjn committed Jun 29, 2024
commit 52e82c49284d6c4cb08e0ab8e5b651038d2406d7
4 changes: 2 additions & 2 deletions fetch/private-network-access/resources/support.sub.js
Original file line number Diff line number Diff line change
Expand Up @@ -76,13 +76,13 @@ async function postMessageAndAwaitReply(target, message) {
const SERVER_PORTS = {
"http": {
"local": {{ports[http][0]}},
"private": {{ports[http-private][0]}},
"private": {{ports[http-local][0]}},
"public": {{ports[http-public][0]}},
},
"https": {
"local": {{ports[https][0]}},
"other-local": {{ports[https][1]}},
"private": {{ports[https-private][0]}},
"private": {{ports[https-local][0]}},
"public": {{ports[https-public][0]}},
},
"ws": {
Expand Down
4 changes: 2 additions & 2 deletions infrastructure/assumptions/non-local-ports.sub.window.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
// More tests can be found in `fetch/private-network-access/`.

const alternatePorts = {
httpPrivate: "{{ports[http-private][0]}}",
httpsPrivate: "{{ports[https-private][0]}}",
httpPrivate: "{{ports[http-local][0]}}",
httpsPrivate: "{{ports[https-local][0]}}",
httpPublic: "{{ports[http-public][0]}}",
httpsPublic: "{{ports[https-public][0]}}",
};
Expand Down