Rename address space override ports from private to local #46942
+13
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
added
fetch
infra
serve
wptrunner
wpt-pr-bot
requested review from
annevk,
DanielRyanSmith,
foolip,
hemeryar,
jdm,
jgraham,
mikewest,
mnot,
youennf and
yutakahirano
atjn
force-pushed
the
private-local-rename
branch
from
8ab6ec6
to
aa40c6d
Compare
|
As far as I can tell, the flaky test results in chrome are not caused by these changes. My guess would be that the HTTP server was too slow in the test machine. |
The tests still use "private" as the internal naming because the specific spec they are testing, is awaiting a decision on whether to call it "private" or "local".
atjn
force-pushed
the
private-local-rename
branch
from
aa40c6d
to
52e82c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RFC for this feature was changed to use
localinstead ofprivate, but the implementation of the feature was never renamed. This should fix the renaming. Link to the RFC rename: web-platform-tests/rfcs#135Please note that this feature was originally created to test the implementation of the
private-network-accessspec, and it is unclear whether that spec will keep its name or be renamed tolocal-network-access. It is however clear that "local" better describes what this feature is providing. Given that this WPT feature is not tied to theprivate-network-accessspec, and can be used to test many other specs, it should use the best available name, and that name is "local". Link to discussion on this: #38939