Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tx Types and ERC20 token transaction #7156

Merged
merged 10 commits into from
Jul 17, 2024
Merged

Tx Types and ERC20 token transaction #7156

merged 10 commits into from
Jul 17, 2024

Conversation

SantiagoDevRel
Copy link
Member

Closes #5732

Copy link

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 636.12 kB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
web3.min.js 616.83 kB 0%
../lib/commonjs/index.d.ts 8.69 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.67 kB 0%
../lib/commonjs/web3.d.ts 1.35 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.2 kB 0%
../lib/commonjs/abi.d.ts 999 B 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: b7a848e Previous: 9afaa61 Ratio
processingTx 9088 ops/sec (±3.54%) 9405 ops/sec (±3.55%) 1.03
processingContractDeploy 36084 ops/sec (±8.12%) 40485 ops/sec (±7.27%) 1.12
processingContractMethodSend 15510 ops/sec (±7.17%) 15979 ops/sec (±8.96%) 1.03
processingContractMethodCall 27073 ops/sec (±7.14%) 28320 ops/sec (±6.00%) 1.05
abiEncode 41898 ops/sec (±7.39%) 44820 ops/sec (±7.48%) 1.07
abiDecode 29265 ops/sec (±8.13%) 30901 ops/sec (±8.03%) 1.06
sign 1466 ops/sec (±3.57%) 1528 ops/sec (±3.66%) 1.04
verify 367 ops/sec (±0.57%) 377 ops/sec (±0.59%) 1.03

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.46%. Comparing base (9afaa61) to head (b7a848e).

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #7156   +/-   ##
=======================================
  Coverage   94.46%   94.46%           
=======================================
  Files         215      215           
  Lines        8396     8396           
  Branches     2315     2315           
=======================================
  Hits         7931     7931           
  Misses        465      465           
Flag Coverage Δ
UnitTests 94.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

docs/docs/guides/wallet/tx-types.md Outdated Show resolved Hide resolved
docs/docs/guides/wallet/tx-types.md Outdated Show resolved Hide resolved
docs/docs/guides/wallet/tx-types.md Outdated Show resolved Hide resolved
docs/docs/guides/wallet/tx-types.md Outdated Show resolved Hide resolved
docs/docs/guides/wallet/tx-types.md Outdated Show resolved Hide resolved
docs/docs/guides/wallet/tx-types.md Outdated Show resolved Hide resolved
SantiagoDevRel and others added 6 commits July 16, 2024 18:46
Co-authored-by: Dan Forbes <dan.forbes@chainsafe.io>
Co-authored-by: Dan Forbes <dan.forbes@chainsafe.io>
Co-authored-by: Dan Forbes <dan.forbes@chainsafe.io>
Co-authored-by: Dan Forbes <dan.forbes@chainsafe.io>
Co-authored-by: Dan Forbes <dan.forbes@chainsafe.io>
Co-authored-by: Dan Forbes <dan.forbes@chainsafe.io>
@SantiagoDevRel
Copy link
Member Author

Thank you @danforbes for the heads up w the typos!💪

docs/docs/guides/wallet/tx-types.md Outdated Show resolved Hide resolved
docs/docs/guides/wallet/tx-types.md Outdated Show resolved Hide resolved

## Transaction Type 2 (EIP-1559)

When a user creates an EIP-1559 transaction, they specify the maximum fee they are willing to pay `maxFeePerGas` as well as a tip `maxPriorityFeePerGas` to incentivize the miner. The actual fee paid by the user is then determined by the network based on the current demand for block space and the priority of the transaction.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very helpful! nice.

@luu-alex
Copy link
Contributor

if you can also loop @danforbes into this that would be great. When he has free time would like to also have his opinion on this!

@luu-alex
Copy link
Contributor

nevermind, hes already commented :)

Co-authored-by: Alex  <luu.alex98@gmail.com>
Co-authored-by: Alex  <luu.alex98@gmail.com>
@SantiagoDevRel SantiagoDevRel merged commit 5ad7e5b into 4.x Jul 17, 2024
54 checks passed
@SantiagoDevRel SantiagoDevRel deleted the 5732 branch July 17, 2024 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example of EIP-1559 Transfer for ERC20 token
3 participants