Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CSI-226): support IPv6 in APIclient #287

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Conversation

sergeyberezansky
Copy link
Collaborator

@sergeyberezansky sergeyberezansky commented Jul 23, 2024

TL;DR

This PR adds validation functions to check for valid IPv4, IPv6 addresses, and hostnames in the resetDefaultEndpoints method and skips endpoints that do not pass validation.

What changed?

  • Introduced isValidIPv4Address, isValidIPv6Address, and isValidHostname functions.
  • Updated the resetDefaultEndpoints method to utilize these validation functions and skip invalid endpoints.

How to test?

  • Add unit tests to check validation functions with various inputs.
  • Test CSI plugin basic sanity in IPv6-enabled Kubernetes cluster against IPv6-only Weka cluster (install, create PVC, create pod)

Why make this change?

  • This change ensures that IPv6 addresses can be specified in configuration

Copy link

graphite-app bot commented Jul 23, 2024

Graphite Automations

"Request reviewers once CI passes" took an action on this PR • (07/23/24)

1 reviewer was added to this PR based on Sergey Berezansky's automation.

@sergeyberezansky sergeyberezansky changed the base branch from sergey/fix-race-on-multi-delete to sergey/allow-wekapp-lint July 28, 2024 15:58
@sergeyberezansky sergeyberezansky force-pushed the sergey/allow-wekapp-lint branch 2 times, most recently from 45e9098 to 59acf13 Compare July 29, 2024 06:08
@sergeyberezansky sergeyberezansky force-pushed the sergey/allow-wekapp-lint branch 6 times, most recently from ed317d8 to c47827d Compare July 30, 2024 07:25
Copy link
Collaborator Author

sergeyberezansky commented Jul 31, 2024

Merge activity

@sergeyberezansky sergeyberezansky changed the base branch from sergey/allow-wekapp-lint to dev July 31, 2024 10:53
@sergeyberezansky sergeyberezansky merged commit c0921ca into dev Jul 31, 2024
4 checks passed
@sergeyberezansky sergeyberezansky deleted the sergey/ipv6-support branch July 31, 2024 11:53
@sergeyberezansky sergeyberezansky added enhancement New feature or request feature and removed enhancement New feature or request labels Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant