Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CSI-227): allow host networking via configuration #288

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

sergeyberezansky
Copy link
Collaborator

@sergeyberezansky sergeyberezansky commented Jul 23, 2024

TL;DR

This pull request introduces a conditional configuration to enable hostNetwork support for the csi-wekafsplugin Helm chart. The changes involve adding conditional checks in the templates to apply the hostNetwork settings based on the values provided.

What changed?

  • Added conditional statements to controllerserver-statefulset.yaml and nodeserver-daemonset.yaml to apply hostNetwork settings.
  • Updated security context constraints templates to allow host networking when the hostNetwork value is true.
  • Modified port numbers in the nodeserver-daemonset.yaml to accommodate the hostNetwork setup.

How to test?

  1. Set hostNetwork: true in the values.yaml file.
  2. Deploy the Helm chart.
  3. Verify that the necessary resources are deployed with the hostNetwork configuration.

Why make this change?

This change is motivated by the need to support host networking for specific environments where pod networking might be insufficient or problematic, such as Weka clusters running on top of Kubernetes. Allowing conditional hostNetwork configuration provides greater flexibility and control over the networking setup of the CSI driver components.

Copy link

graphite-app bot commented Jul 23, 2024

Graphite Automations

"Request reviewers once CI passes" took an action on this PR • (07/23/24)

1 reviewer was added to this PR based on Sergey Berezansky's automation.

Copy link
Collaborator Author

@sergeyberezansky sergeyberezansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not workable. on CoreOS Controller does not start. Will continue tomorrow

Copy link
Collaborator Author

sergeyberezansky commented Jul 31, 2024

Merge activity

  • Jul 31, 6:51 AM EDT: @sergeyberezansky started a stack merge that includes this pull request via Graphite.
  • Jul 31, 6:58 AM EDT: Graphite rebased this pull request as part of a merge.
  • Jul 31, 7:00 AM EDT: Graphite rebased this pull request as part of a merge.
  • Jul 31, 7:01 AM EDT: @sergeyberezansky merged this pull request with Graphite.

@sergeyberezansky sergeyberezansky changed the base branch from sergey/ipv6-support to dev July 31, 2024 10:56
@sergeyberezansky sergeyberezansky merged commit cbf6402 into dev Jul 31, 2024
4 checks passed
@sergeyberezansky sergeyberezansky deleted the sergey/allow-host-network branch July 31, 2024 11:53
@sergeyberezansky sergeyberezansky added enhancement New feature or request feature and removed enhancement New feature or request labels Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant