Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(CSI-213): add NFS sanity #340

Merged
merged 1 commit into from
Sep 27, 2024
Merged

ci(CSI-213): add NFS sanity #340

merged 1 commit into from
Sep 27, 2024

Conversation

sergeyberezansky
Copy link
Collaborator

@sergeyberezansky sergeyberezansky commented Sep 23, 2024

TL;DR

Added NFS support to CSI sanity tests and improved secret handling in GitHub Actions workflow.

What changed?

  • Added a new job directory_volume_and_snapshots_nfs to the GitHub Actions workflow
  • Created a new Docker Compose file docker-compose-nfs-snapshotcaps.yaml for NFS-specific tests
  • Updated the main Docker Compose file to include NFS-enabled plugin services
  • Added a new function directory_volume_and_snapshots_nfs() to the sanity test script

How to test?

  1. Run the updated GitHub Actions workflow
  2. Verify that the new directory_volume_and_snapshots_nfs job completes successfully
  3. Check the logs for the NFS-specific tests to ensure they're running as expected
  4. Confirm that the secret handling steps are working correctly by examining the workflow logs

Why make this change?

This change introduces NFS support to the CSI sanity tests, allowing for more comprehensive testing of the CSI driver's functionality.

Copy link

graphite-app bot commented Sep 23, 2024

Graphite Automations

"Request reviewers once CI passes" took an action on this PR • (09/23/24)

1 reviewer was added to this PR based on Sergey Berezansky's automation.

@sergeyberezansky sergeyberezansky force-pushed the sergey/add-nfs-sanity branch 2 times, most recently from f01dc33 to 16ce7ed Compare September 23, 2024 09:56
@sergeyberezansky sergeyberezansky changed the base branch from dev to sergey/fix-empty-ig-fails-lookup September 23, 2024 09:56
@sergeyberezansky sergeyberezansky force-pushed the sergey/add-nfs-sanity branch 2 times, most recently from 2be5731 to 2773b0d Compare September 23, 2024 10:10
@sergeyberezansky sergeyberezansky force-pushed the sergey/add-nfs-sanity branch 2 times, most recently from 1461745 to b8ce6f3 Compare September 24, 2024 14:28
@sergeyberezansky sergeyberezansky force-pushed the sergey/add-nfs-sanity branch 2 times, most recently from 41ecb2e to 265d9ab Compare September 24, 2024 14:56
@sergeyberezansky sergeyberezansky force-pushed the sergey/add-nfs-sanity branch 3 times, most recently from 9ee804e to 09188ba Compare September 24, 2024 19:44
@sergeyberezansky sergeyberezansky changed the base branch from sergey/fix-empty-ig-fails-lookup to sergey/override-nfs-target-ips September 24, 2024 19:44
@sergeyberezansky sergeyberezansky force-pushed the sergey/add-nfs-sanity branch 5 times, most recently from 1dba1b5 to e2a4396 Compare September 25, 2024 14:13
@sergeyberezansky sergeyberezansky force-pushed the sergey/add-nfs-sanity branch 6 times, most recently from 5d14963 to d7d36d6 Compare September 26, 2024 15:24
@sergeyberezansky sergeyberezansky force-pushed the sergey/add-nfs-sanity branch 2 times, most recently from fcc9275 to 8fbcee7 Compare September 27, 2024 10:05
@sergeyberezansky sergeyberezansky changed the base branch from sergey/override-nfs-target-ips to sergey/delete-nfs-perms-on-fs-delete September 27, 2024 10:05
@sergeyberezansky sergeyberezansky added the ci Changes to CI/CD and release workflows label Sep 27, 2024 — with Graphite App
@sergeyberezansky sergeyberezansky force-pushed the sergey/delete-nfs-perms-on-fs-delete branch from 62384c3 to c0ad603 Compare September 27, 2024 10:30
@sergeyberezansky sergeyberezansky changed the base branch from sergey/delete-nfs-perms-on-fs-delete to sergey/refcount-logic-fix-nfs September 27, 2024 10:31
Copy link
Collaborator Author

sergeyberezansky commented Sep 27, 2024

Merge activity

  • Sep 27, 8:57 AM EDT: @sergeyberezansky started a stack merge that includes this pull request via Graphite.
  • Sep 27, 9:25 AM EDT: Graphite rebased this pull request as part of a merge.
  • Sep 27, 9:27 AM EDT: Graphite rebased this pull request as part of a merge.
  • Sep 27, 9:47 AM EDT: @sergeyberezansky merged this pull request with Graphite.

@sergeyberezansky sergeyberezansky changed the base branch from sergey/refcount-logic-fix-nfs to graphite-base/340 September 27, 2024 13:15
@sergeyberezansky sergeyberezansky changed the base branch from graphite-base/340 to dev September 27, 2024 13:23
@sergeyberezansky sergeyberezansky merged commit bdb50b7 into dev Sep 27, 2024
12 checks passed
@sergeyberezansky sergeyberezansky deleted the sergey/add-nfs-sanity branch September 29, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Changes to CI/CD and release workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant