fix(CSI-270): filesystem-backed volumes cannot be deleted due to stale NFS permissions

[sergeyberezansky]

TL;DR

Enhanced NFS support, improved error handling, and added filesystem deletion safeguards.

What changed?

• Added EnsureNoNfsPermissionsForFilesystem function to remove NFS permissions before filesystem deletion.
• Improved error handling and logging in various functions.
• Updated NodeUnpublishVolume to remove the target path if it exists but is not a Weka mount.
• Implemented NodeStageVolume and NodeUnstageVolume as unimplemented features.
• Enhanced volume deletion process to handle NFS permissions.
• Updated documentation links and fixed minor typos.

How to test?

1. Test NFS-related operations, especially filesystem deletion with NFS permissions.
2. Verify error handling in various scenarios, particularly during volume operations.
3. Check the behavior of NodeUnpublishVolume when the target path exists but is not a Weka mount.
4. Ensure NodeStageVolume and NodeUnstageVolume return unimplemented status.
5. Test volume deletion process, particularly with NFS transport.

Why make this change?

These changes improve the robustness of the CSI driver, particularly when using NFS transport. They address potential issues with filesystem deletion when NFS permissions are present and enhance error handling and logging for better diagnostics. The updates also align the driver with expected CSI behavior for certain operations.

[sergeyberezansky]

• ci(CSI-213): add NFS sanity #340
• fix(CSI-269): nfsmount mountPoint may be incorrect in certain cases #345
• fix(CSI-270): filesystem-backed volumes cannot be deleted due to stale NFS permissions #344 👈
• feat(CSI-268): support NFS target IPs override via API secret #343
• fix(CSI-260): lookup of NFS interface group fails when empty name provided #341
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sergeyberezansky and the rest of your teammates on Graphite

[graphite-app]

Graphite Automations

"Request reviewers once CI passes" took an action on this PR • (09/26/24)

1 reviewer was added to this PR based on Sergey Berezansky's automation.

[sergeyberezansky]

Merge activity

• Sep 27, 8:57 AM EDT: @sergeyberezansky started a stack merge that includes this pull request via Graphite.
• Sep 27, 9:07 AM EDT: Graphite rebased this pull request as part of a merge.
• Sep 27, 9:09 AM EDT: Graphite rebased this pull request as part of a merge.
• Sep 27, 9:14 AM EDT: @sergeyberezansky merged this pull request with Graphite.