-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'NoneType' object has no attribute '__getitem__'
after rip with current master (a3e9260)
#196
Comments
Are there any data tracks? |
No. |
I have the same problem and my CD has a
|
So I tried again but I enabled debug logs, and with another album I had problems with, Florence + the Machine MTV Unplugged, it showed that it found 5 AccuRip results in the cache. Cleaning the cache solved the problem for both albums. |
That's fascinating, does clearing the cache solve Freso's problem too? (Backup cache contents instead of deleting so we can test further if it does, please.) |
Any news about this one? |
In the archive fork I purposely broke the cache code since it caused a lot of issues and headaches, to no real gain. |
Whipper's caching implementation causes a few issues (#196, #230, [#321 (comment)](#321 (comment))) and complicates the code: it's better to drop this feature. The rip resume feature doesn't work anymore: if possible it will be restored in the future. * Remove caching item from TODO * Delete unneeded files related to caching * Update 'common/directory.py' & 'test/test_common_directory.py' (caching removal) * Update 'common/accurip.py' & 'test/test_common_accurip.py' (caching removal) * Update 'common/program.py' (caching removal) * Update 'command/cd.py' (caching removal) This fixes #335, fixes #196 and fixes #230. Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
If I rip a disc (using
whipper cd --device='/dev/cdrom' rip --cdr --prompt --working-directory='/tmp/rip-disc.h2w' --output-directory='/home/freso/tmp/'
), I end getting this output after an otherwise successful rip:The text was updated successfully, but these errors were encountered: