Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AttributeError: 'Namespace' object has no attribute 'offset' #230

Closed
spvkgn opened this issue Feb 9, 2018 · 5 comments · Fixed by #336
Closed

AttributeError: 'Namespace' object has no attribute 'offset' #230

spvkgn opened this issue Feb 9, 2018 · 5 comments · Fixed by #336
Assignees
Labels
Accepted Accepted issue on our roadmap Bug Generic bug: can be used together with more specific labels Needed: discussion More discussion needed before anything can be done (or still no agreement has been reached) Needed: patch A pull request is required Needed: replication Bug replication is required Priority: medium Medium priority Regression Bug that breaks functionality known to work in previous releases
Milestone

Comments

@spvkgn
Copy link

spvkgn commented Feb 9, 2018

$ whipper cd info
Checking device /dev/sr0
CDDB disc id: 630e1d08
MusicBrainz disc id ibP6iFiB14iye.JALRZ9kCdLmD8-
MusicBrainz lookup URL https://musicbrainz.org/cdtoc/attach?toc=1+8+271159+150+46261+79254+109237+125375+145820+202649+242631&tracks=8&id=ibP6iFiB14iye.JALRZ9kCdLmD8-
Disc duration: 01:00:13.453, 8 audio tracks

Matching releases:

Artist  : The Pax Cecilia
Title   : Blessed Are the Bonds
Duration: 01:00:13.451
URL     : https://musicbrainz.org/release/428a9519-b114-4cc1-8080-9fb71997ad11
Release : 428a9519-b114-4cc1-8080-9fb71997ad11
Type    : Album

Traceback (most recent call last):
  File "/usr/bin/whipper", line 11, in <module>
    load_entry_point('whipper==0.6.0', 'console_scripts', 'whipper')()
  File "/usr/lib/python2.7/dist-packages/whipper/command/main.py", line 40, in main
    ret = cmd.do()
  File "/usr/lib/python2.7/dist-packages/whipper/command/basecommand.py", line 124, in do
    return self.cmd.do()
  File "/usr/lib/python2.7/dist-packages/whipper/command/basecommand.py", line 124, in do
    return self.cmd.do()
  File "/usr/lib/python2.7/dist-packages/whipper/command/cd.py", line 150, in do
    self.device, self.options.offset)
AttributeError: 'Namespace' object has no attribute 'offset'

whipper.log.gz

@Matt07211
Copy link

Reproduced on Solus, with whipper 0.6.0 and Python 2.7.14

$ WHIPPER_DEBUG=DEBUG WHIPPER_LOGFILE=whipper.log whipper cd info
Checking device /dev/sr0
CDDB disc id: 2a0ff914
MusicBrainz disc id NEZ.yGBoGJCYkr1uZ.r.GUK4P4E-
MusicBrainz lookup URL https://musicbrainz.org/cdtoc/attach?toc=1+20+306886+150+20851+41245+55417+65922+80277+91841+104052+116410+126941+136619+147824+160011+173949+185412+201484+251471+263470+275677+288839&tracks=20&id=NEZ.yGBoGJCYkr1uZ.r.GUK4P4E-
Disc duration: 01:08:09.813, 20 audio tracks

Matching releases:

Artist  : Creedence Clearwater Revival
Title   : Chronicle: The 20 Greatest Hits
Duration: 01:08:10.585
URL     : https://musicbrainz.org/release/72d361db-4ee2-484f-812c-0c60830336f6
Release : 72d361db-4ee2-484f-812c-0c60830336f6
Type    : Compilation
Barcode : 025218000222
Cat no  : 0025218000222

Artist  : Creedence Clearwater Revival
Title   : Chronicle
Duration: 01:08:10.585
URL     : https://musicbrainz.org/release/cc09c4a7-2f17-3c5d-abdd-cea3fe362045
Release : cc09c4a7-2f17-3c5d-abdd-cea3fe362045
Type    : Compilation
Barcode : 025218000222
Cat no  : FCD CCR2-2

Artist  : Creedence Clearwater Revival
Title   : Chronicle
Duration: 01:08:09.918
URL     : https://musicbrainz.org/release/f9a8e98f-b58f-4039-b2a2-18cd835a65eb
Release : f9a8e98f-b58f-4039-b2a2-18cd835a65eb
Type    : Compilation
Barcode : 025218000222
Cat no  : FCD-623-CCR2

Traceback (most recent call last):
  File "/usr/bin/whipper", line 11, in <module>
    load_entry_point('whipper==0.6.0', 'console_scripts', 'whipper')()
  File "/usr/lib/python2.7/site-packages/whipper-0.6.0-py2.7.egg/whipper/command/main.py", line 40, in main
    ret = cmd.do()
  File "/usr/lib/python2.7/site-packages/whipper-0.6.0-py2.7.egg/whipper/command/basecommand.py", line 124, in do
    return self.cmd.do()
  File "/usr/lib/python2.7/site-packages/whipper-0.6.0-py2.7.egg/whipper/command/basecommand.py", line 124, in do
    return self.cmd.do()
  File "/usr/lib/python2.7/site-packages/whipper-0.6.0-py2.7.egg/whipper/command/cd.py", line 150, in do
    self.device, self.options.offset)
AttributeError: 'Namespace' object has no attribute 'offset'

whipper.log

@MerlijnWajer MerlijnWajer self-assigned this Feb 9, 2018
calumchisholm added a commit to calumchisholm/whipper that referenced this issue Feb 21, 2018
@JoeLametta JoeLametta added the Bug Generic bug: can be used together with more specific labels label Feb 23, 2018
@JoeLametta
Copy link
Collaborator

JoeLametta commented Apr 6, 2018

Interesting comment by @RecursiveForest (link):

A brief inquiry yields that offset is not otherwised used by info except by program.getTable(), which caches the offset along with the disc "Table" (an internal data structure roughly resembling the table of contents). If the offset stored in the cache is used by anything remains to be verified.

Interestingly, this bug harkens back to morituri days, where thomasvs left a note "# Hackish fix for a broken commit", where he also set the offset to 0 by default for ... cd info and ... cd rip after introducing the ... cd info command.

Shall we attempt to fix this for milestone 1.0?

@thwaller
Copy link

Same issue here. Ubuntu 18.04, Whipper 0.7.0
Cannot get 'cd rip' to work either, found this in process of looking for errors to lead me to the issue.

Traceback (most recent call last): File "/usr/bin/whipper", line 11, in <module> load_entry_point('whipper==0.7.0', 'console_scripts', 'whipper')() File "/usr/lib/python2.7/dist-packages/whipper/command/main.py", line 36, in main ret = cmd.do() File "/usr/lib/python2.7/dist-packages/whipper/command/basecommand.py", line 139, in do return self.cmd.do() File "/usr/lib/python2.7/dist-packages/whipper/command/basecommand.py", line 139, in do return self.cmd.do() File "/usr/lib/python2.7/dist-packages/whipper/command/cd.py", line 144, in do self.device, self.options.offset) AttributeError: 'Namespace' object has no attribute 'offset'

@NoSuck
Copy link

NoSuck commented Jul 29, 2018

I can reproduce the issue running 0.7.0 on the number-one distro for script kiddies. I explicitly passed the drive offset in order to work around the issue mentioned by @thwaller but ran into another error:

whipper -e never cd rip --offset 667
creating output directory ········································
found Hidden Track One Audio from frame 0 to 149
Ripping track 0 of 13: ······················································
CRCs match for track 0
Peak level: 0
Rip quality: 100.00%
HTOA discarded, contains digital silence
Ripping track 1 of 13: ···················································
WARNING:whipper.program.cdparanoia:file size 0 did not match expected size 30000000
WARNING:whipper.program.cdparanoia:non-integral amount of frames difference
Ripping track 1 of 13 (try 2): ···················································
WARNING:whipper.program.cdparanoia:file size 0 did not match expected size 30000000
WARNING:whipper.program.cdparanoia:non-integral amount of frames difference
Ripping track 1 of 13 (try 3): ···················································
WARNING:whipper.program.cdparanoia:file size 0 did not match expected size 30000000
WARNING:whipper.program.cdparanoia:non-integral amount of frames difference
Ripping track 1 of 13 (try 4): ···················································
WARNING:whipper.program.cdparanoia:file size 0 did not match expected size 30000000
WARNING:whipper.program.cdparanoia:non-integral amount of frames difference
Ripping track 1 of 13 (try 5): ···················································
WARNING:whipper.program.cdparanoia:file size 0 did not match expected size 30000000
WARNING:whipper.program.cdparanoia:non-integral amount of frames difference
CRITICAL:whipper.command.cd:Giving up on track 1 after 5 times
track can't be ripped. Rip attempts number is equal to 'MAX_TRIES'

The album is obscure enough to be considered identifying information and has thus been redacted. If a developer requires a full error log, please let me know, and I will provide it privately.

The cd-paranoia error is as follows. The offset of 667 was obtained by EAC. I will dig up an album that is in the AccurateRip database to see what whipper thinks.

cd-paranoia --stderr-progress --sample-offset=667 --force-cdrom-device /dev/sr0 1[00:00:00.00]-1[00:00:51.06] /tmp/tmpmo3yoj.whipper.wav
Time/sector offset goes beyond end of specified track.

... aaaand I dug up an album just to see yet another error. My drive's offset as reported by 42 other users is 667, by the way. Sorry, but this is where I tap out. In any case, the main bug (certainly not ALL of them) could be with cd-paranoia. I will consider reporting there when I have more information (and energy).

whipper offset find                                                                                                                                                                                                           
Checking device /dev/sr0                                                                                                                                                                                                                     
Trying read offset 6 ...                                                                                                                                                                                            
WARNING:whipper.program.cdparanoia:CHECK:  /tmp/tmpbIAMbH.track01.offset6.whipper.wav                                                                                                                                                        
Trying read offset 667 ...                                                                                                                                                                                                                   
WARNING:whipper.program.cdparanoia:CHECK:  /tmp/tmpXT8DRJ.track01.offset667.whipper.wav                                                                                                                                                      
WARNING:whipper.program.cdparanoia:file size 0 did not match expected size 9012908                                                                                                                                                           
WARNING:whipper.program.cdparanoia:non-integral amount of frames difference                                                                                                                                                                  
WARNING: cannot rip with offset 667...                                                                                                                                                                                                       
Trying read offset 48 ...                                                                                                                                                                                               
WARNING:whipper.program.cdparanoia:CHECK:  /tmp/tmpMJRPt8.track01.offset48.whipper.wav                                                                                                                                                       
Trying read offset 102 ...                                                                                                                                                                                                                   
WARNING:whipper.program.cdparanoia:CHECK:  /tmp/tmpEyaBkC.track01.offset102.whipper.wav                                                                                                                                                      
Trying read offset 12 ...                                                                                                                                                                                                                    
WARNING:whipper.program.cdparanoia:CHECK:  /tmp/tmpC5urB6.track01.offset12.whipper.wav                                                                                                                                                       
Trying read offset 30 ...                                                                                                                                                                                                                    
WARNING:whipper.program.cdparanoia:CHECK:  /tmp/tmpdEQZC7.track01.offset30.whipper.wav                                                                                                                                                       
Trying read offset 103 ...                                                                                                                                                                                                                   
WARNING:whipper.program.cdparanoia:CHECK:  /tmp/tmpBYT0oT.track01.offset103.whipper.wav                                                                                                                                                      
Trying read offset 618 ...                                                                                                                                                                                                                   
WARNING:whipper.program.cdparanoia:CHECK:  /tmp/tmpgCs11Q.track01.offset618.whipper.wav                                                                                                                                                      
WARNING:whipper.program.cdparanoia:file size 0 did not match expected size 9012908                                                                                                                                                           
WARNING:whipper.program.cdparanoia:non-integral amount of frames difference                                                                                                                                                                  
WARNING: cannot rip with offset 618...                                                                                                                                                                                                       
Trying read offset 96 ...                                                                                                                                                                                               
WARNING:whipper.program.cdparanoia:CHECK:  /tmp/tmpLPR4If.track01.offset96.whipper.wav                                                                                                                                                       
Trying read offset 594 ...                                                                                                                                                                                                                   
WARNING:whipper.program.cdparanoia:CHECK:  /tmp/tmpAfkbgf.track01.offset594.whipper.wav                                                                                                                                                      
WARNING:whipper.program.cdparanoia:file size 0 did not match expected size 9012908                                                                                                                                                           
WARNING:whipper.program.cdparanoia:non-integral amount of frames difference                                                                                                                                                                  
WARNING: cannot rip with offset 594...                                                                                                                                                                                                       
Trying read offset 738 ...                                                                                                                                                                                                  
WARNING:whipper.program.cdparanoia:CHECK:  /tmp/tmp40sERs.track01.offset738.whipper.wav                                                                                                                                                      
WARNING:whipper.program.cdparanoia:file size 0 did not match expected size 9012908                                                                                                                                                           
WARNING:whipper.program.cdparanoia:non-integral amount of frames difference                                                                                                                                                                  
WARNING: cannot rip with offset 738...                                                                                                                                                                                                       
Trying read offset 98 ...                                                                                                                                                                                               
WARNING:whipper.program.cdparanoia:CHECK:  /tmp/tmp_2JcdG.track01.offset98.whipper.wav                                                                                                                                                       
Trying read offset -472 ...                                                                                                                                                                                                                  
WARNING:whipper.program.cdparanoia:CHECK:  /tmp/tmpvk3Y1F.track01.offset-472.whipper.wav                                                                                                                                                     
WARNING:whipper.program.cdparanoia:file size 0 did not match expected size 9012908                                                                                                                                                           
WARNING:whipper.program.cdparanoia:non-integral amount of frames difference                                                                                                                                                                  
WARNING: cannot rip with offset -472...                                                                                                                                                                                                      
Trying read offset 116 ...                                                                                                                                                                                                  
WARNING:whipper.program.cdparanoia:CHECK:  /tmp/tmp5g9vBT.track01.offset116.whipper.wav                                                                                                                                                      
Trying read offset 733 ...                                                                                                                                                                                                                   
WARNING:whipper.program.cdparanoia:CHECK:  /tmp/tmpReT1p9.track01.offset733.whipper.wav                                                                                                                                                      
WARNING:whipper.program.cdparanoia:file size 0 did not match expected size 9012908                                                                                                                                                           
WARNING:whipper.program.cdparanoia:non-integral amount of frames difference                                                                                                                                                                  
WARNING: cannot rip with offset 733...                                                                                                                                                                                                       
Trying read offset 696 ...                                                                                                                                                                                                  
WARNING:whipper.program.cdparanoia:CHECK:  /tmp/tmpCYhkqF.track01.offset696.whipper.wav                                                                                                                                                      
WARNING:whipper.program.cdparanoia:file size 0 did not match expected size 9012908                                                                                                                                                           
WARNING:whipper.program.cdparanoia:non-integral amount of frames difference                                                                                                                                                                  
WARNING: cannot rip with offset 696...                                                                                                                                                                                                       
Trying read offset 120 ...                                                                                                                                                                                                  
WARNING:whipper.program.cdparanoia:CHECK:  /tmp/tmp8jYGLw.track01.offset120.whipper.wav                                                                                                                                                      
Trying read offset 691 ...                                                                                                                                                                                                                   
WARNING:whipper.program.cdparanoia:CHECK:  /tmp/tmpEBCZUK.track01.offset691.whipper.wav                                                                                                                                                      
WARNING:whipper.program.cdparanoia:file size 0 did not match expected size 9012908                                                                                                                                                           
WARNING:whipper.program.cdparanoia:non-integral amount of frames difference                                                                                                                                                                  
WARNING: cannot rip with offset 691...                                                                                                                                                                                                       
Trying read offset 685 ...                                                                                                                                                                                                  
WARNING:whipper.program.cdparanoia:CHECK:  /tmp/tmpRZd4Kh.track01.offset685.whipper.wav                                                                                                                                                      
WARNING:whipper.program.cdparanoia:file size 0 did not match expected size 9012908                                                                                                                                                           
WARNING:whipper.program.cdparanoia:non-integral amount of frames difference                                                                                                                                                                  
WARNING: cannot rip with offset 685...                                                                                                                                                                                                       
Trying read offset 99 ...                                                                                                                                                                                               
WARNING:whipper.program.cdparanoia:CHECK:  /tmp/tmpf6j4Ey.track01.offset99.whipper.wav                                                                                                                                                       
Trying read offset 97 ...                                                                                                                                                                                                                    
WARNING:whipper.program.cdparanoia:CHECK:  /tmp/tmpmViKpT.track01.offset97.whipper.wav                                                                                                                                                       
Trying read offset 600 ...                                                                                                                                                                                                                   
WARNING:whipper.program.cdparanoia:CHECK:  /tmp/tmpNpQJuV.track01.offset600.whipper.wav                                                                                                                                                      
WARNING:whipper.program.cdparanoia:file size 0 did not match expected size 9012908                                                                                                                                                           
WARNING:whipper.program.cdparanoia:non-integral amount of frames difference                                                                                                                                                                  
WARNING: cannot rip with offset 600...                                                                                                                                                                                                       
Trying read offset 676 ...                                                                                                                                                                                                  
WARNING:whipper.program.cdparanoia:CHECK:  /tmp/tmp8Z6Me3.track01.offset676.whipper.wav                                                                                                                                                      
WARNING:whipper.program.cdparanoia:file size 0 did not match expected size 9012908                                                                                                                                                           
WARNING:whipper.program.cdparanoia:non-integral amount of frames difference                                                                                                                                                                  
WARNING: cannot rip with offset 676...                                                                                                                                                                                                       
Trying read offset 690 ...                                                                                                                                                                                                  
WARNING:whipper.program.cdparanoia:CHECK:  /tmp/tmpp1BRNx.track01.offset690.whipper.wav                                                                                                                                                      
WARNING:whipper.program.cdparanoia:file size 0 did not match expected size 9012908                                                                                                                                                           
WARNING:whipper.program.cdparanoia:non-integral amount of frames difference                                                                                                                                                                  
WARNING: cannot rip with offset 690...                                                                                                                                                                                                       
Trying read offset 1292 ...                                                                                                                                                                                                     
WARNING:whipper.program.cdparanoia:CHECK:  /tmp/tmpGmhGza.track01.offset1292.whipper.wav                                                                                                                                                     
WARNING:whipper.program.cdparanoia:file size 0 did not match expected size 9012908                                                                                                                                                           
WARNING:whipper.program.cdparanoia:non-integral amount of frames difference                                                                                                                                                                  
WARNING: cannot rip with offset 1292...                                                                                                                                                                                                      
Trying read offset 702 ...                                                                                                                                                                                                  
WARNING:whipper.program.cdparanoia:CHECK:  /tmp/tmpYQmU6M.track01.offset702.whipper.wav                                                                                                                                                      
WARNING:whipper.program.cdparanoia:file size 0 did not match expected size 9012908                                                                                                                                                           
WARNING:whipper.program.cdparanoia:non-integral amount of frames difference                                                                                                                                                                  
WARNING: cannot rip with offset 702...                                                                                                                                                                                                       
Trying read offset 686 ...                                                                                                                                                                                                  
WARNING:whipper.program.cdparanoia:CHECK:  /tmp/tmpbR7fFc.track01.offset686.whipper.wav                                                                                                                                                      
WARNING:whipper.program.cdparanoia:file size 0 did not match expected size 9012908                                                                                                                                                           
WARNING:whipper.program.cdparanoia:non-integral amount of frames difference                                                                                                                                                                  
WARNING: cannot rip with offset 686...                                                                                                                                                                                                       
Trying read offset -24 ...                                                                                                                                                                                                  
WARNING:whipper.program.cdparanoia:CHECK:  /tmp/tmpE8FN48.track01.offset-24.whipper.wav                                                                                                                                                      
WARNING:whipper.program.cdparanoia:file size 0 did not match expected size 9012908                                                                                                                                                           
WARNING:whipper.program.cdparanoia:non-integral amount of frames difference                                                                                                                                                                  
WARNING: cannot rip with offset -24...                                                                                                                                                                                                       
Trying read offset 704 ...                                                                                                                                                                                                  
WARNING:whipper.program.cdparanoia:CHECK:  /tmp/tmpzlpnU5.track01.offset704.whipper.wav                                                                                                                                                      
WARNING:whipper.program.cdparanoia:file size 0 did not match expected size 9012908                                                                                                                                                           
WARNING:whipper.program.cdparanoia:non-integral amount of frames difference                                                                                                                                                                  
WARNING: cannot rip with offset 704...                                                                                                                                                                                                       
Trying read offset 697 ...                                                                                                                                                                                                  
WARNING:whipper.program.cdparanoia:CHECK:  /tmp/tmpbCg0or.track01.offset697.whipper.wav                                                                                                                                                      
WARNING:whipper.program.cdparanoia:file size 0 did not match expected size 9012908                                                                                                                                                           
WARNING:whipper.program.cdparanoia:non-integral amount of frames difference                                                                                                                                                                  
WARNING: cannot rip with offset 697...                                                                                                                                                                                                       
Trying read offset 572 ...                                                                                                                                                                                                  
WARNING:whipper.program.cdparanoia:CHECK:  /tmp/tmp5Avjx0.track01.offset572.whipper.wav                                                                                                                                                      
Trying read offset 1182 ...                                                                                                                                                                                                                  
WARNING:whipper.program.cdparanoia:CHECK:  /tmp/tmp3Nbn2V.track01.offset1182.whipper.wav                                                                                                                                                     
WARNING:whipper.program.cdparanoia:file size 0 did not match expected size 9012908                                                                                                                                                           
WARNING:whipper.program.cdparanoia:non-integral amount of frames difference                                                                                                                                                                  
WARNING: cannot rip with offset 1182...                                                                                                                                                                                                      
Trying read offset 688 ...                                                                                                                                                                                                  
WARNING:whipper.program.cdparanoia:CHECK:  /tmp/tmp363mZb.track01.offset688.whipper.wav                                                                                                                                                      
WARNING:whipper.program.cdparanoia:file size 0 did not match expected size 9012908                                                                                                                                                           
WARNING:whipper.program.cdparanoia:non-integral amount of frames difference                                                                                                                                                                  
WARNING: cannot rip with offset 688...                                                                                                                                                                                                       
Trying read offset 91 ...                                                                                                                                                                                               
WARNING:whipper.program.cdparanoia:CHECK:  /tmp/tmp3MAqfz.track01.offset91.whipper.wav                                                                                                                                                       
Trying read offset -491 ...                                                                                                                                                                                                                  
WARNING:whipper.program.cdparanoia:CHECK:  /tmp/tmprn30qn.track01.offset-491.whipper.wav                                                                                                                                                     
WARNING:whipper.program.cdparanoia:file size 0 did not match expected size 9012908                                                                                                                                                           
WARNING:whipper.program.cdparanoia:non-integral amount of frames difference                                                                                                                                                                  
WARNING: cannot rip with offset -491...                                                                                                                                                                                                      
Trying read offset 145 ...                                                                                                                                                                                                  
WARNING:whipper.program.cdparanoia:CHECK:  /tmp/tmpZkt6Fb.track01.offset145.whipper.wav                                                                                                                                                      
Trying read offset 689 ...                                                                                                                                                                                                                   
WARNING:whipper.program.cdparanoia:CHECK:  /tmp/tmprBz9LK.track01.offset689.whipper.wav                                                                                                                                                      
WARNING:whipper.program.cdparanoia:file size 0 did not match expected size 9012908                                                                                                                                                           
WARNING:whipper.program.cdparanoia:non-integral amount of frames difference
WARNING: cannot rip with offset 689...     
Trying read offset 564 ...
WARNING:whipper.program.cdparanoia:CHECK:  /tmp/tmpeEM9SU.track01.offset564.whipper.wav
Trying read offset 708 ...                 
WARNING:whipper.program.cdparanoia:CHECK:  /tmp/tmph76Wul.track01.offset708.whipper.wav
WARNING:whipper.program.cdparanoia:file size 0 did not match expected size 9012908
WARNING:whipper.program.cdparanoia:non-integral amount of frames difference
WARNING: cannot rip with offset 708...     
Trying read offset 86 ...
WARNING:whipper.program.cdparanoia:CHECK:  /tmp/tmpCcS2PF.track01.offset86.whipper.wav
Trying read offset 355 ...                 
WARNING:whipper.program.cdparanoia:CHECK:  /tmp/tmphDko5y.track01.offset355.whipper.wav
Trying read offset 79 ...                  
WARNING:whipper.program.cdparanoia:CHECK:  /tmp/tmpwV46aL.track01.offset79.whipper.wav
Trying read offset -496 ...                
WARNING:whipper.program.cdparanoia:CHECK:  /tmp/tmpL_Lv0j.track01.offset-496.whipper.wav
WARNING:whipper.program.cdparanoia:file size 0 did not match expected size 9012908
WARNING:whipper.program.cdparanoia:non-integral amount of frames difference
WARNING: cannot rip with offset -496...    
Trying read offset 679 ...
WARNING:whipper.program.cdparanoia:CHECK:  /tmp/tmpEQhzEB.track01.offset679.whipper.wav
WARNING:whipper.program.cdparanoia:file size 0 did not match expected size 9012908
WARNING:whipper.program.cdparanoia:non-integral amount of frames difference
WARNING: cannot rip with offset 679...     
Trying read offset -1164 ...
WARNING:whipper.program.cdparanoia:CHECK:  /tmp/tmpjMmAsz.track01.offset-1164.whipper.wav
WARNING:whipper.program.cdparanoia:file size 0 did not match expected size 9012908
WARNING:whipper.program.cdparanoia:non-integral amount of frames difference
WARNING: cannot rip with offset -1164...    
Trying read offset 0 ...
WARNING:whipper.program.cdparanoia:CHECK:  /tmp/tmpy8F_Hf.track01.offset0.whipper.wav
Trying read offset 1160 ...                 
WARNING:whipper.program.cdparanoia:CHECK:  /tmp/tmpS_8T0L.track01.offset1160.whipper.wav
WARNING:whipper.program.cdparanoia:file size 0 did not match expected size 9012908
WARNING:whipper.program.cdparanoia:non-integral amount of frames difference
WARNING: cannot rip with offset 1160...     
Trying read offset -436 ...
WARNING:whipper.program.cdparanoia:CHECK:  /tmp/tmpnOV01y.track01.offset-436.whipper.wav
WARNING:whipper.program.cdparanoia:file size 0 did not match expected size 9012908
WARNING:whipper.program.cdparanoia:non-integral amount of frames difference
Traceback (most recent call last):          
  File "/usr/bin/whipper", line 11, in <module>
    load_entry_point('whipper==0.7.0', 'console_scripts', 'whipper')()
  File "/usr/lib/python2.7/site-packages/whipper/command/main.py", line 36, in main
    ret = cmd.do()
  File "/usr/lib/python2.7/site-packages/whipper/command/basecommand.py", line 139, in do
    return self.cmd.do()
  File "/usr/lib/python2.7/site-packages/whipper/command/basecommand.py", line 139, in do
    return self.cmd.do()
  File "/usr/lib/python2.7/site-packages/whipper/command/offset.py", line 122, in do
    archecksums = self._arcs(runner, table, 1, offset)
  File "/usr/lib/python2.7/site-packages/whipper/command/offset.py", line 196, in _arcs
    runner.run(t)
  File "/usr/lib/python2.7/site-packages/whipper/extern/task/task.py", line 493, in run
    task.exceptionMessage, task.exceptionTraceback))
MemoryError

As a final note, here was the command whipper issued that should have succeeded but failed, followed by a modified command that did succeed:

cd-paranoia --stderr-progress --sample-offset=667 --force-cdrom-device /dev/sr0 1[00:00:00.00]-1[00:00:51.06] /tmp/tmpf2R6V_.track01.offset667.whipper.wav
cd-paranoia --stderr-progress --sample-offset=667 --force-cdrom-device /dev/sr0 1[00:00:00.00]-1[00:00:51.05] /tmp/tmpf2R6V_.track01.offset667.whipper.wav

This should probably be considered its own issue (or issues) at this point. Please move/reference this post as necessary.

@JoeLametta
Copy link
Collaborator

JoeLametta commented Nov 3, 2018

@NoSuck

but ran into another error:

The discussion about this bug is in #234.

@JoeLametta JoeLametta added Accepted Accepted issue on our roadmap Priority: medium Medium priority Needed: replication Bug replication is required Needed: patch A pull request is required Needed: discussion More discussion needed before anything can be done (or still no agreement has been reached) Regression Bug that breaks functionality known to work in previous releases labels Nov 13, 2018
@JoeLametta JoeLametta added this to the 2.0 milestone Nov 13, 2018
This was referenced Nov 19, 2018
JoeLametta added a commit that referenced this issue Sep 17, 2020
Whipper's caching implementation causes a few issues (#196, #230, [#321 (comment)](#321 (comment))) and complicates the code: it's better to drop this feature.

The rip resume feature doesn't work anymore: if possible it will be restored in the future.

* Remove caching item from TODO
* Delete unneeded files related to caching
* Update 'common/directory.py' & 'test/test_common_directory.py' (caching removal)
* Update 'common/accurip.py' & 'test/test_common_accurip.py' (caching removal)
* Update 'common/program.py' (caching removal)
* Update 'command/cd.py' (caching removal)

This fixes #335, fixes #196 and fixes #230.

Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Bug Generic bug: can be used together with more specific labels Needed: discussion More discussion needed before anything can be done (or still no agreement has been reached) Needed: patch A pull request is required Needed: replication Bug replication is required Priority: medium Medium priority Regression Bug that breaks functionality known to work in previous releases
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants