Skip to content

Commit

Permalink
[BREAKING CHANGE] Replace eslint-plugin-es with eslint-plugin-es-x
Browse files Browse the repository at this point in the history
The former has not been maintained in 2 years. Unfortunately this
means renmaing all the rules to add the "-x" suffix, although there
probably aren't many users overriding these rules downstream.
  • Loading branch information
edg2s committed May 19, 2022
1 parent ad700b7 commit c996e3f
Show file tree
Hide file tree
Showing 12 changed files with 146 additions and 146 deletions.
8 changes: 4 additions & 4 deletions language/not-es2016.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@
/* eslint-disable quote-props, quotes */
const merge = require( './merge' );
const rules = {
"plugins": [ "es" ],
"plugins": [ "es-x" ],
"rules": {
"es/no-object-entries": "error",
"es/no-object-getownpropertydescriptors": "error",
"es/no-object-values": "error",
"es-x/no-object-entries": "error",
"es-x/no-object-getownpropertydescriptors": "error",
"es-x/no-object-values": "error",
"no-restricted-properties": [
"error",
{
Expand Down
2 changes: 1 addition & 1 deletion language/not-es2018.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
const merge = require( './merge' );
const rules = {
"rules": {
"es/no-object-fromentries": "error",
"es-x/no-object-fromentries": "error",
"no-restricted-properties": [
"error",
{
Expand Down
8 changes: 4 additions & 4 deletions language/not-es2019.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@
/* eslint-disable quote-props, quotes */
const merge = require( './merge' );
const rules = {
"plugins": [ "es" ],
"plugins": [ "es-x" ],
"rules": {
"es/no-bigint": "error",
"es/no-global-this": "error",
"es/no-promise-all-settled": "error",
"es-x/no-bigint": "error",
"es-x/no-global-this": "error",
"es-x/no-promise-all-settled": "error",
"no-restricted-properties": [
"error",
{
Expand Down
2 changes: 1 addition & 1 deletion language/not-es2020.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
const merge = require( './merge' );
const rules = {
"rules": {
"es/no-promise-any": "error",
"es-x/no-promise-any": "error",
"no-restricted-properties": [
"error",
{
Expand Down
68 changes: 34 additions & 34 deletions language/not-es5.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,41 +3,41 @@
/* eslint-disable quote-props, quotes */
const merge = require( './merge' );
const rules = {
"plugins": [ "es" ],
"plugins": [ "es-x" ],
"rules": {
"es/no-array-from": "error",
"es/no-array-of": "error",
"es/no-math-acosh": "error",
"es/no-math-asinh": "error",
"es/no-math-atanh": "error",
"es/no-math-cbrt": "error",
"es/no-math-clz32": "error",
"es/no-math-cosh": "error",
"es/no-math-expm1": "error",
"es/no-math-fround": "error",
"es/no-math-hypot": "error",
"es/no-math-imul": "error",
"es/no-math-log10": "error",
"es/no-math-log1p": "error",
"es/no-math-log2": "error",
"es/no-math-sign": "error",
"es/no-math-sinh": "error",
"es/no-math-tanh": "error",
"es/no-math-trunc": "error",
"es/no-number-epsilon": "error",
"es/no-number-isfinite": "error",
"es/no-number-isinteger": "error",
"es/no-number-isnan": "error",
"es/no-number-issafeinteger": "error",
"es/no-number-maxsafeinteger": "error",
"es/no-number-minsafeinteger": "error",
"es/no-number-parsefloat": "error",
"es/no-number-parseint": "error",
"es/no-object-assign": "error",
"es/no-object-getownpropertysymbols": "error",
"es/no-object-is": "error",
"es/no-string-fromcodepoint": "error",
"es/no-string-raw": "error",
"es-x/no-array-from": "error",
"es-x/no-array-of": "error",
"es-x/no-math-acosh": "error",
"es-x/no-math-asinh": "error",
"es-x/no-math-atanh": "error",
"es-x/no-math-cbrt": "error",
"es-x/no-math-clz32": "error",
"es-x/no-math-cosh": "error",
"es-x/no-math-expm1": "error",
"es-x/no-math-fround": "error",
"es-x/no-math-hypot": "error",
"es-x/no-math-imul": "error",
"es-x/no-math-log10": "error",
"es-x/no-math-log1p": "error",
"es-x/no-math-log2": "error",
"es-x/no-math-sign": "error",
"es-x/no-math-sinh": "error",
"es-x/no-math-tanh": "error",
"es-x/no-math-trunc": "error",
"es-x/no-number-epsilon": "error",
"es-x/no-number-isfinite": "error",
"es-x/no-number-isinteger": "error",
"es-x/no-number-isnan": "error",
"es-x/no-number-issafeinteger": "error",
"es-x/no-number-maxsafeinteger": "error",
"es-x/no-number-minsafeinteger": "error",
"es-x/no-number-parsefloat": "error",
"es-x/no-number-parseint": "error",
"es-x/no-object-assign": "error",
"es-x/no-object-getownpropertysymbols": "error",
"es-x/no-object-is": "error",
"es-x/no-string-fromcodepoint": "error",
"es-x/no-string-raw": "error",
"no-restricted-properties": [
"error",
{
Expand Down
24 changes: 12 additions & 12 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
"browserslist-config-wikimedia": "^0.4.0",
"eslint": "^8.14.0",
"eslint-plugin-compat": "^4.0.2",
"eslint-plugin-es": "^4.1.0",
"eslint-plugin-es-x": "^5.2.0",
"eslint-plugin-jsdoc": "^38.1.6",
"eslint-plugin-json-es": "^1.5.7",
"eslint-plugin-mediawiki": "^0.3.0",
Expand Down
82 changes: 41 additions & 41 deletions test/fixtures/client-es5/invalid.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,81 +13,81 @@
[].keys();
// eslint-disable-next-line no-restricted-syntax
[].entries();
// eslint-disable-next-line es/no-array-from
// eslint-disable-next-line es-x/no-array-from
Array.from();
// eslint-disable-next-line es/no-array-of
// eslint-disable-next-line es-x/no-array-of
Array.of();
// eslint-disable-next-line es/no-math-acosh
// eslint-disable-next-line es-x/no-math-acosh
Math.acosh();
// eslint-disable-next-line es/no-math-asinh
// eslint-disable-next-line es-x/no-math-asinh
Math.asinh();
// eslint-disable-next-line es/no-math-atanh
// eslint-disable-next-line es-x/no-math-atanh
Math.atanh();
// eslint-disable-next-line es/no-math-cbrt
// eslint-disable-next-line es-x/no-math-cbrt
Math.cbrt();
// eslint-disable-next-line es/no-math-clz32
// eslint-disable-next-line es-x/no-math-clz32
Math.clz32();
// eslint-disable-next-line es/no-math-cosh
// eslint-disable-next-line es-x/no-math-cosh
Math.cosh();
// eslint-disable-next-line es/no-math-expm1
// eslint-disable-next-line es-x/no-math-expm1
Math.expm1();
// eslint-disable-next-line es/no-math-fround
// eslint-disable-next-line es-x/no-math-fround
Math.fround();
// eslint-disable-next-line es/no-math-hypot
// eslint-disable-next-line es-x/no-math-hypot
Math.hypot();
// eslint-disable-next-line es/no-math-imul
// eslint-disable-next-line es-x/no-math-imul
Math.imul();
// eslint-disable-next-line es/no-math-log10
// eslint-disable-next-line es-x/no-math-log10
Math.log10();
// eslint-disable-next-line es/no-math-log1p
// eslint-disable-next-line es-x/no-math-log1p
Math.log1p();
// eslint-disable-next-line es/no-math-log2
// eslint-disable-next-line es-x/no-math-log2
Math.log2();
// eslint-disable-next-line es/no-math-sign
// eslint-disable-next-line es-x/no-math-sign
Math.sign();
// eslint-disable-next-line es/no-math-sinh
// eslint-disable-next-line es-x/no-math-sinh
Math.sinh();
// eslint-disable-next-line es/no-math-tanh
// eslint-disable-next-line es-x/no-math-tanh
Math.tanh();
// eslint-disable-next-line es/no-math-trunc
// eslint-disable-next-line es-x/no-math-trunc
Math.trunc();
// eslint-disable-next-line es/no-number-epsilon
// eslint-disable-next-line es-x/no-number-epsilon
Number.EPSILON.toString();
// eslint-disable-next-line es/no-number-isfinite
// eslint-disable-next-line es-x/no-number-isfinite
Number.isFinite();
// eslint-disable-next-line es/no-number-isinteger
// eslint-disable-next-line es-x/no-number-isinteger
Number.isInteger();
// eslint-disable-next-line es/no-number-isnan
// eslint-disable-next-line es-x/no-number-isnan
Number.isNaN();
// eslint-disable-next-line es/no-number-issafeinteger
// eslint-disable-next-line es-x/no-number-issafeinteger
Number.isSafeInteger();
// eslint-disable-next-line es/no-number-maxsafeinteger
// eslint-disable-next-line es-x/no-number-maxsafeinteger
Number.MAX_SAFE_INTEGER.toString();
// eslint-disable-next-line es/no-number-minsafeinteger
// eslint-disable-next-line es-x/no-number-minsafeinteger
Number.MIN_SAFE_INTEGER.toString();
// eslint-disable-next-line es/no-number-parsefloat
// eslint-disable-next-line es-x/no-number-parsefloat
Number.parseFloat();
// eslint-disable-next-line es/no-number-parseint
// eslint-disable-next-line es-x/no-number-parseint
Number.parseInt();
// eslint-disable-next-line es/no-object-assign
// eslint-disable-next-line es-x/no-object-assign
Object.assign();
// eslint-disable-next-line es/no-object-getownpropertysymbols
// eslint-disable-next-line es-x/no-object-getownpropertysymbols
Object.getOwnPropertySymbols();
// eslint-disable-next-line es/no-object-is
// eslint-disable-next-line es-x/no-object-is
Object.is();
// eslint-disable-next-line es/no-string-fromcodepoint
// eslint-disable-next-line es-x/no-string-fromcodepoint
String.fromCodePoint();
// eslint-disable-next-line es/no-string-raw
// eslint-disable-next-line es-x/no-string-raw
String.raw();

// not-es6
// eslint-disable-next-line no-restricted-syntax
[].includes();
// eslint-disable-next-line es/no-object-entries
// eslint-disable-next-line es-x/no-object-entries
Object.entries();
// eslint-disable-next-line es/no-object-getownpropertydescriptors
// eslint-disable-next-line es-x/no-object-getownpropertydescriptors
Object.getOwnPropertyDescriptors();
// eslint-disable-next-line es/no-object-values
// eslint-disable-next-line es-x/no-object-values
Object.values();

// not-es2016
Expand All @@ -99,14 +99,14 @@
// not-es2018
// eslint-disable-next-line no-restricted-properties
''.trimEnd();
// eslint-disable-next-line es/no-object-fromentries
// eslint-disable-next-line es-x/no-object-fromentries
Object.fromEntries();

// es2020 rules don't fail in ES5, tested in server/invalid.js instead
// <!-- eslint-disable-next-line es/no-bigint -->
// <!-- eslint-disable-next-line es/no-global-this -->
// <!-- eslint-disable-next-line es/no-promise-all-settled -->
// <!-- eslint-disable-next-line es/no-promise-any -->
// <!-- eslint-disable-next-line es-x/no-bigint -->
// <!-- eslint-disable-next-line es-x/no-global-this -->
// <!-- eslint-disable-next-line es-x/no-promise-all-settled -->
// <!-- eslint-disable-next-line es-x/no-promise-any -->

// not-es2021
// Nothing yet
Expand Down
16 changes: 8 additions & 8 deletions test/fixtures/client-es6/invalid.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@ class MyClass {}
// not-es6
// eslint-disable-next-line no-restricted-syntax
[].includes( c );
// eslint-disable-next-line es/no-object-entries
// eslint-disable-next-line es-x/no-object-entries
Object.entries();
// eslint-disable-next-line es/no-object-getownpropertydescriptors
// eslint-disable-next-line es-x/no-object-getownpropertydescriptors
Object.getOwnPropertyDescriptors();
// eslint-disable-next-line es/no-object-values
// eslint-disable-next-line es-x/no-object-values
Object.values();

// not-es2016
Expand All @@ -25,14 +25,14 @@ class MyClass {}
// not-es2018
// eslint-disable-next-line no-restricted-properties
''.trimEnd();
// eslint-disable-next-line es/no-object-fromentries
// eslint-disable-next-line es-x/no-object-fromentries
Object.fromEntries();

// es2020 rules don't fail in ES6, tested in server/invalid.js instead
// <!-- eslint-disable-next-line es/no-bigint -->
// <!-- eslint-disable-next-line es/no-global-this -->
// <!-- eslint-disable-next-line es/no-promise-all-settled -->
// <!-- eslint-disable-next-line es/no-promise-any -->
// <!-- eslint-disable-next-line es-x/no-bigint -->
// <!-- eslint-disable-next-line es-x/no-global-this -->
// <!-- eslint-disable-next-line es-x/no-promise-all-settled -->
// <!-- eslint-disable-next-line es-x/no-promise-any -->

// not-es2021
// Nothing yet
Expand Down
Loading

0 comments on commit c996e3f

Please sign in to comment.