Simplify language rules #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on mysticatea/eslint-plugin-es#54 |
|
Exciting. |
edg2s
force-pushed
the
languages
branch
2 times, most recently
from
588cff8
to
a6ac7ac
Compare
|
The upstream was merged but still hasn't been released. Time to fork? |
Looks like someone already did. Worth taking a look perhaps. They've done quite a bit more than just releasing already-merged patches, however, so there's a certain risk of divergence here. Having said that, they seem to be keeping compatibility and mention explicitly an intent to discontinue the fork when maintenance resumes. |
edg2s
force-pushed
the
languages
branch
2 times, most recently
from
fbcede9
to
d65803f
Compare
Now that eslint-plugin-es contains rules for prototype properties, we can do away with our not-es* rules and just rely on the plugin.
jdforrester
approved these changes
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that eslint-plugin-es-x contains rules for prototype properties,
we can do away with our not-es* rules and just rely on the plugin.