-
-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nv2a: Check for CPU-modifications to textures before reusing #1019
nv2a: Check for CPU-modifications to textures before reusing #1019
Conversation
It fixes SSX 3 and Commandos Strike Force intros |
Doesn't fix any of the stuttery/laggy cutscenes =( |
Thanks for testing! I wouldn't expect this to have an effect on laggy videos, that'll need separate investigation/profiling to track down. |
there a ton of games that have this issue do you what me to test them all? |
No, given the number you've already verified I'm confident that this fix should cover most cases. If we find any games that still have frozen videos after this PR we should file new issues as they're likely some other cause. |
looking there about 28 games |
Also Will this fixes the intel issue. The same thing happen on intel GPU for the game that didn't have the issue on other GPUs |
I would not expect it to have any effect on hw-specific problems. This is just another case where xemu optimizations happen to do the wrong thing and need to be bypassed. I expect this will have some negative effect on performance since it's doing more work on the CPU than before, but hopefully not too bad. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Cool, let's keep the discussions separate; you can add notes on that PR for games you find fixed or newly broken by that change. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Confirmed that this fixes #937 |
This made Arctic Thunder FMV Laggy |
What is the behavior on master without the PR? Does the video play normally or is it just a frozen frame? |
The video played normally, well aside from what I put on my report https://xemu.app/titles/4d570002/#Arctic-Thunder I just make it worse |
Fixes #457
Fixes #937
Test
HW Results