Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nv2a: Check for CPU-modifications to textures before reusing #1019

Conversation

abaire
Copy link
Contributor

@abaire abaire commented Jun 3, 2022

Fixes #457
Fixes #937

Test
HW Results

@Triticum0
Copy link

Triticum0 commented Jun 3, 2022

It fixes SSX 3 and Commandos Strike Force intros
also fixes Darkwatch in-game cutscenes displaying

@Triticum0
Copy link

Doesn't fix any of the stuttery/laggy cutscenes =(

@abaire
Copy link
Contributor Author

abaire commented Jun 3, 2022

Thanks for testing!

I wouldn't expect this to have an effect on laggy videos, that'll need separate investigation/profiling to track down.

@Triticum0
Copy link

there a ton of games that have this issue do you what me to test them all?

@abaire
Copy link
Contributor Author

abaire commented Jun 3, 2022

No, given the number you've already verified I'm confident that this fix should cover most cases.

If we find any games that still have frozen videos after this PR we should file new issues as they're likely some other cause.

@Triticum0
Copy link

looking there about 28 games

@Triticum0
Copy link

Triticum0 commented Jun 3, 2022

Also Will this fixes the intel issue. The same thing happen on intel GPU for the game that didn't have the issue on other GPUs

@abaire
Copy link
Contributor Author

abaire commented Jun 3, 2022

Also Will this fixes the intel issue

I would not expect it to have any effect on hw-specific problems. This is just another case where xemu optimizations happen to do the wrong thing and need to be bypassed. I expect this will have some negative effect on performance since it's doing more work on the CPU than before, but hopefully not too bad.

@Triticum0

This comment was marked as off-topic.

@abaire
Copy link
Contributor Author

abaire commented Jun 3, 2022

ok I will do some more testing and see if I fix any issues. Also #735 fixed some of the remaining shadow bugs

Cool, let's keep the discussions separate; you can add notes on that PR for games you find fixed or newly broken by that change.

@Triticum0

This comment was marked as off-topic.

@RageXbox
Copy link
Contributor

RageXbox commented Jun 3, 2022

Confirmed that this fixes #937

@abaire abaire marked this pull request as ready for review June 3, 2022 18:24
@mborgerson mborgerson merged commit 84fa8da into xemu-project:master Jun 3, 2022
@abaire abaire deleted the fix/457/check_for_texture_cpu_modifications branch June 3, 2022 20:49
@Triticum0
Copy link

Triticum0 commented Jun 4, 2022

This made Arctic Thunder FMV Laggy

@abaire
Copy link
Contributor Author

abaire commented Jun 4, 2022

This made Arctic Thunder FMV Laggy

What is the behavior on master without the PR? Does the video play normally or is it just a frozen frame?

@Triticum0
Copy link

Triticum0 commented Jun 5, 2022

The video played normally, well aside from what I put on my report https://xemu.app/titles/4d570002/#Arctic-Thunder I just make it worse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Splinter cell: Broken loading screen image Futurama: FMV videos are broken
4 participants