Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: switchs #300

Merged
merged 1 commit into from
Jul 4, 2022
Merged

fix: switchs #300

merged 1 commit into from
Jul 4, 2022

Conversation

dvpfran
Copy link
Contributor

@dvpfran dvpfran commented Jul 4, 2022

Fixes #282

Proposed Changes

  • Set the maxVotes to undefined instead of empty.

This pull request closes #282

@dvpfran dvpfran added bug Something isn't working frontend labels Jul 4, 2022
@dvpfran dvpfran self-assigned this Jul 4, 2022
@dvpfran dvpfran linked an issue Jul 4, 2022 that may be closed by this pull request
@dvpfran dvpfran requested a review from a team July 4, 2022 10:55
Copy link
Contributor

@tiagomichaelsousa tiagomichaelsousa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍

@dvpfran dvpfran merged commit 740b764 into main Jul 4, 2022
@dvpfran dvpfran deleted the fix-board-settings-switchs branch July 4, 2022 11:35
dsousa12 pushed a commit that referenced this pull request Jul 13, 2022
tutods added a commit that referenced this pull request Jul 17, 2022
* feat(backend): hide cards from others

* feat: frontend hide cards from others

* feat: frontend hide-cards-from-others icons

* feat: disabel the card icons

* feat: disable card icon dots

* feat: add new util replaceChar

* feat: pr sugestions

* fix: switchs (#300)

* [FEATURE]: Remove "Option to post cards anonymously" from Board Settings (#301)

* fix: remove post cards anonymously from board settings

* feat: remove post cards anonymously from pre existing board

* [FIX]: Disable Limit Votes (#307)

* fix: disable limit votes

* fix: check toggle btn if value is greater than 0

* fix: rebase

* [FIX]: Remove Votes options from Board Settings on Sub-boards (#312)

* fix: remove votes settings in sub boards

* fix: pr suggestion

* chore(deps): bump next-auth from 4.6.1 to 4.9.0 in /frontend (#314)

Bumps [next-auth](https://github.com/nextauthjs/next-auth) from 4.6.1 to 4.9.0.
- [Release notes](https://github.com/nextauthjs/next-auth/releases)
- [Changelog](https://github.com/nextauthjs/next-auth/blob/main/CHANGELOG.md)
- [Commits](https://github.com/nextauthjs/next-auth/compare/next-auth@v4.6.1...next-auth@v4.9.0)

---
updated-dependencies:
- dependency-name: next-auth
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* [FIX]: Missing upper case validation on register user (#317)

fix: missing upper case validation register user

* docs: add geomarb as a contributor for code, doc (#322)

* docs: update README.md

* docs: update .all-contributorsrc

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

* [FIX]: Extra votes left on card (#308)

* fix: extra votes left on card

* fix: checking votes values on the backend

* fix: extra votes left on card resolve conflit

* fix: remove unused console logs

* fix: add db votes count

* fix: add incremment votes count

* fix: checking for zero votes in the backend

* fix: checking for zero votes in frontend

* [FIX]: Edit cards from others (#320)

* fix: edit own cards only

* fix: updateCardText function

* fix: previous commit

* fix: edit own comments only

* fix: remove not used code

* fix: change update and delete service of comment

* [FIX]: totalUsedVotes type error (#325)

fix: totalusedvotes type error

* Fix build errors (#327)

* fix: totalusedvotes type error

* fix: build type error

* chore(deps): bump moment from 2.29.3 to 2.29.4 in /backend (#323)

Bumps [moment](https://github.com/moment/moment) from 2.29.3 to 2.29.4.
- [Release notes](https://github.com/moment/moment/releases)
- [Changelog](https://github.com/moment/moment/blob/develop/CHANGELOG.md)
- [Commits](moment/moment@2.29.3...2.29.4)

---
updated-dependencies:
- dependency-name: moment
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* [FIX]: Deleting a card will not return votes to users (#319)

* fix: logic change to return votes to user

* fix: optimize fix of votes when deleting

* [FEATURE]: hide votes from others on the board (#309)

* chore: reinstall packages

* chore: remove votes when hide is true

* chore: remove unnecessary comment

* chore: check hideVotes flag on cleanVotes  method

* fix: remove use of any as a type

Co-authored-by: Daniel Sousa <d.sousa@kigroup.de>

* feat: frontend hide cards from others

* feat: disable card icon dots

* feat: add new util replaceChar

* feat: pr sugestions

* feat: improve concurrently scripts

* fix: title warning

* fix: register and use socket on update board

* fix: register and use socket on update board

* fix: register and use socket on update board

* feat: update pre-commit config

* feat: update pre-commit config

* feat: update pre-commit config

* feat: update pre-commit config

* feat: start backend refactoring

* fix: remove console.log

* feat: refactoring backend

* chore: functions for css blur filters

* fix: backend tests

* fix: github conflits

* fix: github conflits

* fix: github issues

* fix: dependencies

* chore: improve replaceCard method

Co-authored-by: Daniel Sousa <d.sousa@kigroup.de>
Co-authored-by: Luís Francisco <67462841+dvpfran@users.noreply.github.com>
Co-authored-by: João Santos <68588265+joaosantos99@users.noreply.github.com>
Co-authored-by: Daniel Sousa @tutods <jdaniel.asousa@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Co-authored-by: FranciscoGaspar <43963399+FranciscoGaspar@users.noreply.github.com>
Co-authored-by: mourabraz <cmourabraz@gmail.com>
Co-authored-by: Francisco Morgado <f.morgado@kigroup.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FIX]: Board Settings switchs not working properly
2 participants