Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE]: Hide cards from others #302

Merged
merged 47 commits into from
Jul 17, 2022
Merged

[FEATURE]: Hide cards from others #302

merged 47 commits into from
Jul 17, 2022

Conversation

CatiaBarroco-xgeeks
Copy link
Contributor

Relates to #293

image
image

Proposed Changes

  • Backend:
    - Replaced all characters before send the response
    - Hided user on response for each card
  • Frontend
    - Added blur filter on content
    - Blocked: edit, delete and merge cards from other users

This pull request closes #293

@CatiaBarroco-xgeeks CatiaBarroco-xgeeks linked an issue Jul 4, 2022 that may be closed by this pull request
[FEATURE]: Hide cards from others #293
Closed
4 tasks
comoser
comoser reviewed Jul 5, 2022
View reviewed changes
backend/src/libs/utils/replaceChar.ts Outdated Show resolved Hide resolved
backend/src/libs/utils/replaceChar.ts Outdated Show resolved Hide resolved
frontend/src/components/Board/Card/CardBoard.tsx Outdated Show resolved Hide resolved
@dsousa12 dsousa12 marked this pull request as draft July 6, 2022 13:33
geomarb
geomarb previously approved these changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@geomarb geomarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsousa12 dsousa12 marked this pull request as ready for review July 14, 2022 15:37
nunocaseiro
nunocaseiro approved these changes Jul 17, 2022
View reviewed changes
Copy link
Contributor

@nunocaseiro nunocaseiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@tutods tutods merged commit cb4816a into main Jul 17, 2022
@tutods tutods deleted the feat-hide-cards-from-others branch July 17, 2022 16:22
joaosantos99 added a commit that referenced this pull request Jul 18, 2022
@joaosantos99
Revert "[FEATURE]: Hide cards from others (#302)"
4fe1335 
This reverts commit cb4816a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunocaseiro nunocaseiro nunocaseiro approved these changes

@dsousa12 dsousa12 Awaiting requested review from dsousa12

@dvpfran dvpfran Awaiting requested review from dvpfran

@comoser comoser Awaiting requested review from comoser

@RubenMCCarreira RubenMCCarreira Awaiting requested review from RubenMCCarreira

@geomarb geomarb Awaiting requested review from geomarb

Assignees

@f-morgado f-morgado

@CatiaBarroco-xgeeks CatiaBarroco-xgeeks

@dsousa12 dsousa12

Labels
backend frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Hide cards from others