Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rules js #2091

Merged
merged 108 commits into from
May 23, 2023
Merged

rules js #2091

merged 108 commits into from
May 23, 2023

Conversation

Zemnmez
Copy link
Member

@Zemnmez Zemnmez commented Feb 3, 2023

  • Simplify and abstract build files.
  • Simplify and abstract build files.
  • Use rules_js and rules_ts.

Zemnmez and others added 22 commits February 4, 2023 22:17
1. Use BZLMOD for swc
2. Use partial application of swc instead of swc_transpiler
https://docs.aspect.build/guides/rules_js_migration/#translate-your-lockfile-to-pnpm-format-optional

Translate your lockfile to pnpm format (optional)
rules_js uses the pnpm lockfile to declare dependency versions as well as a deterministic layout for the node_modules tree.

The node_modules tree laid out by rules_js should be bug-for-bug compatible with the node_modules tree that pnpm lays out with hoisting disabled (hoist=false set in your .npmrc).

We recommend adding hoist=false to your .npmrc so that your node_modules tree outside of Bazel is similar to the node_modules tree that rules_js creates:

echo "hoist=false" >> .npmrc

See npm_translate_lock documentation for more information on pnpm hoisting.
@Zemnmez
Copy link
Member Author

Zemnmez commented May 8, 2023

new list of failures etc:

================================================================================
INFO: Elapsed time: 1369.718s, Critical Path: 768.40s
INFO: 7395 processes: 990 disk cache hit, 4201 internal, 685 linux-sandbox, 1435 local, 84 worker.
FAILED: Build did NOT complete successfully
//bzl/hash/test:version_concat_test                             (cached) PASSED in 0.0s
//bzl/versioning/test/bump_on_change_test:version               (cached) PASSED in 5.2s
//bzl/versioning/test/semver_version:version_concat_test        (cached) PASSED in 0.4s
//css/testing:importee_typecheck_test                           (cached) PASSED in 0.0s
//css/testing:ts_typecheck_test                                 (cached) PASSED in 0.0s
//csv/lint/testing:testtest_out.csv_test                        (cached) PASSED in 5.2s
//git/testing:source_files_for_rule_test                        (cached) PASSED in 0.1s
//go/archive/zip/ziputil:ziputil_fmt                            (cached) PASSED in 0.0s
//go/cmd/csvpretty:csvpretty_fmt                                (cached) PASSED in 0.1s
//go/cmd/csvpretty:csvpretty_integration                        (cached) PASSED in 0.0s
//go/cmd/zipdir:zipdir_fmt                                      (cached) PASSED in 0.2s
//go/cmd/zipfiles:zipfiles_fmt                                  (cached) PASSED in 0.0s
//go/flag/flagutil:flagutil_fmt                                 (cached) PASSED in 0.0s
//js/api-extractor/config_gen:config_gen_ts_typecheck_test      (cached) PASSED in 0.0s
//js/api-extractor/testing/import:project_typecheck_test        (cached) PASSED in 0.4s
//js/api-extractor/testing/simple:project_typecheck_test        (cached) PASSED in 0.0s
//js/jest:jest_reporter_typecheck_test                          (cached) PASSED in 0.0s
//js/npm/package_json:gen_pkgjson_typecheck_test                (cached) PASSED in 0.1s
//project/cultist:action_tests_typecheck_test                   (cached) PASSED in 0.0s
//project/cultist:action_typecheck_test                         (cached) PASSED in 0.1s
//project/cultist:aspects_typecheck_test                        (cached) PASSED in 0.1s
//project/cultist:cultist_typecheck_test                        (cached) PASSED in 0.1s
//project/cultist:element_typecheck_test                        (cached) PASSED in 0.1s
//project/cultist:history_typecheck_test                        (cached) PASSED in 0.2s
//project/cultist:recipe_typecheck_test                         (cached) PASSED in 0.0s
//project/cultist:save_tests_typecheck_test                     (cached) PASSED in 0.1s
//project/cultist:save_typecheck_test                           (cached) PASSED in 0.0s
//project/cultist:slots_typecheck_test                          (cached) PASSED in 0.0s
//project/cultist:types_typecheck_test                          (cached) PASSED in 0.1s
//project/cultist:verb_typecheck_test                           (cached) PASSED in 0.0s
//project/cultist/example:example_typecheck_test                (cached) PASSED in 0.0s
//project/cultist/gen:gen_typecheck_test                        (cached) PASSED in 0.0s
//project/cultist/multiplayer:index_typecheck_test              (cached) PASSED in 0.1s
//project/cultist/multiplayer/pages:pages_typecheck_test        (cached) PASSED in 0.3s
//project/cultist/react:react_typecheck_test                    (cached) PASSED in 0.1s
//project/cultist/state:deserialize_typecheck_test              (cached) PASSED in 0.0s
//project/cultist/state:op_typecheck_test                       (cached) PASSED in 0.1s
//project/cultist/state:serialize_typecheck_test                (cached) PASSED in 0.1s
//project/cultist/state:state_main_typecheck_test               (cached) PASSED in 0.0s
//project/cultist/state:state_test_typecheck_test               (cached) PASSED in 0.1s
//project/cultist/state:state_typecheck_test                    (cached) PASSED in 0.0s
//project/zemn.me:ts_typecheck_test                             (cached) PASSED in 0.2s
//project/zemn.me/bio:bio_typecheck_test                        (cached) PASSED in 0.0s
//project/zemn.me/bio/sort_tool:sort_tool_typecheck_test        (cached) PASSED in 0.1s
//project/zemn.me/elements/DarkModeSwitcher:DarkModeSwitcher_typecheck_test (cached) PASSED in 0.0s
//project/zemn.me/elements/NavBar:NavBar_typecheck_test         (cached) PASSED in 0.0s
//project/zemn.me/elements/SliderCheckbox:SliderCheckbox_typecheck_test (cached) PASSED in 0.1s
//project/zemn.me/elements/TimeEye:TimeEye_typecheck_test       (cached) PASSED in 0.0s
//project/zemn.me/elements/TitlePage:TitlePage_typecheck_test   (cached) PASSED in 0.1s
//project/zemn.me/elements/ZemnmezLogo:ZemnmezLogo_typecheck_test (cached) PASSED in 0.0s
//project/zemn.me/hooks:hooks_typecheck_test                    (cached) PASSED in 0.1s
//project/zemn.me/pages:pages_typecheck_test                    (cached) PASSED in 0.3s
//project/zemn.me/pages/art:art_typecheck_test                  (cached) PASSED in 0.2s
//rs/cargo/testing:hello_world_fmt                              (cached) PASSED in 0.1s
//rs/cargo/testing:hello_world_test                             (cached) PASSED in 0.0s
//rs/cmd/sha256:sha256_fmt                                      (cached) PASSED in 0.2s
//rs/cmd/sha256:tests                                           (cached) PASSED in 0.0s
//rs/css/module:module_fmt                                      (cached) PASSED in 0.1s
//rs/css/module/testing:testing_css_module_generation           (cached) PASSED in 0.0s
//rs/css/module/testing:testing_json_generation                 (cached) PASSED in 0.0s
//rs/hello_world:hello_world_fmt                                (cached) PASSED in 0.1s
//rs/ts:ts_fmt                                                  (cached) PASSED in 0.1s
//rs/ts/testing:output_ts_typecheck_test                        (cached) PASSED in 0.2s
//rs/ts/testing:testing_fmt                                     (cached) PASSED in 11.0s
//testing:go_basic_test                                         (cached) PASSED in 0.1s
//testing:go_basic_test_fmt                                     (cached) PASSED in 0.1s
//testing:python_basic_test                                     (cached) PASSED in 0.8s
//testing:typescript_basic_test_js_typecheck_test               (cached) PASSED in 0.1s
//ts:ts_typecheck_test                                          (cached) PASSED in 0.1s
//ts/cmd/svgshot:npm_pkg.publish_test                           (cached) PASSED in 0.7s
//ts/cmd/svgshot:project_lint                                   (cached) PASSED in 7.3s
//ts/cmd/svgshot:project_typecheck_test                         (cached) PASSED in 0.3s
//ts/cmd/svgshot:tests_js_lint                                  (cached) PASSED in 5.7s
//ts/cmd/svgshot:tests_js_typecheck_test                        (cached) PASSED in 0.1s
//ts/cmd/svgshot/testing:project_lint                           (cached) PASSED in 5.2s
//ts/cmd/svgshot/testing:project_typecheck_test                 (cached) PASSED in 0.1s
//ts/cmd/svgshot/testing:tests                                  (cached) PASSED in 3.5s
//ts/do-sync:do-sync_typecheck_test                             (cached) PASSED in 0.4s
//ts/do-sync/testing:project_typecheck_test                     (cached) PASSED in 0.0s
//ts/force_buffer_whole_video:force_buffer_whole_video_typecheck_test (cached) PASSED in 0.0s
//ts/fs:fs_typecheck_test                                       (cached) PASSED in 0.0s
//ts/iter:iter_typecheck_test                                   (cached) PASSED in 0.1s
//ts/iter:tests_lib_typecheck_test                              (cached) PASSED in 0.1s
//ts/jest:config_browser_typecheck_test                         (cached) PASSED in 0.0s
//ts/jest:config_node_typecheck_test                            (cached) PASSED in 0.1s
//ts/knowitwhenyouseeit:project_typecheck_test                  (cached) PASSED in 0.0s
//ts/knowitwhenyouseeit:tests_js_typecheck_test                 (cached) PASSED in 0.1s
//ts/log:log_typecheck_test                                     (cached) PASSED in 0.1s
//ts/math:math_typecheck_test                                   (cached) PASSED in 0.1s
//ts/math/canvas:canvas_typecheck_test                          (cached) PASSED in 0.1s
//ts/math/canvas/braille:braille_typecheck_test                 (cached) PASSED in 0.1s
//ts/math/scale:scale_typecheck_test                            (cached) PASSED in 0.1s
//ts/math/shape:shape_typecheck_test                            (cached) PASSED in 0.0s
//ts/next.js:next.js_typecheck_test                             (cached) PASSED in 0.2s
//ts/next.js/testing/example:example_next_config_typecheck_test (cached) PASSED in 0.0s
//ts/next.js/testing/example:ts_sources_typecheck_test          (cached) PASSED in 0.2s
//ts/pulumi/dog/pleaseintroducemetoyour/public/static:static_next_config_typecheck_test (cached) PASSED in 0.0s
//ts/pulumi/dog/pleaseintroducemetoyour/public/static:ts_typecheck_test (cached) PASSED in 0.2s
//ts/pulumi/lib:lib_typecheck_test                              (cached) PASSED in 0.0s
//ts/react/article:article_typecheck_test                       (cached) PASSED in 0.3s
//ts/react/article/blurb:blurb_typecheck_test                   (cached) PASSED in 0.1s
//ts/react/element:elements_typecheck_test                      (cached) PASSED in 0.0s
//ts/react/element/link:link_typecheck_test                     (cached) PASSED in 0.0s
//ts/react/element/loading:loading_typecheck_test               (cached) PASSED in 0.0s
//ts/react/lang:lang_typecheck_test                             (cached) PASSED in 0.2s
//ts/svg:svg_typecheck_test                                     (cached) PASSED in 0.2s
//ts/testing/import_test:a_typecheck_test                       (cached) PASSED in 0.0s
//ts/testing/import_test:b_typecheck_test                       (cached) PASSED in 0.0s
//ts/testing/import_test:import_test_js_typecheck_test          (cached) PASSED in 0.0s
//ts/time:time_typecheck_test                                   (cached) PASSED in 0.0s
//ts/url:url_typecheck_test                                     (cached) PASSED in 0.1s
//deploy:release_src_typecheck_test                             FAILED TO BUILD
//ts/pulumi:pulumi_typecheck_test                               FAILED TO BUILD
//ts/pulumi/dog:dog_typecheck_test                              FAILED TO BUILD
//ts/pulumi/dog/pleaseintroducemetoyour:pleaseintroducemetoyour_typecheck_test FAILED TO BUILD
//ts/pulumi/dog/pleaseintroducemetoyour/public:public_typecheck_test FAILED TO BUILD
(Skipping other failed to build tests)
//:validate_renovate_config_test                                         PASSED in 88.8s
//.github:validation                                                     PASSED in 0.6s
//.github/workflows:validation                                           PASSED in 1.7s
//bin/linux/pulumi:smoke                                                 PASSED in 0.4s
//css/testing:importee_lint                                              PASSED in 3.8s
//css/testing:ts_lint                                                    PASSED in 5.9s
//deploy:release_src_lint                                                PASSED in 4.6s
//deploy:smoke                                                           PASSED in 0.9s
//deploy:test                                                            PASSED in 6.7s
//js/api-extractor/config_gen:config_gen_ts_lint                         PASSED in 4.9s
//js/api-extractor/testing/import:project_lint                           PASSED in 12.4s
//js/api-extractor/testing/simple:project_lint                           PASSED in 4.8s
//js/jest:jest_reporter_lint                                             PASSED in 5.6s
//js/npm/package_json:gen_pkgjson_lint                                   PASSED in 4.5s
//project/cultist:action_lint                                            PASSED in 78.7s
//project/cultist:action_test                                            PASSED in 3.1s
//project/cultist:action_tests_lint                                      PASSED in 19.4s
//project/cultist:aspects_lint                                           PASSED in 4.1s
//project/cultist:cultist_lint                                           PASSED in 4.5s
//project/cultist:element_lint                                           PASSED in 60.6s
//project/cultist:history_lint                                           PASSED in 4.8s
//project/cultist:recipe_lint                                            PASSED in 5.0s
//project/cultist:save_lint                                              PASSED in 76.0s
//project/cultist:save_test                                              PASSED in 27.2s
//project/cultist:save_tests_lint                                        PASSED in 3.6s
//project/cultist:slots_lint                                             PASSED in 5.7s
//project/cultist:types_lint                                             PASSED in 4.0s
//project/cultist:verb_lint                                              PASSED in 5.2s
//project/cultist/example:example_lint                                   PASSED in 5.0s
//project/cultist/gen:gen_lint                                           PASSED in 17.2s
//project/cultist/gen/testing:test_parse_core                            PASSED in 2.2s
//project/cultist/multiplayer:index_lint                                 PASSED in 4.6s
//project/cultist/multiplayer/pages:pages_lint                           PASSED in 4.5s
//project/cultist/react:react_lint                                       PASSED in 6.3s
//project/cultist/state:deserialize_lint                                 PASSED in 5.2s
//project/cultist/state:op_lint                                          PASSED in 5.1s
//project/cultist/state:serialize_lint                                   PASSED in 8.3s
//project/cultist/state:state_lint                                       PASSED in 5.2s
//project/cultist/state:state_main_lint                                  PASSED in 6.8s
//project/cultist/state:state_test_lint                                  PASSED in 5.3s
//project/cultist/state:test                                             PASSED in 2.9s
//project/zemn.me:ts_lint                                                PASSED in 4.3s
//project/zemn.me/bio:bio_lint                                           PASSED in 6.2s
//project/zemn.me/bio/sort_tool:sort_tool_lint                           PASSED in 9.4s
//project/zemn.me/elements/DarkModeSwitcher:DarkModeSwitcher_lint        PASSED in 5.5s
//project/zemn.me/elements/NavBar:NavBar_lint                            PASSED in 34.6s
//project/zemn.me/elements/SliderCheckbox:SliderCheckbox_lint            PASSED in 4.4s
//project/zemn.me/elements/TimeEye:TimeEye_lint                          PASSED in 14.1s
//project/zemn.me/elements/TimeEye:css_lint                              PASSED in 2.9s
//project/zemn.me/elements/TitlePage:TitlePage_lint                      PASSED in 5.4s
//project/zemn.me/elements/ZemnmezLogo:ZemnmezLogo_lint                  PASSED in 72.2s
//project/zemn.me/hooks:hooks_lint                                       PASSED in 9.4s
//project/zemn.me/pages:pages_lint                                       PASSED in 4.8s
//project/zemn.me/pages/art:art_lint                                     PASSED in 18.5s
//rs/ts/testing:output_ts_lint                                           PASSED in 21.8s
//testing:typescript_basic_test                                          PASSED in 2.3s
//testing:typescript_basic_test_js_lint                                  PASSED in 5.0s
//ts:ts_lint                                                             PASSED in 7.2s
//ts/do-sync:do-sync_lint                                                PASSED in 5.4s
//ts/do-sync:npm_pkg.publish_test                                        PASSED in 3.5s
//ts/do-sync/testing:project_lint                                        PASSED in 5.5s
//ts/do-sync/testing:tests                                               PASSED in 4.7s
//ts/force_buffer_whole_video:force_buffer_whole_video_lint              PASSED in 4.0s
//ts/fs:fs_lint                                                          PASSED in 5.1s
//ts/fs:tests                                                            PASSED in 2.5s
//ts/iter:iter_lint                                                      PASSED in 16.2s
//ts/iter:test                                                           PASSED in 50.2s
//ts/iter:tests_lib_lint                                                 PASSED in 25.6s
//ts/jest:config_browser_lint                                            PASSED in 4.5s
//ts/jest:config_node_lint                                               PASSED in 8.2s
//ts/knowitwhenyouseeit:npm_pkg.publish_test                             PASSED in 48.3s
//ts/knowitwhenyouseeit:project_lint                                     PASSED in 5.2s
//ts/knowitwhenyouseeit:tests                                            PASSED in 12.7s
//ts/knowitwhenyouseeit:tests_js_lint                                    PASSED in 3.9s
//ts/log:log_lint                                                        PASSED in 5.7s
//ts/log:test                                                            PASSED in 4.1s
//ts/math:math_lint                                                      PASSED in 6.9s
//ts/math:test                                                           PASSED in 5.2s
//ts/math/canvas:canvas_lint                                             PASSED in 4.7s
//ts/math/canvas/braille:braille_lint                                    PASSED in 5.9s
//ts/math/canvas/braille:test                                            PASSED in 9.4s
//ts/math/scale:scale_lint                                               PASSED in 5.5s
//ts/math/scale:tests                                                    PASSED in 5.3s
//ts/math/shape:shape_lint                                               PASSED in 70.6s
//ts/math/shape:shape_test                                               PASSED in 5.0s
//ts/next.js:next.js_lint                                                PASSED in 5.5s
//ts/next.js/testing/example:example_next_config_lint                    PASSED in 7.3s
//ts/next.js/testing/example:ts_sources_lint                             PASSED in 4.1s
//ts/pulumi:pulumi_lint                                                  PASSED in 4.6s
//ts/pulumi:tests                                                        PASSED in 87.3s
//ts/pulumi/dog:dog_lint                                                 PASSED in 7.9s
//ts/pulumi/dog/pleaseintroducemetoyour:pleaseintroducemetoyour_lint     PASSED in 25.8s
//ts/pulumi/dog/pleaseintroducemetoyour/public:public_lint               PASSED in 66.8s
//ts/pulumi/dog/pleaseintroducemetoyour/public/static:static_next_config_lint PASSED in 12.0s
//ts/pulumi/dog/pleaseintroducemetoyour/public/static:ts_lint            PASSED in 4.4s
//ts/pulumi/im:im_lint                                                   PASSED in 3.9s
//ts/pulumi/im/shadwell:shadwell_lint                                    PASSED in 25.2s
//ts/pulumi/im/shadwell/cert:cert_lint                                   PASSED in 10.9s
//ts/pulumi/im/shadwell/cert:cert_typecheck_test                         PASSED in 0.1s
//ts/pulumi/im/shadwell/thomas:thomas_lint                               PASSED in 5.6s
//ts/pulumi/im/shadwell/thomas/public:public_lint                        PASSED in 2.3s
//ts/pulumi/im/shadwell/zone:zone_lint                                   PASSED in 4.1s
//ts/pulumi/im/shadwell/zone:zone_typecheck_test                         PASSED in 0.0s
//ts/pulumi/lib:lib_lint                                                 PASSED in 13.1s
//ts/pulumi/me:me_lint                                                   PASSED in 4.1s
//ts/pulumi/me:me_typecheck_test                                         PASSED in 0.0s
//ts/pulumi/me/zemn:zemn_lint                                            PASSED in 17.2s
//ts/pulumi/me/zemn:zemn_typecheck_test                                  PASSED in 0.0s
//ts/pulumi/me/zemn/zone:zone_lint                                       PASSED in 3.9s
//ts/pulumi/me/zemn/zone:zone_typecheck_test                             PASSED in 0.2s
//ts/react/article:article_lint                                          PASSED in 2.7s
//ts/react/article/blurb:blurb_lint                                      PASSED in 5.3s
//ts/react/article/blurb:tests                                           PASSED in 3.6s
//ts/react/element:elements_lint                                         PASSED in 4.5s
//ts/react/element/link:link_lint                                        PASSED in 5.9s
//ts/react/element/link:tests                                            PASSED in 9.5s
//ts/react/element/loading:loading_lint                                  PASSED in 8.8s
//ts/react/lang:lang_lint                                                PASSED in 4.8s
//ts/svg:svg_lint                                                        PASSED in 4.1s
//ts/testing/import_test:a_lint                                          PASSED in 30.7s
//ts/testing/import_test:b_lint                                          PASSED in 2.7s
//ts/testing/import_test:import_test                                     PASSED in 2.7s
//ts/testing/import_test:import_test_js_lint                             PASSED in 4.4s
//ts/time:tests                                                          PASSED in 27.3s
//ts/time:time_lint                                                      PASSED in 4.2s
//ts/url:url_lint                                                        PASSED in 17.4s
//ts/url:url_test                                                        PASSED in 6.6s
//ts/cmd/svgshot:tests                                                  TIMEOUT in 300.1s

@Zemnmez
Copy link
Member Author

Zemnmez commented May 8, 2023

I think a few of these are related to runfiles, which afaik rules_js does not use:

    Received promise rejected instead of resolved
    Rejected to value: [Error: failed to run /home/thomas/.cache/bazel/_bazel_thomas/a41610ee02ad9c69b13020a7f1cf3deb/sandbox/linux-sandbox/3588/execroot/monorepo/bazel-out/k8-fastbuild/bin/ts/cmd/svgshot/tests.sh.runfiles/monorepo/cc/inkscape/run.sh --without-gui /home/thomas/.cache/bazel/_bazel_thomas/a41610ee02ad9c69b13020a7f1cf3deb/sandbox/linux-sandbox/3588/execroot/monorepo/_tmp/9b1070fbd9670321fe6f2e3a605c605a/tmp-22-maP4IQ9MEhuc-.pdf --export-type=svg --export-plain-svg --export-filename=/home/thomas/.cache/bazel/_bazel_thomas/a41610ee02ad9c69b13020a7f1cf3deb/sandbox/linux-sandbox/3588/execroot/monorepo/_tmp/9b1070fbd9670321fe6f2e3a605c605a/tmp-22-YEzCHib80NKi-.svg with Error: Command failed: /home/thomas/.cache/bazel/_bazel_thomas/a41610ee02ad9c69b13020a7f1cf3deb/sandbox/linux-sandbox/3588/execroot/monorepo/bazel-out/k8-fastbuild/bin/ts/cmd/svgshot/tests.sh.runfiles/monorepo/cc/inkscape/run.sh --without-gui /home/thomas/.cache/bazel/_bazel_thomas/a41610ee02ad9c69b13020a7f1cf3deb/sandbox/linux-sandbox/3588/execroot/monorepo/_tmp/9b1070fbd9670321fe6f2e3a605c605a/tmp-22-maP4IQ9MEhuc-.pdf --export-type=svg --export-plain-svg --export-filename=/home/thomas/.cache/bazel/_bazel_thomas/a41610ee02ad9c69b13020a7f1cf3deb/sandbox/linux-sandbox/3588/execroot/monorepo/_tmp/9b1070fbd9670321fe6f2e3a605c605a/tmp-22-YEzCHib80NKi-.svg
    ERROR: cannot find bazel_tools/tools/bash/runfiles/runfiles.bash
     -- make sure you have inkscape installed and in your PATH]

@Zemnmez
Copy link
Member Author

Zemnmez commented May 22, 2023

0 build time errors?? apparently???

@Zemnmez
Copy link
Member Author

Zemnmez commented May 22, 2023

okay... looks like one last issue... we need to make it so that puppeteer works. currently, it tries to download chrome and faiils. we need to have it put chrome somewhere as an output.

@Zemnmez
Copy link
Member Author

Zemnmez commented May 22, 2023

fairly sure I can use this https://pptr.dev/browsers-api as a build action to get the right browser.

@Zemnmez
Copy link
Member Author

Zemnmez commented May 22, 2023

actually, I think I can just get it to dump it into its own node_modules folder as the cache dir – i doubt postinstall knows better.

@Zemnmez
Copy link
Member Author

Zemnmez commented May 23, 2023

I really think it's going to work this time.

@Zemnmez
Copy link
Member Author

Zemnmez commented May 23, 2023

I really think it's going to work this time.

FUck

@Zemnmez
Copy link
Member Author

Zemnmez commented May 23, 2023

okay this time I really do think it will work.

@Zemnmez Zemnmez merged commit c438a46 into main May 23, 2023
@Zemnmez Zemnmez deleted the rules_js branch May 23, 2023 08:33
@Zemnmez
Copy link
Member Author

Zemnmez commented May 23, 2023

woo!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant