rules js

.bazelrc

@@ -91,4 +91,4 @@ build --action_env=AWS_ACCESS_KEY_ID --action_env=AWS_SECRET_ACCESS_KEY --action
 test --action_env=PULUMI_ACCESS_TOKEN
 
 # be careful with this!
-test --test_tag_filters=-do_not_run_on_main
+test --test_tag_filters=-do_not_run_on_main

.gitignore

@@ -57,4 +57,7 @@ yarn-error.log
 
 
 # generated by yarn run bazel //rs:gen_rust_project
-rust-project.json
+rust-project.json
+
+# ignore yarn since we use pnpm now
+yarn.lock

.npmrc

@@ -0,0 +1,2 @@
+hoist=false
+auto-install-peers=true

BUILD.bazel

@@ -8,21 +8,28 @@
 
 load("//js:rules.bzl", "copy_to_bin", "js_library")
 load("@com_github_bazelbuild_buildtools//buildifier:def.bzl", "buildifier")
-load("@npm//@bazel/esbuild:esbuild_config.bzl", "esbuild_config")
 load("//ts:rules.bzl", "ts_config")
-load("@npm//renovate:index.bzl", "renovate_config_validator_test")
+load("@npm//:renovate/package_json.bzl", "bin")
+load("@npm//:defs.bzl", "npm_link_all_packages")
 
 package(default_visibility = [":__subpackages__"])
 
-buildifier(
-    name = "buildifier",
-)
-
+# Useful commands to run!
 alias(
     name = "fix",
     actual = "//bzl:fix",
 )
 
+alias(
+    name = "pnpm",
+    # bazel run -- //:pnpm --dir $PWD
+    actual = "@pnpm//:pnpm",
+)
+
+buildifier(
+    name = "buildifier",
+)
+
 ts_config(
     name = "tsconfig",
     src = "tsconfig.json",
@@ -41,27 +48,46 @@ exports_files(
         ".editorconfig",
         ".eslintrc.json",
         "css_loader.d.ts",
-        "yarn.lock",
         ".git",
+        "jsconfig.json",
     ],
     visibility = ["//visibility:public"],
 )
 
-esbuild_config(
-    name = "esbuild_config",
-    config_file = "esbuild.config.mjs",
-    deps = [
-        "@npm//esbuild-css-modules-plugin",
-    ],
-)
-
 copy_to_bin(
     name = "swcrc",
     srcs = [".swcrc.json"],
 )
 
-renovate_config_validator_test(
+copy_to_bin(
+    name = "prettierrc",
+    srcs = [".prettierrc.json"],
+)
+
+copy_to_bin(
+    name = "eslintrc",
+    srcs = [".eslintrc.json"],
+)
+
+copy_to_bin(
+    name = "gitignore",
+    srcs = [".gitignore"],
+)
+
+copy_to_bin(
+    name = "editorconfig",
+    srcs = [".editorconfig"],
+)
+
+copy_to_bin(
+    name = "package_json",
+    srcs = ["package.json"],
+)
+
+bin.renovate_config_validator_test(
     name = "validate_renovate_config_test",
     args = ["$(location renovate.json)"],
     data = ["renovate.json"],
 )
+
+npm_link_all_packages(name = "node_modules")

README.md

@@ -1,15 +1,22 @@
 # Monorepo
 
-This is a bazel monorepo that I'm hoping eventually will contain most of my side-projects.
+This is a bazel monorepo containing most of my side-projects and websites etc. Using a monorepo in this way makes it much easier to ensure linting and deployment are consistent across many projects, and prevents a lot of version rot.
 
-Via the github actions workflows in [.github/workflows/ci.yml], changes in any dependencies are automatically tested and merged.
+## Usage
 
-Then, a secondary action runs which increments any version numbers necessary and commits to the [versioned branch]. This branch tracks and increments versions for export to third-party package managers like NPM.
+The repo is going through a bit of an identity crisis at the moment. I have just completed migration to rules_js, which uses PNPM -- and the PNPM binary is controlled by bazel itself.
 
-[.github/workflows/ci.yml]: .github/workflows/ci.yml
-[versioned branch]: https://github.com/Zemnmez/monorepo/tree/versioned
+I recommend having a local 'bazel' installation. However, if you just have NPM installed, you can:
 
-The deploy scripts in [deploy/BUILD] run only on the versioned branch.
+```
+npx @bazel/bazelisk test //...
+```
 
+This will recursively run all tests in parallel.
 
-[deploy/build]: deploy/BUILD
+## Neat features
+
+1. **Continuous patching**. Because Bazel allows this repo to be fully tested, Mend is able to automatically integrate patches for any and all dependencies of any project in this repo automatically.
+2. **Linting**. There are central rules that enforce basic linting standards.
+3. **Continuous deployment**. Every day, this repo runs a deploy script which detects any changes in any files and re-deploys or publishes any changed packages or services.
+4. **Automatic versioning**. The packages published on NPM use the venerable api-extractor to detect major or minor version changes to the API, and automatically increment version numbers as relevant.

WORKSPACE

@@ -17,10 +17,6 @@ load("//bzl:deps.bzl", "fetch_dependencies")
 
 fetch_dependencies()
 
-load("@build_bazel_rules_nodejs//:repositories.bzl", "build_bazel_rules_nodejs_dependencies")
-
-build_bazel_rules_nodejs_dependencies()
-
 load("@rules_pkg//:deps.bzl", "rules_pkg_dependencies")
 
 rules_pkg_dependencies()
@@ -29,17 +25,6 @@ load("@bazel_skylib//:workspace.bzl", "bazel_skylib_workspace")
 
 bazel_skylib_workspace()
 
-# The yarn_install rule runs yarn anytime the package.json or yarn.lock file changes.
-# It also extracts and installs any Bazel rules distributed in an npm package.
-load("@build_bazel_rules_nodejs//:index.bzl", "node_repositories", "yarn_install")
-
-yarn_install(
-    # Name this npm so that Bazel Label references look like @npm//package
-    name = "npm",
-    package_json = "//:package.json",
-    yarn_lock = "//:yarn.lock",
-)
-
 load("@rules_python//python:repositories.bzl", "python_register_toolchains")
 
 python_register_toolchains(
@@ -75,21 +60,6 @@ rules_proto_dependencies()
 
 rules_proto_toolchains()
 
-load("@rules_typescript_proto//:index.bzl", "rules_typescript_proto_dependencies")
-
-rules_typescript_proto_dependencies()
-
-load("@npm//@bazel/labs:package.bzl", "npm_bazel_labs_dependencies")
-
-npm_bazel_labs_dependencies()
-
-load("@rules_nodejs//nodejs:repositories.bzl", "nodejs_register_toolchains")
-
-nodejs_register_toolchains(
-    # You can choose whatever name you like for the node toolchains, and can register more than one version.
-    name = "nodejs",
-)
-
 load("@bazel_gazelle//:deps.bzl", "gazelle_dependencies")
 
 # If you use WORKSPACE.bazel, use the following line instead of the bare gazelle_dependencies():
@@ -100,27 +70,6 @@ load("@com_google_protobuf//:protobuf_deps.bzl", "protobuf_deps")
 
 protobuf_deps()
 
-load("@build_bazel_rules_nodejs//toolchains/esbuild:esbuild_repositories.bzl", "esbuild_repositories")
-
-esbuild_repositories(
-    npm_repository = "npm",
-)
-
-load("@aspect_rules_swc//swc:dependencies.bzl", "rules_swc_dependencies")
-
-rules_swc_dependencies()
-
-# Fetches a pre-built Rust-node binding from
-# https://github.com/swc-project/swc/releases.
-# If you'd rather compile it from source, you can use rules_rust, fetch the project,
-# then register the toolchain yourself. (Note, this is not yet documented)
-load("@aspect_rules_swc//swc:repositories.bzl", "LATEST_VERSION", "swc_register_toolchains")
-
-swc_register_toolchains(
-    name = "swc",
-    swc_version = LATEST_VERSION,
-)
-
 load("@rules_rust//rust:repositories.bzl", "rules_rust_dependencies", "rust_register_toolchains")
 
 rules_rust_dependencies()
@@ -146,3 +95,117 @@ crate_repositories()
 load("@rules_rust//tools/rust_analyzer:deps.bzl", "rust_analyzer_dependencies")
 
 rust_analyzer_dependencies()
+
+load("@aspect_rules_js//js:repositories.bzl", "rules_js_dependencies")
+
+rules_js_dependencies()
+
+load("@rules_nodejs//nodejs:repositories.bzl", "DEFAULT_NODE_VERSION", "nodejs_register_toolchains")
+
+nodejs_register_toolchains(
+    name = "nodejs",
+    node_version = DEFAULT_NODE_VERSION,
+)
+
+load("@aspect_rules_js//npm:npm_import.bzl", "npm_translate_lock")
+
+npm_translate_lock(
+    name = "npm",
+    # no idea how to do this yet and while there are docs
+    # the examples have a file called 'patches' that
+    # I don't have and also don't know how to generate
+    # verify_patches = "//patches",
+    data = [
+        "//:patches/svgo@3.0.2.patch",
+    ],
+    # https://github.com/aspect-build/rules_js/blob/11d3c4655b07d3094e0682a75402e972e8dae361/WORKSPACE#L139
+    lifecycle_hooks_execution_requirements = {
+        "puppeteer": [
+            "no-sandbox",
+            # Workaround Engflow not honoring requires-network on build actions
+            "no-remote-exec",
+            "requires-network",
+        ],
+    },
+    npmrc = "//:.npmrc",
+    # tool just breaks if you remove this lol
+    patch_args = {"*": ["-p1"]},
+    pnpm_lock = "//:pnpm-lock.yaml",
+    verify_node_modules_ignored = "//:.bazelignore",
+)
+
+load("@npm//:repositories.bzl", "npm_repositories")
+
+npm_repositories()
+
+# https://github.com/Zemnmez/rules_js/blob/bdf3d5a61c6af9e5d7d584cfe5f78f42d1e3f227/docs/faq.md#can-i-use-bazel-managed-pnpm
+load("@aspect_rules_js//npm:npm_import.bzl", "pnpm_repository")
+
+pnpm_repository(name = "pnpm")
+
+##################
+# rules_ts setup #
+##################
+# Fetches the rules_ts dependencies.
+# If you want to have a different version of some dependency,
+# you should fetch it *before* calling this.
+# Alternatively, you can skip calling this function, so long as you've
+# already fetched all the dependencies.
+load("@aspect_rules_ts//ts:repositories.bzl", "rules_ts_dependencies")
+
+rules_ts_dependencies(
+
+    # Alternatively, you could pick a specific version, or use
+    # load("@aspect_rules_ts//ts:repositories.bzl", "LATEST_VERSION")
+    # ts_version = LATEST_VERSION
+
+    # HEAD is currently further along than rules_ts has patches for.
+    # this will break updates to typescript, so should probably be removed when
+    # rules_ts is updated.
+    # As per https://docs-legacy.aspect.build/aspect-build/rules_ts/v0.10.0/docs/repositories-docgen.html
+    # Generate via
+    # curl --silent https://registry.npmjs.org/typescript/5.0.3 | jq -r '.dist.integrity'
+    #ts_integrity = "sha512-cW9T5W9xY37cc+jfEnaUvX91foxtHkza3Nw3wkoF4sSlKn0MONdkdEndig/qPBWXNkmplh3NzayQzCiHM4/hqw==",
+    # This keeps the TypeScript version in-sync with the editor, which is typically best.
+    ts_version_from = "//:package.json",
+)
+
+# Fetch and register node, if you haven't already
+load("@rules_nodejs//nodejs:repositories.bzl", "DEFAULT_NODE_VERSION", "nodejs_register_toolchains")
+
+nodejs_register_toolchains(
+    name = "node",
+    node_version = DEFAULT_NODE_VERSION,
+)
+
+# Register aspect_bazel_lib toolchains;
+# If you use npm_translate_lock or npm_import from aspect_rules_js you can omit this block.
+load("@aspect_bazel_lib//lib:repositories.bzl", "register_copy_directory_toolchains", "register_copy_to_directory_toolchains")
+
+register_copy_directory_toolchains()
+
+register_copy_to_directory_toolchains()
+
+###################
+# rules_swc setup #
+###################
+
+# Fetches the rules_swc dependencies.
+# If you want to have a different version of some dependency,
+# you should fetch it *before* calling this.
+# Alternatively, you can skip calling this function, so long as you've
+# already fetched all the dependencies.
+load("@aspect_rules_swc//swc:dependencies.bzl", "rules_swc_dependencies")
+
+rules_swc_dependencies()
+
+# Fetches a SWC cli from
+# https://github.com/swc-project/swc/releases
+# If you'd rather compile it from source, you can use rules_rust, fetch the project,
+# then register the toolchain yourself. (Note, this is not yet documented)
+load("@aspect_rules_swc//swc:repositories.bzl", "LATEST_VERSION", "swc_register_toolchains")
+
+swc_register_toolchains(
+    name = "swc",
+    swc_version = LATEST_VERSION,
+)

bin/linux/pulumi/BUILD.bazel

@@ -4,7 +4,6 @@ package(default_visibility = ["//:__subpackages__"])
 load("@bazel_skylib//rules:native_binary.bzl", "native_test")
 load("@bazel_skylib//lib:selects.bzl", "selects")
 
-
 config_setting(
     name = "darwin_arm64",
     constraint_values = [
@@ -53,7 +52,6 @@ config_setting(
     ],
 )
 
-
 alias(
     name = "pulumi",
     actual = select({
@@ -67,12 +65,11 @@ alias(
     }),
 )
 
-
 native_test(
     # The name of the test rule.
     name = "smoke",
     # label; path of the pre-built executable
     src = ":pulumi",
     # output; an output name for the copy of the binary
     out = "pulumi.local",
-)
+)