-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n(readme): Add traditional Chinese version of README #41
Conversation
1 |
There is a Chinese translation available on: https://github.com/zksync/credo/blob/main/README_CN.md. Any modification to that translation you would like to submit? Thank you very much! |
The difference is that this is a Chinese font used in Hong Kong. |
Please contact me if you have any questions, this PR has been open for over 3 weeks |
The Chinese translation is mostly accurate, but the last paragraph is incorrect and incoherent. I will fix it. |
Hi, Thank you for your work. I think it would be better to translate from the original English document. This will help to avoid perpetuating the errors that already exist in the CN document, such as missing content. https://github.com/zksync/credo/blob/main/README.md
Hi, Thank you for your work. I think it would be better to translate from the original English document. This will help to avoid perpetuating the errors that already exist in the CN document, such as missing content. |
中文(CN)翻译有错误?修正了吗? |
Hello @ylmin, First of all, thank you very much for contributing to the ZK Credo by translating it. We appreciate it greatly, and the community will benefit immensely from your work. To ensure the quality and consistency of the ZK Credo, we asked a third party to review the translation. We invite you to consider their feedback and make the necessary changes before we accept the PR. Please find the suggestions below:
Thank you again for your help, and let us know what you think of these suggestions. |
Thank you very much, I have changed @0xsisyfos |
@0xsisyfos review |
Thank you for this! You should be able to claim a GitPOAP for contributing to the ZK Credo: https://www.gitpoap.io/gp/1079 |
i18n(readme): Add traditional Chinese version of README