Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lint for checking that Subject attributes (RDNs) appear in the order prescribed by CABF BR 7.1.4.2 #813

Merged
merged 11 commits into from
Mar 10, 2024

Conversation

defacto64
Copy link
Contributor

Please add this lint for checking that Subject attributes (RDNs) appear in the order prescribed by CABF BR 7.1.4.2.
Effective on 15 September 2023 as per CABF BR 2.0.0

Copy link
Member

@christopher-henderson christopher-henderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @defacto64! I had only some suggestions for style consistency with the majority of the project.

v3/lints/cabf_br/lint_invalid_subject_rdn_order.go Outdated Show resolved Hide resolved
v3/lints/cabf_br/lint_invalid_subject_rdn_order_test.go Outdated Show resolved Hide resolved
v3/util/time.go Show resolved Hide resolved
christopher-henderson and others added 4 commits March 9, 2024 10:30
Fine to me.

Co-authored-by: Christopher Henderson <chris@chenderson.org>
As per Chris Henderson's suggestion, to "improve readability".
As per Chris Henderson's suggestion.
@christopher-henderson christopher-henderson merged commit e76cc77 into zmap:master Mar 10, 2024
4 checks passed
@defacto64
Copy link
Contributor Author

defacto64 commented Mar 11, 2024

Thank you Chris.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants