Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zulip api doesn't work with python 3.8 #530

Closed
janLo opened this issue Nov 26, 2019 · 7 comments
Closed

Zulip api doesn't work with python 3.8 #530

janLo opened this issue Nov 26, 2019 · 7 comments

Comments

@janLo
Copy link

janLo commented Nov 26, 2019

Using the zulip api on a current python 3.8 causes an AttributeError because of the removal of linux_distribution from platform:

AttributeError: module 'platform' has no attribute 'linux_distribution'
[...]
  File "__init__.py", line 1007, in get_profile
    return self.call_endpoint(
  File "__init__.py", line 623, in call_endpoint
    return self.do_api_query(marshalled_request, versioned_url, method=method,
  File "__init__.py", line 505, in do_api_query
    self.ensure_session()
  File "__init__.py", line 450, in ensure_session
    session.headers.update({"User-agent": self.get_user_agent()})
  File "__init__.py", line 466, in get_user_agent
    vendor, vendor_version, dummy = platform.linux_distribution()

See https://bugs.python.org/issue28167 and https://github.com/pypa/pip/pull/3906/files for a possible workaround.

@janLo
Copy link
Author

janLo commented Nov 26, 2019

Oh, I've just seen 63bc9b8. Can this be released soon?

@neiljp
Copy link
Contributor

neiljp commented Nov 26, 2019

@janLo There has been discussion on releasing a new version over the last month, on the #integrations stream at chat.zulip.org.

@eeshangarg FYI :)

@mikaelmello
Copy link

Additionally, I am getting errors because of typed-ast: python/typed_ast#126

@neiljp
Copy link
Contributor

neiljp commented Jan 2, 2020

@janLo Can you clarify whether this works for you at this point?

@mikaelmello Thanks for the link; to clarify, is this just an upstream problem as per the one you point to, (which seems fixed), or are you seeing it with a zulip dev environment?

@mikaelmello
Copy link

mikaelmello commented Jan 2, 2020 via email

@eeshangarg
Copy link
Member

@mikaelmello Thanks for the response! @neiljp I'm guessing we can close this one then?

@timabbott
Copy link
Sponsor Member

I think that's correct, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants