-
-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Python 3.8 #478
Support Python 3.8 #478
Conversation
Trying to run on python 3.8, after I login, it crashes with:
This says that's been removed in Python 3.8: pymssql/pymssql#586 |
@LeifW The issue you are seeing is within the |
5ff923b
to
d86edd3
Compare
432fbe2
to
723f9fd
Compare
Travis no longer requires these settings for Python 3.7 to work.
The zulip package containing the Zulip Python API fails under Python 3.8 prior to version 0.6.3, which in turn prevents zulip-term from running under that python version unless we depend on this updated dependency.
6acd602
to
cda8f22
Compare
After a brief confusion over whether |
@LeifW Please let us know if the latest development version has any 3.8-related issues for you here, or in a new issue :) |
This PR primarily adds a Python 3.8 test entry in Travis and claims support for installation with it via
setup.py
.We no longer need special options to test Python 3.7 (or 3.8), so I've removed this too.
NOTE: Pending a later release of the
zulip
package, I'm keeping this as a draft for now, since while the tests run fine, the current released zulip API version doesn't support 3.8. I've tested this is the case using a docker image.