Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixes and improvements after closed beta tests #62

Merged
merged 5 commits into from
Dec 9, 2020
Merged

Conversation

mheob
Copy link
Contributor

@mheob mheob commented Dec 9, 2020

Resolves #41
Resolves #43
Resolves #49
Resolves #51
Resolves #52

* feat(settings): add a link to write an email to the convertion team
  resolves #51
* style: fix unused import of settingArray (from lgtm)
* feat(article): increase the body text and line height a bit
* fix(article): hide unneeded navigation of post slideshow
* feat(article): remove DETAILS buttons and link complete preview

resolves #49
* feat(article): improve the sponsored by content
* feat(home): improve the content of the featured slider

Move the title below the image and place the sponsored by content more prominent.

Resolves #43
@mheob mheob self-assigned this Dec 9, 2020
@mheob mheob added bug Something isn't working enhancement New feature or request labels Dec 9, 2020
@codecov
Copy link

codecov bot commented Dec 9, 2020

Codecov Report

Merging #62 (0b895e7) into main (b817388) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #62   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines           99        96    -3     
  Branches        30        24    -6     
=========================================
- Hits            99        96    -3     
Impacted Files Coverage Δ
src/components/Settings/SettingsList.tsx 100.00% <ø> (ø)
src/components/Articles/ArticlePreview.tsx 100.00% <100.00%> (ø)
src/components/Articles/FeaturedCarousel.tsx 100.00% <100.00%> (ø)
src/components/Settings/LegalList.tsx 100.00% <100.00%> (ø)
src/data/settings.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b817388...a529a50. Read the comment docs.

@mheob mheob merged commit 26f91f1 into main Dec 9, 2020
@mheob mheob deleted the release/v1 branch December 9, 2020 21:17
@mheob mheob restored the release/v1 branch December 9, 2020 21:18
@mheob
Copy link
Contributor Author

mheob commented Dec 9, 2020

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@mheob mheob added the released label Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request released
Projects
None yet
1 participant