-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React Native update to 0.63 #2078
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good to me, but I'd definitely be very cautious about all the app's text inputs if they changed the default style.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue 1:
When on iOS and going through the onboarding wizard, when I'm all the way on browser, and go back to the wallet, the wizard disappears and I'm stuck until I tap skip tutorial
seen here = https://recordit.co/8r4u7d2j9h
Issue 2:
When you're on android and you are backing up seed phrase, when you tap and then deselect the pills they remove the text and is no longer legible
# Conflicts: # ios/Podfile.lock # package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA Passed 👍🏽
# Conflicts: # android/app/build.gradle # ios/MetaMask.xcodeproj/project.pbxproj # ios/Podfile.lock # package.json # yarn.lock
* develop: (48 commits) Fix input state (#2265) bump android versionCode (#2260) bugfix/use bignumber for transfer deeplinks (#2257) Fix account list scroll (#2256) TransactionController from controllers (#2243) Fix circleci apk (#2240) v1.0.11 (#2238) Feature/warn when replacing (#2176) contract metadata images bump (#2233) Handle `balanceError` case (#2148) Remove best deals badge from WYRE transfers. (#2228) @metamask/controllers@6.0.1 (#2217) Fix cloudflare redirects (#2180) Merge pull request from GHSA-wmvx-96jh-gcr4 Update @metamask/contract-metadata (#2203) React Native update to 0.63 (#2078) Create dependabot.yml (#2204) Fix "Text strings must be rendered within a <Text> component" (#2193) Use navigate instead of push (#2191) Add fiat on ramp modal close button extra hit area (#2174) ...
* Files modified * Yellow box to logbox and keyboard aware and eslint lib update * Update react navigation and fix inputs size * Update scrollview tests * keyring unit test * More scroll view unit testing update * Fix typo * Updating password unit tests * snaps * circle * 9 * CURRENT_PROJECT_VERSION * xcodeversioncircleci * gesture-handler * lock * xcodeversioncircleci * xcodeversioncircleci * xcodeagain * intallbundler * faraday * v * fastlane * bumps * ifdebug * Fix detox for android and ios builds * Fix tutorial on iOS and backup on android * Update yarn.lock * Remove ignore from ci * Update unit tests Co-authored-by: Esteban Mino <efmino@uc.cl>
Description
This updates React Native from 0.62.2 to 0.63.4:
https://react-native-community.github.io/upgrade-helper/?from=0.62.2&to=0.63.4
@ibrahimtaveras00 Important to note that:
Issue
Resolves #2065