Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix/use bignumber for transfer deeplinks #2257

Merged
merged 4 commits into from
Feb 17, 2021
Merged

bugfix/use bignumber for transfer deeplinks #2257

merged 4 commits into from
Feb 17, 2021

Conversation

estebanmino
Copy link
Contributor

@estebanmino estebanmino commented Feb 17, 2021 •
edited
Loading

Description

Write a short description of the changes included in this pull request.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #2254

@estebanmino estebanmino requested a review from a team as a code owner February 17, 2021 14:32
@estebanmino estebanmino changed the title bugfix/use bignumber for transferdeeplinks bugfix/use bignumber for transfer deeplinks Feb 17, 2021
ibrahimtaveras00
ibrahimtaveras00 approved these changes Feb 17, 2021
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good on release mode, QA Passed 👍🏽

@ibrahimtaveras00 ibrahimtaveras00 added next release QA Passed A successful QA run through has been done labels Feb 17, 2021
@estebanmino estebanmino merged commit 65499fb into develop Feb 17, 2021
@estebanmino estebanmino deleted the bugfix/use-bignumber-for-transfer-deeplinks branch February 17, 2021 19:13
rickycodes added a commit that referenced this pull request Feb 25, 2021
@rickycodes
Merge branch 'develop' into storage-migration-update
2c390bc 
* develop: (48 commits)
  Fix input state (#2265)
  bump android versionCode (#2260)
  bugfix/use bignumber for transfer deeplinks (#2257)
  Fix account list scroll (#2256)
  TransactionController from controllers (#2243)
  Fix circleci apk (#2240)
  v1.0.11 (#2238)
  Feature/warn when replacing (#2176)
  contract metadata images bump (#2233)
  Handle `balanceError` case (#2148)
  Remove best deals badge from WYRE transfers. (#2228)
  @metamask/controllers@6.0.1 (#2217)
  Fix cloudflare redirects (#2180)
  Merge pull request from GHSA-wmvx-96jh-gcr4
  Update @metamask/contract-metadata (#2203)
  React Native update to 0.63 (#2078)
  Create dependabot.yml (#2204)
  Fix "Text strings must be rendered within a <Text> component" (#2193)
  Use navigate instead of push (#2191)
  Add fiat on ramp modal close button extra hit area (#2174)
  ...
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@estebanmino
bugfix/use bignumber for transfer deeplinks (#2257)
29bbccd 
* fix

* 579

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

Assignees
No one assigned
Labels
next release QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deeplink not parsing correctly on Android
2 participants
@estebanmino @ibrahimtaveras00