-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/warn when replacing #2176
Conversation
02d98c2
to
88b5e57
Compare
c12990d
to
78d7644
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Issue 1:
The wording seems a little bit incomplete where we say "setup new"
Maybe "and setup a new wallet" or "and setup a new one"
cc: @cjeria @omnat
- Issue 2:
Mispelling
Should be "permanently"
- Issue 3:
On a smaller screen the modal is stretched out (example iPhone 5s)
-
Issue 4:
Delete confirmation doesn't pop up on iOS; seen here = http://recordit.co/A0w226up6u -
Issue 5:
In the figma mock up, it states to re-use the 'Creating wallet' loading screen from onboarding flow, and then it says not to allow going back on the onboarding carousel from here. Also I didn't see the notification that my wallet was erased. All 3 are not implemented; seen here = http://recordit.co/DeEz3hGhIh
834e607
to
c7b3750
Compare
dba806f
to
70a5ed6
Compare
|
||
constructor(props) { | ||
super(props); | ||
this.steps = props.navigation.getParam('steps', undefined); | ||
props.navigation.setParams({ | ||
headerLeft: <View /> | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is just me undoing a previous silly thing i did.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
d8b5317
to
9cb4f33
Compare
8bdc2ac
to
61f671f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA Passed 👍🏽
* Remove best deals badge from WYRE transfers. (#2228) Co-authored-by: Shivam Chaturvedi <corsairshivam@gmail.com> * Handle `balanceError` case (#2148) * Handle `balanceError` case * Adjust error case * Update handling balanceError * Remove etherscan link * Add metamask-controllers from disk * Add translation strings * Remove etherscanUrl * Revert "Add metamask-controllers from disk" This reverts commit 75ac0c68b99e5bf2ff190c20cccad4df74a8806f. * Only use this style for error case * contract metadata images bump (#2233) * contractmetadata * snaps * remotesvg * Feature/warn when replacing (#2176) * mock login changes * mock warning modal * mock delete modal * mock delete warning and submitDelete * Add isTextDelete * Add autoFocus * clean up * "delete" * undo design changes * Add en translations * Update unit tests * fix * Make this async await and catch and log failure * Remove 12-word * Adjust lineHeight * fix typo * Add logic to show delete notification * Hide back button * Disable hardware back button press * Add notification * Add closeButtonDisabled functionality * Update styles * Hide back button better on Congratulations screen * Update translation * Add breakpoint for small devices * add missing "a" * fix warning modal * Clean up BaseNotification component * Remove added styles * Remove eslint-disable-next-line * Use InteractionManager * Remove empty onHide * update empty callback * Cleanup * Add flexDirection: 'row' * Move styles to WarningExistingUserModal * Dismiss keyboard * Add strings to locales * Simplify * Add loading screen for delete * Actually delete wallet * Fix modal tap area Co-authored-by: ricky <ricky@macbook.lan> * v1.0.11 (#2238) * version * bump * Update CHANGELOG.md * update * Update CHANGELOG * Remove disclosure PR * Fix circleci apk (#2240) * resouceclass * revert * Revert "revert" This reverts commit 60df2aa. * changelog * gaba * swaps-tx * MM_FOX_CODE * swaptxs * works * fix * TransactionController from controllers (#2243) * TransactionController from controllers * query * changelog * tests * 577 * 577 * details * transactionType * token * byaction * allworking * ceanup * locales * utils * check * edgecase * test * tests * approvals * filter * more Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com> Co-authored-by: Shivam Chaturvedi <corsairshivam@gmail.com> Co-authored-by: ricky <ricky.miller@gmail.com> Co-authored-by: ricky <ricky@macbook.lan>
* develop: (48 commits) Fix input state (#2265) bump android versionCode (#2260) bugfix/use bignumber for transfer deeplinks (#2257) Fix account list scroll (#2256) TransactionController from controllers (#2243) Fix circleci apk (#2240) v1.0.11 (#2238) Feature/warn when replacing (#2176) contract metadata images bump (#2233) Handle `balanceError` case (#2148) Remove best deals badge from WYRE transfers. (#2228) @metamask/controllers@6.0.1 (#2217) Fix cloudflare redirects (#2180) Merge pull request from GHSA-wmvx-96jh-gcr4 Update @metamask/contract-metadata (#2203) React Native update to 0.63 (#2078) Create dependabot.yml (#2204) Fix "Text strings must be rendered within a <Text> component" (#2193) Use navigate instead of push (#2191) Add fiat on ramp modal close button extra hit area (#2174) ...
* mock login changes * mock warning modal * mock delete modal * mock delete warning and submitDelete * Add isTextDelete * Add autoFocus * clean up * "delete" * undo design changes * Add en translations * Update unit tests * fix * Make this async await and catch and log failure * Remove 12-word * Adjust lineHeight * fix typo * Add logic to show delete notification * Hide back button * Disable hardware back button press * Add notification * Add closeButtonDisabled functionality * Update styles * Hide back button better on Congratulations screen * Update translation * Add breakpoint for small devices * add missing "a" * fix warning modal * Clean up BaseNotification component * Remove added styles * Remove eslint-disable-next-line * Use InteractionManager * Remove empty onHide * update empty callback * Cleanup * Add flexDirection: 'row' * Move styles to WarningExistingUserModal * Dismiss keyboard * Add strings to locales * Simplify * Add loading screen for delete * Actually delete wallet * Fix modal tap area Co-authored-by: ricky <ricky@macbook.lan>
Description
Adequately warn user when replacing wallet:
Screen.record.from.2021-01-27.20.01.49.mp4
Checklist
Issue
Resolves #2115