New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Part G of transition to support modernize-use-default-member-init #5860

Merged

mvieth merged 9 commits into PointCloudLibrary:master from gnawme:feature/use-default-member-init-g

Dec 2, 2023

Contributor

gnawme commented Oct 27, 2023 •

edited

Loading

Part G of #5665, the transition to add these checks to clang-tidy:

gnawme added 3 commits

October 27, 2023 09:10


          Part G of transition to support modernize-use-default-member-init

6cebc64


          Fixed clang-tidy, clang-format CI issues

3dca669


          Made changes per inspection

ff6e9fe

mvieth reviewed

View reviewed changes

segmentation/include/pcl/segmentation/extract_clusters.h Outdated Show resolved Hide resolved

segmentation/include/pcl/segmentation/extract_polygonal_prism_data.h Outdated Show resolved Hide resolved

segmentation/include/pcl/segmentation/region_growing.h Outdated Show resolved Hide resolved

segmentation/include/pcl/segmentation/region_growing.h Outdated Show resolved Hide resolved

segmentation/include/pcl/segmentation/sac_segmentation.h Outdated Show resolved Hide resolved

segmentation/include/pcl/segmentation/sac_segmentation.h Outdated Show resolved Hide resolved

segmentation/include/pcl/segmentation/conditional_euclidean_clustering.h Outdated Show resolved Hide resolved


          Made changes per review

8ea136a

mvieth reviewed

View reviewed changes

segmentation/include/pcl/segmentation/extract_labeled_clusters.h Outdated Show resolved Hide resolved

segmentation/include/pcl/segmentation/impl/region_growing.hpp Outdated Show resolved Hide resolved


          Made more changes per review

bca4d31

mvieth previously approved these changes

View reviewed changes

Member

mvieth left a comment

Thanks!
The failing check seems unrelated (not caused by these changes)

mvieth requested a review from larshg

November 16, 2023 13:48

larshg reviewed

View reviewed changes

segmentation/include/pcl/segmentation/extract_clusters.h Outdated Show resolved Hide resolved

larshg reviewed

View reviewed changes

segmentation/include/pcl/segmentation/grabcut_segmentation.h Outdated Show resolved Hide resolved

larshg reviewed

View reviewed changes

segmentation/include/pcl/segmentation/grabcut_segmentation.h Outdated Show resolved Hide resolved

larshg reviewed

View reviewed changes

segmentation/include/pcl/segmentation/impl/min_cut_segmentation.hpp Outdated Show resolved Hide resolved

larshg reviewed

View reviewed changes

segmentation/include/pcl/segmentation/impl/unary_classifier.hpp Outdated Show resolved Hide resolved

larshg reviewed

View reviewed changes

segmentation/include/pcl/segmentation/unary_classifier.h Outdated Show resolved Hide resolved

larshg reviewed

View reviewed changes

segmentation/include/pcl/segmentation/organized_multi_plane_segmentation.h Outdated Show resolved Hide resolved

larshg reviewed

View reviewed changes

segmentation/include/pcl/segmentation/organized_multi_plane_segmentation.h Outdated Show resolved Hide resolved

larshg reviewed

View reviewed changes

segmentation/include/pcl/segmentation/sac_segmentation.h Outdated Show resolved Hide resolved

larshg reviewed

View reviewed changes

segmentation/include/pcl/segmentation/sac_segmentation.h Outdated Show resolved Hide resolved

larshg reviewed

View reviewed changes

segmentation/include/pcl/segmentation/seeded_hue_segmentation.h Outdated Show resolved Hide resolved

larshg reviewed

View reviewed changes

segmentation/include/pcl/segmentation/segment_differences.h Outdated Show resolved Hide resolved

larshg reviewed

View reviewed changes

tools/ply2ply.cpp Outdated Show resolved Hide resolved

larshg reviewed

View reviewed changes

tools/ply2raw.cpp Outdated Show resolved Hide resolved


          Addressed review comments

3adea28

gnawme dismissed mvieth’s stale review via

3adea28

November 29, 2023 00:03


          Addressed CI errors, omitted review comments

40aea91

larshg reviewed

View reviewed changes

segmentation/include/pcl/segmentation/organized_multi_plane_segmentation.h Outdated Show resolved Hide resolved


          Addressed more build errors

0a3a158

larshg previously approved these changes

View reviewed changes

mvieth reviewed

View reviewed changes

segmentation/include/pcl/segmentation/grabcut_segmentation.h Outdated Show resolved Hide resolved


          Addressed additional review comment

54aea2b

gnawme dismissed larshg’s stale review via

54aea2b

December 1, 2023 18:30

mvieth approved these changes

View reviewed changes

Member

mvieth left a comment

Thanks again!
@larshg I am going to assume that you still approve, since the last change was very minor

mvieth merged commit e2656ed into PointCloudLibrary:master

13 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment