Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part G of transition to support modernize-use-default-member-init #5860

Merged
Merged
Prev Previous commit
Next Next commit
Addressed CI errors, omitted review comments
  • Loading branch information
gnawme committed Nov 30, 2023
commit 40aea91cfa821b9b7d2147b57525199c2a7ff768
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,7 @@

//////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
template <typename PointT>
pcl::UnaryClassifier<PointT>::UnaryClassifier()
: input_cloud_(new pcl::PointCloud<PointT>)
{}
pcl::UnaryClassifier<PointT>::UnaryClassifier() = default;

//////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
template <typename PointT>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -288,10 +288,10 @@ namespace pcl
bool project_points_{false};

/** \brief A comparator for comparing neighboring pixels' plane equations. */
PlaneComparatorPtr compare_{new PlaneComparator};
PlaneComparatorPtr compare_{new PlaneComparator()};

/** \brief A comparator for use on the refinement step. Compares points to regions segmented in the first pass. */
PlaneRefinementComparatorPtr refinement_compare_{new PlaneRefinementComparatorPtr};
PlaneRefinementComparatorPtr refinement_compare_{new PlaneRefinementComparatorPtr()};
gnawme marked this conversation as resolved.
Show resolved Hide resolved

/** \brief Class getName method. */
virtual std::string
Expand Down
2 changes: 1 addition & 1 deletion segmentation/include/pcl/segmentation/unary_classifier.h
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ namespace pcl


/** \brief Contains the input cloud */
typename pcl::PointCloud<PointT>::Ptr input_cloud_{nullptr};
typename pcl::PointCloud<PointT>::Ptr input_cloud_{new pcl::PointCloud<PointT>};

bool label_field_{false};

Expand Down
Loading