Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Part G of transition to support modernize-use-default-member-init #5860

Merged
merged 9 commits into from
Dec 2, 2023
Merged

Part G of transition to support modernize-use-default-member-init #5860

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6cebc64
Part G of transition to support modernize-use-default-member-init
gnawme Oct 27, 2023
3dca669
Fixed clang-tidy, clang-format CI issues
gnawme Oct 27, 2023
ff6e9fe
Made changes per inspection
gnawme Oct 28, 2023
8ea136a
Made changes per review
gnawme Nov 1, 2023
bca4d31
Made more changes per review
gnawme Nov 3, 2023
3adea28
Addressed review comments
gnawme Nov 29, 2023
40aea91
Addressed CI errors, omitted review comments
gnawme Nov 30, 2023
0a3a158
Addressed more build errors
gnawme Dec 1, 2023
54aea2b
Addressed additional review comment
gnawme Dec 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Addressed more build errors
  • Loading branch information
@gnawme
gnawme committed Dec 1, 2023
commit 0a3a1583fa003017a15cbfe0748398de5d19360e
6 changes: 3 additions & 3 deletions segmentation/include/pcl/segmentation/organized_multi_plane_segmentation.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ namespace pcl
using PlaneRefinementComparatorConstPtr = typename PlaneRefinementComparator::ConstPtr;

/** \brief Constructor for OrganizedMultiPlaneSegmentation. */
OrganizedMultiPlaneSegmentation () = default;
OrganizedMultiPlaneSegmentation() = default;

/** \brief Destructor for OrganizedMultiPlaneSegmentation. */

Expand Down Expand Up @@ -288,10 +288,10 @@ namespace pcl
bool project_points_{false};

/** \brief A comparator for comparing neighboring pixels' plane equations. */
PlaneComparatorPtr compare_{new PlaneComparator()};
PlaneComparatorPtr compare_{new PlaneComparator};

/** \brief A comparator for use on the refinement step. Compares points to regions segmented in the first pass. */
PlaneRefinementComparatorPtr refinement_compare_{new PlaneRefinementComparatorPtr()};
PlaneRefinementComparatorPtr refinement_compare_{new PlaneRefinementComparator};

/** \brief Class getName method. */
virtual std::string
Expand Down