Update server-side State.data to accept arbitrary JSON
#6896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
force-pushed
the
results/8-data-agnostic-server
branch
from
7624e74
to
9d1c90e
Compare
2 tasks
This was referenced Sep 21, 2022
zanieb
added a commit
that referenced
this pull request
Sep 28, 2022
* Move result method to client-specific state schema * Fix import of `rules` * Move `OrchestrationResult` to `schemas.responses` to fix circular imports * Repair some imports in the test suite * Update flow and task tests to use client-side schemas * Fix tests; update `cls` addition to be backwards compatible * Update server-side `State.data` to accept arbitrary JSON * Add test
3 tasks
zanieb
added a commit
that referenced
this pull request
Oct 6, 2022
* Move result method to client-specific state schema * Fix import of `rules` * Move `OrchestrationResult` to `schemas.responses` to fix circular imports * Repair some imports in the test suite * Update flow and task tests to use client-side schemas * Fix tests; update `cls` addition to be backwards compatible * Update server-side `State.data` to accept arbitrary JSON * Add test
zanieb
added a commit
that referenced
this pull request
Oct 12, 2022
* Move result method to client-specific state schema * Fix import of `rules` * Move `OrchestrationResult` to `schemas.responses` to fix circular imports * Repair some imports in the test suite * Update flow and task tests to use client-side schemas * Fix tests; update `cls` addition to be backwards compatible * Update server-side `State.data` to accept arbitrary JSON * Add test
zanieb
added a commit
that referenced
this pull request
Oct 12, 2022
* Move result method to client-specific state schema * Fix import of `rules` * Move `OrchestrationResult` to `schemas.responses` to fix circular imports * Repair some imports in the test suite * Update flow and task tests to use client-side schemas * Fix tests; update `cls` addition to be backwards compatible * Update server-side `State.data` to accept arbitrary JSON * Add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #6895
Updates server-side schemas to accept any JSON for
State.datainstead of enforcing aDataDocumentblob. This means that the client is responsible for deciding the format for results.Example
The client-side state schema still enforces a
DataDocument, so you cannot use theOrionClientto take advantage of this change. A manual API request could be made though.Checklist
[ ] This pull request references any related issue by including "closes<link to issue>"fix,feature,enhancement,docs,collections, ormaintenancelabel categorizing the change.