Tracking: Add first-class results #6908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prefect-orion ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
3 tasks
zanieb
changed the title
This was referenced Sep 27, 2022
zanieb
force-pushed
the
feature/results
branch
from
8bdfa22
to
8ca3c83
Compare
3 tasks
zanieb
force-pushed
the
feature/results
branch
from
fa694c4
to
d3e0a11
Compare
* Move result method to client-specific state schema * Fix import of `rules` * Move `OrchestrationResult` to `schemas.responses` to fix circular imports * Repair some imports in the test suite * Update flow and task tests to use client-side schemas * Fix tests; update `cls` addition to be backwards compatible * Add backwards compatibility method with warning and test
…6899) * Add pickle serializer from packagers * Add Prefect JSON encoders/decoders * Refactor custom json hooks and write tests * Remove exception group reduce patch This will likely be needed for pickling exceptions, but is not needed yet here * Mark dumps/loads as abstract methods * Add dumps/loads to satisfy ABC * Add missing test files * Add dumps/loads to satisfy ABC * Rename test case variable * Bump minimum pydantic version to get JSON serdes support * Bump minimum typing_extensions version for solvable lower bounds * Fix typo Co-authored-by: Chris Pickett <chris.pickett@prefect.io> Co-authored-by: Chris Pickett <chris.pickett@prefect.io>
* Move result method to client-specific state schema * Fix import of `rules` * Move `OrchestrationResult` to `schemas.responses` to fix circular imports * Repair some imports in the test suite * Update flow and task tests to use client-side schemas * Fix tests; update `cls` addition to be backwards compatible * Update server-side `State.data` to accept arbitrary JSON * Add test
…6900) * Consolidate `DataDocument` related handling into `deprecated` module * Restore `blocks` file * Fix DataDocument reference in postgres migration * Remove `data` schema from docs * Add deprecated import * Fix missed postgres import * Fix merge
Co-authored-by: Terrence Dorsey <terrence@prefect.io>
Co-authored-by: Bill Palombi <bill@prefect.io> Co-authored-by: Terrence Dorsey <terrence@prefect.io>
Co-authored-by: Ville Parkkinen <ville.parkkinen@nordicmobiletrust.com>
# Conflicts: # .github/workflows/integration-tests.yaml # src/prefect/deployments.py # src/prefect/engine.py
# Conflicts: # src/prefect/blocks/core.py # src/prefect/deployments.py
zanieb
force-pushed
the
feature/results
branch
from
053bfe2
to
859aa58
Compare
zanieb
requested review from
anticorrelator,
tpdorsey,
cicdw and
zangell44
as code owners
|
I missed a few things with my rebase to get up to date with |
tpdorsey
approved these changes
Oct 12, 2022
|
Thank you @madkinsz! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking branch for consolidation of result configuration changes.
Includes:
prefect.client.schemasand client-side state type #6895JSONSerializerandPickleSerializertoprefect.serializers#6899State.datato accept arbitrary JSON #6896DataDocumentrelated handling intodeprecatedmodule #6900prefect.resulttypes and utilities #6973PickleSerializerand add tests #7044State.result()#7071task_input_hash#7048Statetypes intoprefect.states#7108Related changes, but into
main:Optionaland default #6829copy_model_fieldsutility for action schemas #6813OrionClientduring block registration, save, and load #6857sync_compatible#7073Planned:
Future:
May fix:
ValueError: Path /root/.prefect/storage/...does not exist #6086Unblocks:
Closes issues:
FileNotFoundError: [Errno 2] No such file or directory: '/.prefect/storage'with agent started as non-root user #6040