-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate DataDocument
related handling into deprecated
module
#6900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
force-pushed
the
results/11-deprecate-data-docs
branch
from
September 20, 2022 21:28
cb58a3b
to
1e3f932
Compare
Merged
GitHub declares this shall have a migration label. I have modified the initial migration to not rely on this type explicitly. |
2 tasks
bunchesofdonald
approved these changes
Sep 21, 2022
tpdorsey
approved these changes
Sep 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Base automatically changed from
results/8-data-agnostic-server
to
feature/results
September 21, 2022 18:25
zanieb
force-pushed
the
results/11-deprecate-data-docs
branch
from
September 21, 2022 18:26
c2f62a1
to
d818385
Compare
6 tasks
zanieb
added a commit
that referenced
this pull request
Sep 28, 2022
…6900) * Consolidate `DataDocument` related handling into `deprecated` module * Restore `blocks` file * Fix DataDocument reference in postgres migration * Remove `data` schema from docs * Add deprecated import * Fix missed postgres import * Fix merge
3 tasks
zanieb
added a commit
that referenced
this pull request
Oct 6, 2022
…6900) * Consolidate `DataDocument` related handling into `deprecated` module * Restore `blocks` file * Fix DataDocument reference in postgres migration * Remove `data` schema from docs * Add deprecated import * Fix missed postgres import * Fix merge
zanieb
added a commit
that referenced
this pull request
Oct 12, 2022
…6900) * Consolidate `DataDocument` related handling into `deprecated` module * Restore `blocks` file * Fix DataDocument reference in postgres migration * Remove `data` schema from docs * Add deprecated import * Fix missed postgres import * Fix merge
zanieb
added a commit
that referenced
this pull request
Oct 12, 2022
…6900) * Consolidate `DataDocument` related handling into `deprecated` module * Restore `blocks` file * Fix DataDocument reference in postgres migration * Remove `data` schema from docs * Add deprecated import * Fix missed postgres import * Fix merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #6896
Begins deprecation of
DataDocuments
which will be replaced by a not-yet-introducedResult
type and serializers from #6899. Copes contents ofprefect.serializers
,prefect.orion.serializers
,prefect.orion.schemas.data
toprefect.deprecated.data_documents
. There should be no change in behavior. Users will not be able to import internal serializers directly from the old locations.Checklist
[ ] This pull request references any related issue by including "closes<link to issue>
"fix
,feature
,enhancement
,docs
,collections
, ormaintenance
label categorizing the change.