Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate DataDocument related handling into deprecated module #6900

Merged
merged 7 commits into from
Sep 21, 2022

Conversation

zanieb
Copy link
Contributor

@zanieb zanieb commented Sep 20, 2022

Requires #6896

Begins deprecation of DataDocuments which will be replaced by a not-yet-introduced Result type and serializers from #6899. Copes contents of prefect.serializers, prefect.orion.serializers, prefect.orion.schemas.data to prefect.deprecated.data_documents. There should be no change in behavior. Users will not be able to import internal serializers directly from the old locations.

Checklist

  • [ ] This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • This pull request includes tests or only affects documentation.
  • This pull request includes a fix, feature, enhancement, docs, collections, or maintenance label categorizing the change.

@zanieb
Copy link
Contributor Author

zanieb commented Sep 20, 2022

GitHub declares this shall have a migration label. I have modified the initial migration to not rely on this type explicitly.

@zanieb zanieb marked this pull request as ready for review September 21, 2022 15:59
Copy link
Contributor

@tpdorsey tpdorsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from results/8-data-agnostic-server to feature/results September 21, 2022 18:25
@zanieb zanieb force-pushed the results/11-deprecate-data-docs branch from c2f62a1 to d818385 Compare September 21, 2022 18:26
@zanieb zanieb merged commit 8bdfa22 into feature/results Sep 21, 2022
@zanieb zanieb deleted the results/11-deprecate-data-docs branch September 21, 2022 18:50
zanieb added a commit that referenced this pull request Sep 28, 2022
…6900)

* Consolidate `DataDocument` related handling into `deprecated` module

* Restore `blocks` file

* Fix DataDocument reference in postgres migration

* Remove `data` schema from docs

* Add deprecated import

* Fix missed postgres import

* Fix merge
@zanieb zanieb mentioned this pull request Oct 5, 2022
3 tasks
zanieb added a commit that referenced this pull request Oct 6, 2022
…6900)

* Consolidate `DataDocument` related handling into `deprecated` module

* Restore `blocks` file

* Fix DataDocument reference in postgres migration

* Remove `data` schema from docs

* Add deprecated import

* Fix missed postgres import

* Fix merge
zanieb added a commit that referenced this pull request Oct 12, 2022
…6900)

* Consolidate `DataDocument` related handling into `deprecated` module

* Restore `blocks` file

* Fix DataDocument reference in postgres migration

* Remove `data` schema from docs

* Add deprecated import

* Fix missed postgres import

* Fix merge
zanieb added a commit that referenced this pull request Oct 12, 2022
…6900)

* Consolidate `DataDocument` related handling into `deprecated` module

* Restore `blocks` file

* Fix DataDocument reference in postgres migration

* Remove `data` schema from docs

* Add deprecated import

* Fix missed postgres import

* Fix merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants