Refactor result types names #7106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
requested review from
bunchesofdonald,
billpalombi and
jlowin
and removed request for
cicdw
zanieb
force-pushed
the
results/21-refactor-types
branch
from
4cb3d55
to
9e7a151
Compare
tpdorsey
approved these changes
Oct 7, 2022
This was referenced Oct 7, 2022
zanieb
force-pushed
the
results/21-refactor-types
branch
from
595f0c0
to
0ee9efb
Compare
✅ Deploy Preview for prefect-orion ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
zanieb
added a commit
that referenced
this pull request
Oct 12, 2022
zanieb
added a commit
that referenced
this pull request
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #7094
Updates the block type names as follows:
ResultLiteral➝LiteralResultResultReference➝PersistedResultResultBlob➝PersistedResultBlobThese types are primarily internal.
I believe this will add clarity to the meaning of these result types. This ordering also makes it easier to add new result types in the future, for example, an
ErrorResultwhich contains information about an exception. With the reversed names,ResultErrorwould look like an issue with creating the result.