Refactor State types into prefect.states
#7108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
requested review from
bunchesofdonald and
peytonrunyan
and removed request for
cicdw
zanieb
force-pushed
the
results/21-refactor-types
branch
from
595f0c0
to
0ee9efb
Compare
zanieb
force-pushed
the
results/22-refactor-states
branch
from
d8d8f99
to
2e3a619
Compare
✅ Deploy Preview for prefect-orion ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| from prefect.utilities.asyncutils import asyncnullcontext | ||
|
|
||
|
|
||
| def inject_client(fn): |
peytonrunyan
approved these changes
Oct 11, 2022
zanieb
added a commit
that referenced
this pull request
Oct 12, 2022
# Conflicts: # src/prefect/blocks/core.py # src/prefect/deployments.py
zanieb
added a commit
that referenced
this pull request
Oct 12, 2022
# Conflicts: # src/prefect/blocks/core.py # src/prefect/deployments.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #7106
I was uncomfortable with the implementation details present in
prefect.client.schemasas well as the lack of clarity on where state types should be imported from. This moves implementation details of theStatetype and related utilities intoprefect.states.prefect.client.schemasnow contains schemas with no logic. A bit of shuffling was required to resolve circular imports here. I've movedinject_clientto a dedicated module as we use it in nearly every client module and it is a constant source of circular import issues.