Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual flow retries #7152

Merged
merged 97 commits into from
Oct 24, 2022
Merged
Changes from 1 commit
Commits
Show all changes
97 commits
Select commit Hold shift + click to select a range
5ac9b3e
Sketch out flow restart overview
anticorrelator Oct 12, 2022
44c5ef7
Merge branch 'main' of github.com:PrefectHQ/prefect into flow-restarts
anticorrelator Oct 12, 2022
f72a03b
Spike out flow restart logic
anticorrelator Oct 12, 2022
ca5edda
Merge branch 'main' of github.com:PrefectHQ/prefect into flow-restarts
anticorrelator Oct 12, 2022
4dc7be0
Clean up flow restart logic
anticorrelator Oct 12, 2022
e7a8a79
Add rules constraining flow restarts
anticorrelator Oct 12, 2022
407649f
Only update task runs if no restart indicator has been set
anticorrelator Oct 12, 2022
a23990a
Restarted flows must have deployments
anticorrelator Oct 12, 2022
1f74305
Fix bugs in restart policy
anticorrelator Oct 12, 2022
62c0a70
Start adding restart tests
anticorrelator Oct 13, 2022
8834274
Improve flow restart test
anticorrelator Oct 13, 2022
966c342
Spike out SoftRetry example
anticorrelator Oct 13, 2022
c4f99cb
Merge branch 'main' of github.com:PrefectHQ/prefect into flow-restarts
anticorrelator Oct 13, 2022
86ce10d
Move "soft" retry policy to FlowRetryPolicy
anticorrelator Oct 13, 2022
beba97a
Use correct rule name
anticorrelator Oct 13, 2022
a540968
Merge branch 'main' of github.com:PrefectHQ/prefect into flow-restarts
anticorrelator Oct 14, 2022
78c2ab6
Use retry logic for restarts
anticorrelator Oct 14, 2022
6cab09a
Use `AwaitingRetry` state for consistency
anticorrelator Oct 14, 2022
96c8841
anticorrelator Oct 14, 2022
2bb6d3a
Merge branch 'main' of github.com:PrefectHQ/prefect into flow-restarts
anticorrelator Oct 17, 2022
dde4c90
Start consolidating Restart logic
anticorrelator Oct 17, 2022
ce7d832
Remove separate FlowRestartPolicy
anticorrelator Oct 18, 2022
91a549f
Use unified retry/restart rules
anticorrelator Oct 18, 2022
9339993
Move update task run model method
anticorrelator Oct 18, 2022
3bb2fac
Finish sketching out retry/restart logic
anticorrelator Oct 19, 2022
e01bc10
anticorrelator Oct 19, 2022
94ab790
Attempt to update subflow retry state machine
anticorrelator Oct 19, 2022
a335c7d
anticorrelator Oct 19, 2022
6c57b90
Remove special handling for subflow tasks
anticorrelator Oct 19, 2022
b852fde
Only rerun subflows that have not completed
anticorrelator Oct 19, 2022
1409ac5
Permit restart transitions
anticorrelator Oct 19, 2022
660ca4f
Update restart test
anticorrelator Oct 19, 2022
0deb7af
Remove needless imports
anticorrelator Oct 19, 2022
07d9f72
Update flow retry tests
anticorrelator Oct 19, 2022
ba45c0b
Spike out message passing between rules
anticorrelator Oct 19, 2022
7a18dd1
anticorrelator Oct 19, 2022
0d997c0
Remove needless import
anticorrelator Oct 19, 2022
da08672
Pass more explicit messages between rules
anticorrelator Oct 19, 2022
834bfb7
Merge branch 'main' of github.com:PrefectHQ/prefect into flow-restarts
anticorrelator Oct 19, 2022
100b79e
Revert unintentional change to a rule
anticorrelator Oct 19, 2022
ebf1136
Add migrations
anticorrelator Oct 19, 2022
ffb50f7
Use updated columns
anticorrelator Oct 19, 2022
794b36d
Remove unused model methods and schema actions
anticorrelator Oct 19, 2022
f3db390
Merge branch 'main' of github.com:PrefectHQ/prefect into flow-restarts
anticorrelator Oct 19, 2022
3b5c7df
Add test for passing context parameters between rules
anticorrelator Oct 19, 2022
38e9bf5
Update restart test
anticorrelator Oct 19, 2022
b28208f
Add tests for FlowRestart rule
anticorrelator Oct 20, 2022
8bbc98f
Start adding tests for rerunning tasks on restart/retry
anticorrelator Oct 20, 2022
85d81b5
Refactor task rerunning rule for clarity
anticorrelator Oct 20, 2022
d1854b2
Fix assertion
anticorrelator Oct 20, 2022
2a785c4
Fix test
anticorrelator Oct 20, 2022
a8dc688
Add FizzlingRule fixture and cleanup test for rerunning rule
anticorrelator Oct 20, 2022
15c6e17
anticorrelator Oct 20, 2022
c4e84b4
Permit rerunning tasks during the last flow retry
anticorrelator Oct 20, 2022
bad94df
Remove needless imports
anticorrelator Oct 20, 2022
bb54b55
Test restarting flows via API
anticorrelator Oct 20, 2022
c71fe93
Change restart tests to use `set_statee instead of dedicated route
anticorrelator Oct 20, 2022
43bef0c
Remove dedicated restart flow run route
anticorrelator Oct 20, 2022
a289c93
anticorrelator Oct 20, 2022
ca6ccf8
Bump minor API version (?)
anticorrelator Oct 20, 2022
af8dffc
Create flow runs using model directly instead of modifying create schema
anticorrelator Oct 20, 2022
a6b69ed
Merge branch 'main' of github.com:PrefectHQ/prefect into flow-restarts
anticorrelator Oct 20, 2022
c37af3e
Remove `AwaitingRestart` convenience constructor
anticorrelator Oct 20, 2022
407507a
Add docstrings
anticorrelator Oct 20, 2022
9b347d3
Bump minimum API version
anticorrelator Oct 20, 2022
59ca469
Merge branch 'main' of github.com:PrefectHQ/prefect into flow-restarts
anticorrelator Oct 20, 2022
0e6f1f4
Fix issues with conflicting migrations
anticorrelator Oct 20, 2022
0277ca1
Merge branch 'main' of github.com:PrefectHQ/prefect into flow-restarts
anticorrelator Oct 20, 2022
d2869f2
Use models instead of create actions
anticorrelator Oct 20, 2022
669698a
Revert version changes
anticorrelator Oct 20, 2022
3267e82
Add integration test for flow retries with subflows
anticorrelator Oct 20, 2022
4b279ec
Use correct name in integration test
anticorrelator Oct 20, 2022
cdb4970
Use better names
anticorrelator Oct 20, 2022
156a9b1
Add flow retry compatibility code to rules
anticorrelator Oct 20, 2022
6f45831
anticorrelator Oct 20, 2022
9deb857
Add error handling to orchestration fixture
anticorrelator Oct 20, 2022
5128133
Merge branch 'main' of github.com:PrefectHQ/prefect into flow-restarts
anticorrelator Oct 20, 2022
e91aebd
Fix compatibility code
anticorrelator Oct 20, 2022
bedc6d0
Merge branch 'main' of github.com:PrefectHQ/prefect into flow-restarts
anticorrelator Oct 20, 2022
c58f6b4
Merge branch 'main' of github.com:PrefectHQ/prefect into flow-restarts
anticorrelator Oct 20, 2022
a0cbac2
Resolve another migration conflict
anticorrelator Oct 20, 2022
80ec6fc
Fix restart bookkeeping logic
anticorrelator Oct 21, 2022
ba32275
Merge branch 'main' of github.com:PrefectHQ/prefect into flow-restarts
anticorrelator Oct 21, 2022
3c1c322
Sketch out simplifying restarts as retries
anticorrelator Oct 24, 2022
66fa7f2
Unify "retry" transition rules with "terminal state" rules
anticorrelator Oct 24, 2022
61c0cb9
Fix name errors
anticorrelator Oct 24, 2022
12196be
Rework core policy tests to use updated terminal state protection rules
anticorrelator Oct 24, 2022
0251db0
Update restart tests to check manual retry behavior
anticorrelator Oct 24, 2022
bdfb180
Update tests that permit rerunning retrying tasks
anticorrelator Oct 24, 2022
cafb170
Update API tests for manual retries
anticorrelator Oct 24, 2022
d3c43ca
Remove extra columns
anticorrelator Oct 24, 2022
65714ce
Rename `retry_attempt` to `flow_run_run_count`
anticorrelator Oct 24, 2022
4d6bdfb
Separate flow run tracking into its own rule for clarity
anticorrelator Oct 24, 2022
ddaf599
Merge pull request #7308 from PrefectHQ/simplify-restarts-into-retries
anticorrelator Oct 24, 2022
0d60365
Merge branch 'main' of github.com:PrefectHQ/prefect into flow-restarts
anticorrelator Oct 24, 2022
d2c5f97
Rename rules for clarity
anticorrelator Oct 24, 2022
83d98cc
isort
anticorrelator Oct 24, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' of github.com:PrefectHQ/prefect into flow-restarts
  • Loading branch information
anticorrelator committed Oct 20, 2022
commit a6b69ed1fe97e1cf6590f938f4ac383a05fa0b68

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.