-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework server-side entity spawning #2093
Rework server-side entity spawning #2093
Conversation
NitroxServer-Subnautica/Resources/Parsers/Helper/AssetsBundleManager.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor quick code review for now so I can look at PR 2090
NitroxModel-Subnautica/DataStructures/GameLogic/Entities/SubnauticaUwePrefabFactory.cs
Outdated
Show resolved
Hide resolved
NitroxModel/DataStructures/GameLogic/Entities/UweWorldEntityFactory.cs
Outdated
Show resolved
Hide resolved
NitroxModel/DataStructures/GameLogic/Entities/PrefabPlaceholderEntity.cs
Show resolved
Hide resolved
NitroxClient/GameLogic/Spawning/WorldEntities/SerializedWorldEntitySpawner.cs
Outdated
Show resolved
Hide resolved
…mly-generated-on-the-fly entities
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll wait for further reviews to push the mentionned changes
NitroxClient/GameLogic/Spawning/WorldEntities/PrefabPlaceholderEntitySpawner.cs
Outdated
Show resolved
Hide resolved
NitroxClient/GameLogic/Spawning/WorldEntities/SerializedWorldEntitySpawner.cs
Show resolved
Hide resolved
NitroxModel-Subnautica/DataStructures/GameLogic/Entities/SubnauticaUwePrefabFactory.cs
Show resolved
Hide resolved
NitroxModel-Subnautica/DataStructures/GameLogic/Entities/SubnauticaUwePrefabFactory.cs
Outdated
Show resolved
Hide resolved
NitroxModel/DataStructures/GameLogic/Entities/UwePrefabFactory.cs
Outdated
Show resolved
Hide resolved
NitroxModel/DataStructures/GameLogic/Entities/UwePrefabFactory.cs
Outdated
Show resolved
Hide resolved
NitroxModel/DataStructures/GameLogic/Entities/UweWorldEntity.cs
Outdated
Show resolved
Hide resolved
NitroxModel/DataStructures/GameLogic/Entities/UweWorldEntityFactory.cs
Outdated
Show resolved
Hide resolved
NitroxModel/DataStructures/GameLogic/Entities/UweWorldEntityFactory.cs
Outdated
Show resolved
Hide resolved
NitroxServer-Subnautica/GameLogic/Entities/Spawning/CrashFishBootstrapper.cs
Outdated
Show resolved
Hide resolved
NitroxServer-Subnautica/Resources/Parsers/PrefabPlaceholderGroupsParser.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor thing: moving the PrefabPlaceholderEntity
in WorldPersistenceTest
to the correct switch
(inside WorldEntity
condition) and unit test will succeed.
b74a937
to
d7509bc
Compare
d7509bc
to
b74a937
Compare
NitroxClient/GameLogic/Spawning/WorldEntities/PrefabPlaceholderEntitySpawner.cs
Outdated
Show resolved
Hide resolved
NitroxClient/GameLogic/Spawning/WorldEntities/PrefabPlaceholderEntitySpawner.cs
Outdated
Show resolved
Hide resolved
NitroxClient/GameLogic/Spawning/WorldEntities/PrefabPlaceholderEntitySpawner.cs
Outdated
Show resolved
Hide resolved
NitroxClient/GameLogic/Spawning/WorldEntities/PrefabPlaceholderEntitySpawner.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One test is failing still. Can be fixed with the comment in SerializedWorldEntitySpawner.cs
and also this change in NitroxClient.GameLogic.Spawning.WorldEntities.CrashEntitySpawner
:
private static readonly Quaternion spawnRotation = new(-0.7f, 0f, 0f, 0.7f); // Equal to Quaternion.Euler(-90f, 0f, 0f)```
NitroxClient/GameLogic/Spawning/WorldEntities/SerializedWorldEntitySpawner.cs
Outdated
Show resolved
Hide resolved
b74a937
to
2af9c87
Compare
Fix Crashes (the explosive fishes)postponed to a further PR which will also fix vehicle constructors and add finitions to the entity system