Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pip-compile on windows #139

Merged
merged 10 commits into from
Jun 12, 2023
Merged

fix: pip-compile on windows #139

merged 10 commits into from
Jun 12, 2023

Conversation

SdgJlbl
Copy link
Contributor

@SdgJlbl SdgJlbl commented Jun 9, 2023

Related issue

# followed by the number of the issue

Summary

Notes

Please check if the PR fulfills these requirements

  • If the feature has an impact on the user experience, the changelog has been updated
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • The commit message follows the conventional commit specification

Signed-off-by: SdgJlbl <sarah.diot-girard@owkin.com>
@SdgJlbl SdgJlbl requested a review from a team as a code owner June 9, 2023 15:46
@SdgJlbl SdgJlbl force-pushed the fix/windows-pip-compile branch 2 times, most recently from cb39862 to 24c1845 Compare June 9, 2023 16:07
Signed-off-by: SdgJlbl <sarah.diot-girard@owkin.com>
@SdgJlbl SdgJlbl force-pushed the fix/windows-pip-compile branch 5 times, most recently from 3a35466 to af7833d Compare June 9, 2023 17:14
Signed-off-by: SdgJlbl <sarah.diot-girard@owkin.com>
SdgJlbl and others added 2 commits June 9, 2023 19:54
Signed-off-by: SdgJlbl <sarah.diot-girard@owkin.com>
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
@ThibaultFy ThibaultFy changed the title Fix: pip-compile on windows fix: pip-compile on windows Jun 12, 2023
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
@ThibaultFy
Copy link
Member

/e2e --tests=substrafl --benchmarks=camelyon

@Owlfred
Copy link

Owlfred commented Jun 12, 2023

End to end tests: ❌ FAILURE

Jobs status:

  • Tests Benchmark:
  • Tests Distributed: ✔️
  • Tests Standalone:

I'm sorry.

Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
Copy link
Contributor Author

@SdgJlbl SdgJlbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved :)
Thanks for finalising the fix

Copy link
Member

@ThibaultFy ThibaultFy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ThibaultFy ThibaultFy merged commit d7235f2 into main Jun 12, 2023
@ThibaultFy ThibaultFy deleted the fix/windows-pip-compile branch June 12, 2023 10:14
ThibaultFy added a commit that referenced this pull request Jun 14, 2023
ThibaultFy added a commit that referenced this pull request Jun 14, 2023
This reverts commit d7235f2.

Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
@ThibaultFy ThibaultFy mentioned this pull request Aug 1, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants