Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pip-compile on windows #139

Merged
merged 10 commits into from
Jun 12, 2023
Merged

fix: pip-compile on windows #139

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2059557
Fix: pip-compile on windows
SdgJlbl Jun 9, 2023
6c3e591
DO NOT MERGE hack
SdgJlbl Jun 9, 2023
ac28eb7
WIP
SdgJlbl Jun 9, 2023
92d028b
WIP
SdgJlbl Jun 9, 2023
c94916f
test fix windows
ThibaultFy Jun 12, 2023
66f7808
test fix windows
ThibaultFy Jun 12, 2023
f32ff38
test fix windows
ThibaultFy Jun 12, 2023
c07547c
chore: fix test
ThibaultFy Jun 12, 2023
4cf4e44
chore: fix test
ThibaultFy Jun 12, 2023
7084ab6
chore: fix test
ThibaultFy Jun 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test fix windows 
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
  • Loading branch information
@ThibaultFy
ThibaultFy committed Jun 12, 2023
commit f32ff38a1ba4388c6d7e321bfd1e11a5072e78e9
5 changes: 1 addition & 4 deletions substrafl/remote/register/manage_dependencies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,10 +190,7 @@ def compile_requirements(dependency_list: List[Union[str, Path]], *, operation_d
requirements = ""
for dependency in dependency_list:
if str(dependency).endswith(".whl"):
if isinstance(dependency, Path):
# the following is necessary for pip-compile to run on Windows
dependency = PurePosixPath(dependency)
requirements += f"file:{dependency}\n"
requirements += f"file:{PurePosixPath(dependency)}\n"
else:
requirements += f"{dependency}\n"
requirements_in.write_text(requirements)
Expand Down