WIP

Signed-off-by: SdgJlbl <sarah.diot-girard@owkin.com>

.github/workflows/main-check.yml

@@ -3,6 +3,9 @@ on:
   push:
     branches:
       - main
+  pull_request:
+    branches:
+      - main
 
 jobs:
   pr-validation:

substrafl/remote/register/manage_dependencies.py

@@ -1,6 +1,8 @@
 """
 Utility functions to manage dependencies (building wheels, compiling requirement...)
 """
+from __future__ import annotations
+
 import logging
 import os
 import re
@@ -165,7 +167,7 @@ def get_pypi_dependencies_versions(lib_modules: List) -> List[str]:
     return [f"{lib_module.__name__}=={lib_module.__version__}" for lib_module in lib_modules]
 
 
-def compile_requirements(dependency_list: List[str], *, operation_dir: Path, sub_dir: Path) -> None:
+def compile_requirements(dependency_list: List[str | Path], *, operation_dir: Path, sub_dir: Path) -> None:
     """Compile a list of requirements using pip-compile to generate a set of fully pinned third parties requirements
 
     Writes down a `requirements.in` file with the list of explicit dependencies, then generates a `requirements.txt`

tests/dependency/test_dependency.py

@@ -2,8 +2,6 @@
 import tempfile
 import uuid
 from pathlib import Path
-from unittest.mock import MagicMock
-from unittest.mock import patch
 
 import numpy as np
 import pytest
@@ -299,14 +297,17 @@ def train(
         utils.wait(client, train_task)
 
     @pytest.mark.docker_only
-    @patch("substrafl.remote.register.register.local_lib_wheels", MagicMock(return_value=["INSTALL IN EDITABLE MODE"]))
     def test_force_editable_mode(
         self,
+        mocker,
         monkeypatch,
         network,
         session_dir,
         dummy_algo_class,
     ):
+        mocker.patch("substrafl.remote.register.register.local_lib_wheels", return_value=["INSTALL IN EDITABLE MODE"])
+        mocker.patch("substrafl.remote.register.register.compile_requirements")
+
         client = network.clients[0]
         algo_deps = Dependency(pypi_dependencies=["pytest"], editable_mode=False)
 

tests/remote/register/test_register.py

@@ -81,6 +81,7 @@ def test_latest_substratools_image_selection(use_latest, monkeypatch, default_pe
         assert "latest" not in str(lines[1])
 
 
+@pytest.mark.skipif(sys.platform.startswith("win"), reason="does not run on windows")
 def test_create_dockerfile(tmp_path, mocker, local_installable_module):
     mocker.patch("substrafl.remote.register.register._get_base_docker_image", return_value="substratools-mocked")
     python_version = f"{sys.version_info.major}.{sys.version_info.minor}"