Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(deploy/otc): ensure backward compatibility for tpl change #1729

Closed
sumo-drosiek opened this issue Sep 6, 2021 · 3 comments
Closed

feat(deploy/otc): ensure backward compatibility for tpl change #1729

sumo-drosiek opened this issue Sep 6, 2021 · 3 comments
Assignees
@kasia-kujawa
Labels
breaking-change needs-triage
Milestone
v3.0

Comments

@sumo-drosiek
Copy link
Contributor

Drop backward compatibility for tpl change

revert #1721
@sumo-drosiek sumo-drosiek added this to the v3.0 milestone Sep 6, 2021
@perk-sumo
Copy link
Contributor

This needs triage.

@perk-sumo
Copy link
Contributor

We need to check if we don't need to migrate off of the Values.fluentd.logs. in our values.yaml

@kasia-kujawa kasia-kujawa self-assigned this Nov 15, 2022
kasia-kujawa added a commit that referenced this issue Nov 18, 2022
@kasia-kujawa
chore: remove replacing values in configuration marked by 'replace' s…
512986f 
…uffix

make values in configuration for otelcol dependended on otelcol parameters in values.yaml

removes "otelcol.k8s.cluster.name"  which was added in #1721 and it is no longer in use

this pull request reverts changes introduced in #1721

related to #1729
@kasia-kujawa kasia-kujawa mentioned this issue Nov 18, 2022
Merged
kasia-kujawa added a commit that referenced this issue Nov 18, 2022
@kasia-kujawa
chore: remove replacing values in configuration marked by 'replace' s…
ed9ece8 
…uffix

make values in configuration for otelcol dependended on otelcol parameters in values.yaml

removes "otelcol.k8s.cluster.name"  which was added in #1721 and it is no longer in use

this pull request reverts changes introduced in #1721

related to #1729
kasia-kujawa added a commit that referenced this issue Nov 18, 2022
@kasia-kujawa
chore: remove replacing values in configuration marked by 'replace' s…
f37b99a 
…uffix

make values in configuration for otelcol dependended on otelcol parameters in values.yaml

removes "otelcol.k8s.cluster.name"  which was added in #1721 and it is no longer in use

this pull request reverts changes introduced in #1721

related to #1729
kasia-kujawa added a commit that referenced this issue Nov 21, 2022
@kasia-kujawa
chore!: remove replacing values in configuration marked by 'replace' …
32a635c 
…suffix

make values in configuration for otelcol dependended on otelcol parameters in values.yaml

removes "otelcol.k8s.cluster.name"  which was added in #1721 and it is no longer in use

this pull request reverts changes introduced in #1721

related to #1729
kasia-kujawa added a commit that referenced this issue Nov 22, 2022
@kasia-kujawa
chore!: remove replacing values in configuration marked by 'replace' …
4892a55 
…suffix

make values in configuration for otelcol dependended on otelcol parameters in values.yaml

removes "otelcol.k8s.cluster.name"  which was added in #1721 and it is no longer in use

this pull request reverts changes introduced in #1721

related to #1729
kasia-kujawa added a commit that referenced this issue Nov 23, 2022
@kasia-kujawa
chore!: remove replacing values in configuration marked by 'replace' …
7a6404f 
…suffix

make values in configuration for otelcol dependended on otelcol parameters in values.yaml

removes "otelcol.k8s.cluster.name"  which was added in #1721 and it is no longer in use

this pull request reverts changes introduced in #1721

related to #1729
kasia-kujawa added a commit that referenced this issue Nov 23, 2022
@kasia-kujawa
chore!: remove replacing values in configuration marked by 'replace' …
98dee38 
…suffix

make values in configuration for otelcol dependended on otelcol parameters in values.yaml

removes "otelcol.k8s.cluster.name"  which was added in #1721 and it is no longer in use

this pull request reverts changes introduced in #1721

related to #1729
kasia-kujawa added a commit that referenced this issue Nov 23, 2022
@kasia-kujawa
chore!: remove replacing values in configuration marked by 'replace' …
f9daff2 
…suffix

make values in configuration for otelcol dependended on otelcol parameters in values.yaml

removes "otelcol.k8s.cluster.name"  which was added in #1721 and it is no longer in use

this pull request reverts changes introduced in #1721

related to #1729
kasia-kujawa added a commit that referenced this issue Nov 23, 2022
@kasia-kujawa
chore!: remove replacing values in configuration marked by 'replace' …
2e7d283 
…suffix

make values in configuration for otelcol dependended on otelcol parameters in values.yaml

removes "otelcol.k8s.cluster.name"  which was added in #1721 and it is no longer in use

this pull request reverts changes introduced in #1721

related to #1729
kasia-kujawa added a commit that referenced this issue Nov 23, 2022
@kasia-kujawa
chore!: remove replacing values in configuration marked by 'replace' …
7b80b8a 
…suffix

make values in configuration for otelcol dependended on otelcol parameters in values.yaml

removes "otelcol.k8s.cluster.name"  which was added in #1721 and it is no longer in use

this pull request reverts changes introduced in #1721

related to #1729
@kasia-kujawa
Copy link
Contributor

Fixed by #2615

We need to remove references to fluentd configuration in otelcol configuration but in my opinion it is not strictly connected to this issue (this will be made in another pull request).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kasia-kujawa kasia-kujawa

Labels
breaking-change needs-triage
Projects
None yet
Milestone
v3.0
Development

No branches or pull requests
3 participants
@sumo-drosiek @perk-sumo @kasia-kujawa