Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(deploy/otc): ensure backward compatibility for tpl change #1721

Merged
merged 1 commit into from
Sep 6, 2021
Merged

feat(deploy/otc): ensure backward compatibility for tpl change #1721

merged 1 commit into from
Sep 6, 2021

Conversation

sumo-drosiek
Copy link
Contributor

Signed-off-by: Dominik Rosiek drosiek@sumologic.com

Description

Fill in your description here.

Testing performed
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@sumo-drosiek sumo-drosiek requested a review from a team as a code owner September 3, 2021 15:07
@sumo-drosiek
Copy link
Contributor Author

related to #1634

feat(deploy/otc): ensure backward compatibility for tpl change
84f9ecb 
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
@sumo-drosiek sumo-drosiek force-pushed the drosiek-tpl-backward-comaptibility branch from 2547738 to 84f9ecb Compare September 3, 2021 15:08
pmalek-sumo
pmalek-sumo approved these changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@pmalek-sumo pmalek-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to use the proposed change (that is reverted in this PR) later on in e.g. 3.0 ?

@sumo-drosiek
Copy link
Contributor Author

@pmalek-sumo Good question. I believe we can just backport it

@sumo-drosiek sumo-drosiek mentioned this pull request Sep 6, 2021
Closed
2 tasks
@sumo-drosiek sumo-drosiek merged commit 40ece1e into main Sep 6, 2021
@sumo-drosiek sumo-drosiek deleted the drosiek-tpl-backward-comaptibility branch September 6, 2021 12:37
This was referenced Sep 6, 2021
Closed
Closed
Merged
@andrzej-stencel andrzej-stencel mentioned this pull request Sep 8, 2022
Closed
kasia-kujawa added a commit that referenced this pull request Nov 16, 2022
@kasia-kujawa
Revert changes introduced in #1721
de64cdd
kasia-kujawa added a commit that referenced this pull request Nov 18, 2022
@kasia-kujawa
Revert changes introduced in #1721
54bf696
kasia-kujawa added a commit that referenced this pull request Nov 18, 2022
@kasia-kujawa
Revert changes introduced in #1721
1107a86
kasia-kujawa added a commit that referenced this pull request Nov 18, 2022
@kasia-kujawa
chore: remove replacing values in configuration marked by 'replace' s…
512986f 
…uffix

make values in configuration for otelcol dependended on otelcol parameters in values.yaml

removes "otelcol.k8s.cluster.name"  which was added in #1721 and it is no longer in use

this pull request reverts changes introduced in #1721

related to #1729
@kasia-kujawa kasia-kujawa mentioned this pull request Nov 18, 2022
Merged
kasia-kujawa added a commit that referenced this pull request Nov 18, 2022
@kasia-kujawa
chore: remove replacing values in configuration marked by 'replace' s…
ed9ece8 
…uffix

make values in configuration for otelcol dependended on otelcol parameters in values.yaml

removes "otelcol.k8s.cluster.name"  which was added in #1721 and it is no longer in use

this pull request reverts changes introduced in #1721

related to #1729
kasia-kujawa added a commit that referenced this pull request Nov 18, 2022
@kasia-kujawa
chore: remove replacing values in configuration marked by 'replace' s…
f37b99a 
…uffix

make values in configuration for otelcol dependended on otelcol parameters in values.yaml

removes "otelcol.k8s.cluster.name"  which was added in #1721 and it is no longer in use

this pull request reverts changes introduced in #1721

related to #1729
kasia-kujawa added a commit that referenced this pull request Nov 21, 2022
@kasia-kujawa
chore!: remove replacing values in configuration marked by 'replace' …
32a635c 
…suffix

make values in configuration for otelcol dependended on otelcol parameters in values.yaml

removes "otelcol.k8s.cluster.name"  which was added in #1721 and it is no longer in use

this pull request reverts changes introduced in #1721

related to #1729
kasia-kujawa added a commit that referenced this pull request Nov 22, 2022
@kasia-kujawa
chore!: remove replacing values in configuration marked by 'replace' …
4892a55 
…suffix

make values in configuration for otelcol dependended on otelcol parameters in values.yaml

removes "otelcol.k8s.cluster.name"  which was added in #1721 and it is no longer in use

this pull request reverts changes introduced in #1721

related to #1729
kasia-kujawa added a commit that referenced this pull request Nov 23, 2022
@kasia-kujawa
chore!: remove replacing values in configuration marked by 'replace' …
7a6404f 
…suffix

make values in configuration for otelcol dependended on otelcol parameters in values.yaml

removes "otelcol.k8s.cluster.name"  which was added in #1721 and it is no longer in use

this pull request reverts changes introduced in #1721

related to #1729
kasia-kujawa added a commit that referenced this pull request Nov 23, 2022
@kasia-kujawa
chore!: remove replacing values in configuration marked by 'replace' …
98dee38 
…suffix

make values in configuration for otelcol dependended on otelcol parameters in values.yaml

removes "otelcol.k8s.cluster.name"  which was added in #1721 and it is no longer in use

this pull request reverts changes introduced in #1721

related to #1729
kasia-kujawa added a commit that referenced this pull request Nov 23, 2022
@kasia-kujawa
chore!: remove replacing values in configuration marked by 'replace' …
f9daff2 
…suffix

make values in configuration for otelcol dependended on otelcol parameters in values.yaml

removes "otelcol.k8s.cluster.name"  which was added in #1721 and it is no longer in use

this pull request reverts changes introduced in #1721

related to #1729
kasia-kujawa added a commit that referenced this pull request Nov 23, 2022
@kasia-kujawa
chore!: remove replacing values in configuration marked by 'replace' …
2e7d283 
…suffix

make values in configuration for otelcol dependended on otelcol parameters in values.yaml

removes "otelcol.k8s.cluster.name"  which was added in #1721 and it is no longer in use

this pull request reverts changes introduced in #1721

related to #1729
kasia-kujawa added a commit that referenced this pull request Nov 23, 2022
@kasia-kujawa
chore!: remove replacing values in configuration marked by 'replace' …
7b80b8a 
…suffix

make values in configuration for otelcol dependended on otelcol parameters in values.yaml

removes "otelcol.k8s.cluster.name"  which was added in #1721 and it is no longer in use

this pull request reverts changes introduced in #1721

related to #1729
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@pmalek-sumo pmalek-sumo pmalek-sumo approved these changes

@perk-sumo perk-sumo Awaiting requested review from perk-sumo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sumo-drosiek @pmalek-sumo